linux-toradex.git/drivers/ipack, branch toradex_vf_4.1-next

ipoctal: clear break interrupt as soon as it occurs

2014-09-24T06:26:42+00:00

In some condition we receive the break interrupt but nothing is putted
in the Rx FIFO and the correspondend bit in the status register is not
set. Thus, no-one clear the interrupt and the handler will be called
forever.

This patch clear the break interrupt as soon as it occurs. Then, if the
break character '\0' is putted in the fifo we will manage it.

We can also unmask the Break interrupt but its bit in ISR is still set
on break. So I think is better to keep the registers clean.

Signed-off-by: Federico Vaga 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipoctal: get carrier driver to avoid rmmod

2014-09-24T06:13:13+00:00

Signed-off-by: Federico Vaga 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipack: save carrier owner to allow device to get it

2014-09-24T06:13:13+00:00

There was not any kind of protection against carrier driver removal.
In this way, device driver can 'get' the carrier driver when it is
using it.

Signed-off-by: Federico Vaga 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipoctal: reset function istead of duplicate code

2014-09-24T06:13:13+00:00

Signed-off-by: Federico Vaga 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

drivers/ipack/devices/ipoctal.h: Fix typo in include guard

2014-09-24T06:13:13+00:00

Signed-off-by: Rasmus Villemoes 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipack: Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18T23:50:55+00:00

We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
kernel coding style guidelines. This issue was reported by checkpatch.

Signed-off-by: Benoit Taine 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipoctal: request_irq after configuration

2014-07-10T00:02:15+00:00

The request for an IRQ handler must be done after whole configuration. This
was not the case for this driver which request the IRQ in the middle of
the configuration. Sometimes, it happens that something is not completely
configured, we recieve an interrupt thus we stumble into troubles in the
IRQ handler.

Signed-off-by: Federico Vaga 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipoctal: protect only the real critical section

2014-07-10T00:02:15+00:00

In some conditions (echo or particular sequence of special
characters), on buffer push, the tty layer calls the write operation
while we are holding the spinlock. This means deadlock within the same
process on kernels version < 3.12. It seems not a problem on recent
kernel, but the patch still valid as locking optimization.

The protected variables by the spinlock are: xmit_buf, nb_bytes,
pointer_read and pointer_write. So, this patch reduces the locked area
in the IRQ handler only to these variables. Most of the code inside the
locked area in the IRQ handler is not protected elsewhere; it means
that it is not protected at all.

Signed-off-by: Federico Vaga 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipack: convert bus code to use dev_groups

2013-10-17T01:40:57+00:00

The dev_attrs field of struct bus_type is going away soon, dev_groups
should be used instead.  This converts the ipack bus code to use the
correct field.

Acked-by: Samuel Iglesias Gonsalvez 
Cc: Jens Taprogge 
Cc: 
Signed-off-by: Greg Kroah-Hartman

ipack: split ipack_device_register() in several functions

2013-03-15T19:23:09+00:00

One function is ipack_device_init(). If it fails, the caller should execute
ipack_put_device().

The second function is ipack_device_add that only adds the device. If
it fails, the caller should execute ipack_put_device().

Then the device is removed with refcount = 0, as device_register() kernel
documentation says.

ipack_device_del() is added to remove the device.

Signed-off-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman