linux-toradex.git/drivers/isdn, branch v2.6.23-rc2

Remove 'isdn_* is defined but unused' warnings

2007-07-31T22:39:44+00:00

Move the #ifdef guard above these functions to remove the warnings.

Signed-off-by: Charlie Shepherd 
Cc: Karsten Keil 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Use menuconfig objects: ISDN/Gigaset

2007-07-22T00:49:17+00:00

Change Kconfig objects from "menu, config" into "menuconfig" so that the user
can disable the whole feature without having to enter the menu first.

Signed-off-by: Jan Engelhardt 
Cc: Tilman Schmidt 
Acked-by: Karsten Keil 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Use menuconfig objects: ISDN

2007-07-22T00:49:17+00:00

Unclutter the ISDN menu a tiny bit by moving ISDN4Linux and the CAPI2.0
layers into their own menu.

Signed-off-by: Jan Engelhardt 
Cc: Tilman Schmidt 
Acked-by: Karsten Keil 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Use menuconfig objects - CONFIG_ISDN_I4L

2007-07-22T00:49:17+00:00

Remove a menu statement and several dependencies from the Kconfig files in
the drivers/isdn tree as they have become unnecessary by the transformation
of CONFIG_ISDN from "menu, config" into "menuconfig".
(Modified version of a patch originally proposed by Jan Engelhardt.)

Signed-off-by: Tilman Schmidt 
Cc: Jan Engelhardt 
Acked-by: Karsten Keil 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

isdn/sc: compile breakage re check_reset()

2007-07-19T17:04:50+00:00

There is check_reset() -- global function in drivers/isdn/sc/
There is check_reset -- variable holding module param in aacraid driver.

On allyesconfig they clash with:

  LD      drivers/built-in.o
drivers/isdn/built-in.o: In function `check_reset':
: multiple definition of `check_reset'
drivers/scsi/built-in.o:(.data+0xe458): first defined here
ld: Warning: size of symbol `check_reset' changed from 4 in drivers/scsi/built-in.o to 219 in drivers/isdn/built-in.o
ld: Warning: type of symbol `check_reset' changed from 1 to 2 in drivers/isdn/built-in.o

Rename the former.

Signed-off-by: Alexey Dobriyan 
Cc: Karsten Keil 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ISDN HiSax: uninitialized return in hisax_cs_setup

2007-07-18T22:17:23+00:00

Coverity (1792) spotted a possibly uninitialized return value in case of
kmalloc() failure:

1116 static int hisax_cs_setup(int cardnr, struct IsdnCard *card,
1117                           struct IsdnCardState *cs)
1119         int ret;
1120
1121         if (!(cs->rcvbuf = kmalloc(MAX_DFRAME_LEN_L1, GFP_ATOMIC))) {
1122                 printk(KERN_WARNING "HiSax: No memory for isac rcvbuf\n");
1123                 ll_unload(cs);
1124                 goto outf_cs;
...
1165 outf_cs:
1166         kfree(cs);
1167         card->cs = NULL;
1168         return ret;

The straightforward solution would be to just add the missing
initialization but hardcoding the return value in the out_cs branch
(only taken on failure) seems to work just as well and it allows killing
a couple of other lines too.

Signed-off-by: Florin Malita 
Signed-off-by: Jeff Garzik

[ISDN] HiSax hfc_pci: minor cleanups

2007-07-17T21:26:24+00:00

* trim trailing whitespace
* remove CONFIG_PCI ifdefs, this driver is always PCI (Kconfig enforced)
* remove return statements at the tail of a function
* remove indentation levels by returning an error code immediately.
  Makes the code much more readable, and easier to update to PCI hotplug
  API.

Signed-off-by: Jeff Garzik

[ISDN] HiSax bkm_a4t: split setup into two smaller functions

2007-07-17T21:24:17+00:00

No behavior changes, just code movement.  Prep for PCI hotplug API.

Well, CONFIG_PCI useless ifdef was removed.

Signed-off-by: Jeff Garzik

[ISDN] HiSax enternow: split setup into 3 smaller functions

2007-07-17T21:23:22+00:00

No behavior changes, just code movement.  Prep for PCI hotplug API.

Signed-off-by: Jeff Garzik

[ISDN] HiSax netjet_u: split setup into 3 smaller functions

2007-07-17T21:21:37+00:00

No behavior changes, just code movement.  Prep for PCI hotplug API.

Signed-off-by: Jeff Garzik