linux-toradex.git/drivers/leds/led-core.c, branch v3.6.1

leds: fix sparse warnings due to missing static

2012-07-23T23:52:35+00:00

drivers/leds/led-core.c:56:6: sparse: symbol 'led_blink_setup' was not declared. Should it be static?
drivers/leds/led-triggers.c:233:6: sparse: symbol 'led_trigger_blink_setup' was not declared. Should it be static?

Reported-by: Fengguang Wu 
Signed-off-by: Bryan Wu

leds: Rename led_brightness_set() to led_set_brightness()

2012-07-23T23:52:34+00:00

Rename leds external interface led_brightness_set() to led_set_brightness().
This is the second phase of the change to reduce confusion between the
leds internal and external interfaces that set brightness. With this change,
now the external interface is led_set_brightness(). The first phase renamed
the internal interface led_set_brightness() to __led_set_brightness().
There are no changes to the interface implementations.

Signed-off-by: Shuah Khan 
Signed-off-by: Bryan Wu

leds: Rename led_set_brightness() to __led_set_brightness()

2012-07-23T23:52:34+00:00

Rename leds internal interface led_set_brightness() to __led_set_brightness()
to reduce confusion between led_set_brightness() and the external interface
led_brightness_set(). led_brightness_set() cancels the timer and then calls
led_set_brightness().

Signed-off-by: Shuah Khan 
Signed-off-by: Bryan Wu

leds: fix led_brightness_set when soft-blinking

2012-07-23T23:52:34+00:00

Move led_stop_software_blink() code into led_brightness_set() to ensure
software blink timer is stopped and cleared when changing trigger.

Also use led_set_brightness() instead of calling
led_cdev->brightness_set() directly to keep led_cdev->brightness
consistent with current LED status.

This ensure proper cleaning when changing triggers, as without this fix
a LED may be turned off while leaving it's led_cdev->brightness = 1,
leading to an erratic software-blink behaviour.

The problem was easy to reproduce by changing the trigger from "timer"
to "oneshot".

Signed-off-by: Fabio Baltieri 
Signed-off-by: Bryan Wu

leds: add oneshot blink functions

2012-07-23T23:52:34+00:00

Add two new functions, led_blink_set_oneshot and
led_trigger_blink_oneshot, to be used by triggers for one-shot blink of
led devices.

This is implemented extending the existing software-blink code, and uses
the same timer and handler function.

The behavior of the code is to do a blink-on, blink-off sequence when
the function is called, ignoring other calls until the sequence is
completed so that the leds keep blinking at constant rate if the
functions are called repeatedly.

This is meant to be used by drivers which needs to trigger on sporadic
event, but doesn't have clear busy/idle trigger points.

After the blink sequence the led remains off. This behavior can be
inverted setting the "invert" argument, which blink the led off, than on
and leave the led on after the sequence.

(bryan.wu@canonical.com: rebase to commit 'leds: don't disable blinking
when writing the same value to delay_on or delay_off')

Signed-off-by: Fabio Baltieri 
Acked-by: Shuah Khan 
Signed-off-by: Bryan Wu

leds: don't disable blinking when writing the same value to delay_on or delay_off

2012-06-12T02:56:24+00:00

Function led_set_software_blink() assumes that blink timer is still running,
but commit 488bc35bf40df89d37486c1826b178a2fba36ce7 introduced disabling
of blink timer before each call to led_set_software_blink().

Correct led_software_blink():
1) remove protection against reprogramming blink timer to the same values,
   because it only disables blinking now,
2) remove unnecessary call to led_stop_software_blink().

Signed-off-by: Rafal Prylowski 
Cc: Richard Purdie 
Signed-off-by: Bryan Wu

led-class: change back LEDS_CLASS to tristate instead of bool

2012-03-23T23:58:35+00:00

After moving some core functions to led-core.c, led-class.c can be built
as module again.

Signed-off-by: Bryan Wu 
Acked-by: Richard Purdie 
Acked-by: Linus Walleij 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

leds: Cleanup various whitespace and code style issues

2008-04-24T22:37:42+00:00

Break the lines which were more than 80 characters into more
lines; replace SPACEs with TABs; correct ident at switch-case;
change character encoding from ISO-8859-2 to UTF-8.

The order of the functions in led-triggers.c changed in order
the similar functions can still be together under titles
"Used by LED Class", "LED Trigger Interface" and "Simple
LED Tigger Interface" as was grouped before when exported
with EXPORT_SYMBOL.

Signed-off-by: Márton Németh 
Signed-off-by: Richard Purdie

leds: Fix leds_list_lock locking issues

2007-12-31T23:09:44+00:00

Covert leds_list_lock to a rw_sempahore to match previous LED trigger
locking fixes, fixing lock ordering.

Signed-off-by: Richard Purdie

[PATCH] spin/rwlock init cleanups

2006-06-28T00:32:39+00:00

locking init cleanups:

 - convert " = SPIN_LOCK_UNLOCKED" to spin_lock_init() or DEFINE_SPINLOCK()
 - convert rwlocks in a similar manner

this patch was generated automatically.

Motivation:

 - cleanliness
 - lockdep needs control of lock initialization, which the open-coded
   variants do not give
 - it's also useful for -rt and for lock debugging in general

Signed-off-by: Ingo Molnar 
Signed-off-by: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds