linux-toradex.git/drivers/leds/leds-gpio.c, branch v4.9.131

leds: gpio: fix and simplify error handling in gpio_leds_create

2016-09-15T14:49:43+00:00

Simplify the error handling and add a missing call to fwnode_handle_put
when checking led.name.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: switch to managed version of led_classdev_register

2016-09-15T14:49:42+00:00

Using the managed version of led_classdev_register allows to
significantly simplify the code.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: fix and simplify reading property "label"

2016-09-15T14:49:42+00:00

Checking for the presence of the property first isn't strictly needed
as we can react on the return code of fwnode_property_read_string.
Also, even if the presence of a property "label" was checked,
reading a string value for it theoretically still can fail and
this case isn't handled.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: simplify gpio_leds_create

2016-09-15T14:49:41+00:00

Definition of np can be moved into the loop as well to simplify
the code a little.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: add helper cdev_to_gpio_led_data

2016-09-15T14:49:40+00:00

Add a helper for the container_of as it's used more than once.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: fix an unhandled error case in create_gpio_led

2016-09-15T14:49:40+00:00

gpiod_get_value_cansleep returns 0, 1, or an error code.
So far errors are not handled and treated the same as 1.
Change this to bail out if an error code is returned and
remove the double negation.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: introduce gpio_blink_set_t

2016-09-15T14:49:39+00:00

Introduce a typedef gpio_blink_set_t to improve readability of the code.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: leds-gpio: Set of_node for created LED devices

2016-07-11T08:15:03+00:00

When working with Device Tree we iterate over children of "gpio-leds"
compatible node and create LED device for each of them. We take care of
all common DT properties (label, default trigger, state, etc.), however
some triggers may want to support more of them.

It could be useful for timer trigger to support setting delay on/off
values with Device Tree property. Or for transient trigger to support
e.g. duration property.

We obviously should handle such properties in triggers, not in generic
code. To let trigger drivers read properties from DT node we need to set
of_node to point the relevant node. This change allows using all kind of
of helpers in e.g. "activate" callbacks.

Signed-off-by: Rafał Miłecki 
Signed-off-by: Jacek Anaszewski

leds: gpio: Support the "panic-indicator" firmware property

2016-05-06T08:26:07+00:00

Calling a GPIO LEDs is quite likely to work even if the kernel
has paniced, so they are ideal to blink in this situation.
This commit adds support for the new "panic-indicator"
firmware property, allowing to mark a given LED to blink on
a kernel panic.

Signed-off-by: Ezequiel Garcia 
Reviewed-by: Matthias Brugger 
Acked-by: Pavel Machek 
Signed-off-by: Jacek Anaszewski

leds: gpio: Use GPIOF_OUT_INIT_LOW instead of hardcoded zero

2016-03-14T08:22:21+00:00

Use the GPIO flag definition instead of a numeric literal, so the casual
reader grepping for GPIOF_ will find the GPIO flags used.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Jacek Anaszewski