linux-toradex.git/drivers/leds/leds-gpio.c, branch v5.6-rc5

leds: gpio: Fix uninitialized gpio label for fwnode based probe

2020-01-22T20:06:25+00:00

When switching to using generic LED name composition mechanism via
devm_led_classdev_register_ext() API the part of code initializing
struct gpio_led's template name property was removed alongside.
It was however overlooked that the property was also passed to
devm_fwnode_get_gpiod_from_child() in place of "label" parameter,
which when set to NULL, results in gpio label being initialized to '?'.

It could be observed in debugfs and failed to properly identify
gpio association with LED consumer.

Fix this shortcoming by updating the GPIO label after the LED is
registered and its final name is known.

Fixes: d7235f5feaa0 ("leds: gpio: Use generic support for composing LED names")
Cc: Russell King 
Reviewed-by: Linus Walleij 
Signed-off-by: Jacek Anaszewski 
[fixed comment]
Signed-off-by: Pavel Machek

leds: gpio: Use generic support for composing LED names

2019-07-25T18:08:01+00:00

Switch to using generic LED support for composing LED class
device name.

Signed-off-by: Jacek Anaszewski 
Cc: Linus Walleij 
Acked-by: Pavel Machek

leds: class: Improve LED and LED flash class registration API

2019-07-25T18:07:50+00:00

Replace of_led_classdev_register() with led_classdev_register_ext(), which
accepts easily extendable struct led_init_data, instead of the fixed
struct device_node argument. The latter can be now passed in an fwnode
property of the struct led_init_data.

The modification is driven by the need for passing additional arguments
required for the forthcoming generic mechanism for composing LED names.
Currently the LED name is conveyed in the "name" char pointer property of
the struct led_classdev. This is redundant since LED class device name
is accessible throughout the whole LED class device life time via
associated struct device's kobj->name property.

The change will not break any existing clients since the patch alters
also existing led_classdev{_flash}_register() macro wrappers, that pass
NULL in place of init_data, which leads to using legacy name
initialization path basing on the struct led_classdev's "name" property.

Three existing users of devm_of_led_classdev_registers() are modified
to use devm_led_classdev_register(), which will not impact their
operation since they in fact didn't need to pass struct device_node on
registration from the beginning.

Signed-off-by: Jacek Anaszewski 
Cc: Baolin Wang 
Cc: Dan Murphy 
Cc: Daniel Mack 
Cc: Linus Walleij 
Cc: Oleh Kravchenko 
Cc: Sakari Ailus 
Cc: Simon Shields 
Acked-by: Pavel Machek

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

2019-06-19T15:09:55+00:00

Based on 2 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation #

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 4122 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Enrico Weigelt 
Reviewed-by: Kate Stewart 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
Signed-off-by: Greg Kroah-Hartman

leds: gpio: Drop unneeded manual of_node assignment

2018-12-08T17:17:14+00:00

This reverts the main change of commit bff23714bc36 ("leds: leds-gpio:
Set of_node for created LED devices") because of_node assignment is
handled by core since commit 7ea79ae86c28 ("leds: gpio: use OF variant
of LED registering function").  Basically the code was overwriting the
of_node with same value.

No functional change expected.

Signed-off-by: Krzysztof Kozlowski 
Tested-by: Rafał Miłecki 
Signed-off-by: Jacek Anaszewski

leds: gpio: set led_dat->gpiod pointer for OF defined GPIO leds

2018-10-26T18:51:36+00:00

Commit 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
removed the common code path that set the led_dat->gpiod pointer in
create_gpio_led(), but only added it back for the devices that have
a valid gpio_led_platform_data structure. Calling gpio_leds_create()
in gpio_led_probe() is not enough to get a valid gpiod pointer.

Fortunately enough, gpio_leds_create() already gets the needed pointer,
we just need to assign it to the relevant gpio_led_data structure.

Fixes: 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
Signed-off-by: Liviu Dudau 
Reviewed-by: Linus Walleij 
Acked-by: Pavel Machek 
Signed-off-by: Jacek Anaszewski

leds: gpio: Try to lookup gpiod from device

2018-09-10T19:14:17+00:00

This augments the GPIO lookup code in the GPIO LEDs to
attempt to look up a GPIO descriptor from the device with
index.

This makes it possible to use GPIO machine look-up tables
and stop passing global GPIO numbers through platform data.

Using this we can stepwise convert existing board files
to use machine descriptor tables and then eventually drop
the legacy GPIO support and only include
 and use descriptors exclusively.

Signed-off-by: Linus Walleij 
Signed-off-by: Jacek Anaszewski

leds: gpio: Allow LED to retain state at shutdown

2017-08-29T19:10:40+00:00

In some systems, such as Baseboard Management Controllers (BMCs), we
want to retain the state of LEDs across a reboot of the BMC (whilst the
host remains up). Implement support for the retain-state-shutdown
devicetree property in leds-gpio.

Signed-off-by: Andrew Jeffery 
Acked-by: Pavel Machek 
Tested-by: Brandon Wyman 
Signed-off-by: Jacek Anaszewski

leds: gpio: use OF variant of LED registering function

2017-03-08T20:10:02+00:00

In leds-gpio we support LEDs specified in DT so we should use
(devm_)of_led_classdev_register. This allows passing DT node as argument
for use by the LED subsystem.

Signed-off-by: Rafał Miłecki 
Acked-by: Pavel Machek 
Signed-off-by: Jacek Anaszewski

gpio: Rename devm_get_gpiod_from_child()

2017-02-04T20:27:26+00:00

Rename devm_get_gpiod_from_child() into
devm_fwnode_get_gpiod_from_child() to reflect the fact that this
function is operating on a fwnode object.

Signed-off-by: Boris Brezillon 
Acked-by: Jacek Anaszewski 
Acked-by: Dmitry Torokhov 
Signed-off-by: Linus Walleij