linux-toradex.git/drivers/leds/leds-lp5521.c, branch v3.6-rc2

leds: convert LP5521 LED driver to devm_kzalloc() and cleanup error exit path

2012-07-23T23:52:37+00:00

Signed-off-by: Bryan Wu

drivers/leds/leds-lp5521.c: fix lp5521_read() error handling

2012-05-29T23:22:31+00:00

Gcc 4.6.2 complains that:

  drivers/leds/leds-lp5521.c: In function `lp5521_load_program':
  drivers/leds/leds-lp5521.c:214:21: warning: `mode' may be used uninitialized in this function [-Wuninitialized]
  drivers/leds/leds-lp5521.c: In function `lp5521_probe':
  drivers/leds/leds-lp5521.c:788:5: warning: `buf' may be used uninitialized in this function [-Wuninitialized]
  drivers/leds/leds-lp5521.c:740:6: warning: `ret' may be used uninitialized in this function [-Wuninitialized]

These are real problems if lp5521_read() returns an error.  When that
happens we should handle it, instead of ignoring it or doing a bitwise
OR with all the other error codes and continuing.

Signed-off-by: Dan Carpenter 
Cc: Milo 
Cc: Richard Purdie 
Cc: Bryan Wu 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/leds/leds-lp5521.c: ret may be uninitialized

2012-03-23T23:58:35+00:00

Fix it by assigning the lp5521_read return value.

Signed-off-by: srinidhi kasagar 
Cc: Milo(Woogyom) Kim 
Cc: Linus Walleij 
Cc: Arun MURTHY 
Cc: Richard Purdie 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/leds/leds-lp5521.c: redefinition of register bits

2012-03-23T23:58:34+00:00

For better readability, values of LP5521_REG_ENABLE register were
redefined= .  Additional definitions: LP5521_ENABLE_DEFAULT and
LP5521_ENABLE_RUN_PROGRAM= .

Use definition rather than hard code value.
: 0x3F -> 'LP5521_CMD_DIRECT'

Signed-off-by: Milo(Woogyom) Kim 
Acked-by: Linus Walleij 
Cc: Arun MURTHY 
Cc: Srinidhi Kasagar 
Cc: Richard Purdie 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/leds/leds-lp5521.c: support led pattern data

2012-03-23T23:58:34+00:00

The lp5521 has autonomous operation mode without external control.
Using lp5521_platform_data, various led patterns can be configurable.
For supporting this feature, new functions and device attribute are
added.

Structure of lp5521_led_pattern: 3 channels are supported - red, green
and blue.  Pattern(s) of each channel and numbers of pattern(s) are
defined in the pla= tform data.  Pattern data are hexa codes which
include pattern commands such like set pwm, wait, ramp up/down, branch
and so on.

Pattern mode functions:
 * lp5521_clear_program_memory
	Before running new led pattern, program memory should be cleared.
 * lp5521_write_program_memory
	Pattern data updated in the program memory via the i2c.
 * lp5521_get_pattern
	Get pattern from predefined in the platform data.
 * lp5521_run_led_pattern
	Stop current pattern or run new pattern.
	Transition time is required between different operation mode.

Device attribute - 'led_pattern': To load specific led pattern, new device
attribute is added.

When the lp5521 driver is unloaded, stop current led pattern mode.

Documentation updated : description about how to define the led patterns
and example.

[akpm@linux-foundation.org: checkpatch fixes]
Signed-off-by: Milo(Woogyom) Kim 
Acked-by: Linus Walleij 
Cc: Arun MURTHY 
Cc: Srinidhi Kasagar 
Cc: Richard Purdie 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/leds/leds-lp5521.c: add 'update_config' in the lp5521_platform_data

2012-03-23T23:58:34+00:00

The value of CONFIG register(Addr 08h) is configurable.  For supporting
this feature, update_config is added in the platform data.  If
'update_config' is not defined, the default value is 'LP5521_PWRSAVE_EN |
LP5521_CP_MODE_AUTO | LP5521_R_TO_BATT'.

To define CONFIG register in the platform data, the bit definitions were
mo= ved to the header file.

Documentation updated : description about 'update_config' and example.

Signed-off-by: Milo(Woogyom) Kim 
Acked-by: Linus Walleij 
Cc: Arun MURTHY 
Cc: Srinidhi Kasagar 
Cc: Richard Purdie 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/leds/leds-lp5521.c: add 'name' in the lp5521_led_config

2012-03-23T23:58:34+00:00

The name of each led channel can be configurable.  For the compatibility,
the name is set to default value(xx:channelN) when 'name' is not defined.

Signed-off-by: Milo(Woogyom) Kim 
Acked-by: Linus Walleij 
Cc: Arun MURTHY 
Cc: Srinidhi Kasagar 
Cc: Richard Purdie 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/leds/leds-lp5521.c: fix typo

2012-03-23T23:58:34+00:00

"reseting" -> "resetting"

Signed-off-by: Masanari Iida 
Cc: Richard Purdie 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

leds: convert led i2c drivers to module_i2c_driver

2012-01-11T00:30:48+00:00

Factor out some boilerplate code for i2c driver registration
into module_i2c_driver.

Signed-off-by: Axel Lin 
Cc: Haojian Zhuang 
Cc: Mark Brown 
Cc: Richard Purdie 
Cc: Michael Hennerich 
Cc: Mike Rapoport 
Cc: Guennadi Liakhovetski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/leds/leds-lp5521.c: check if reset is successful

2011-11-01T00:30:55+00:00

Make sure that the reset is successful by issuing a dummy read to R
channel current register and check its default value.  On some platforms,
without this dummy read, any further access to {R/G/B}_EXEC will not have
any impact.

[akpm@linux-foundation.org: fix up code comment]
Signed-off-by: srinidhi kasagar 
Tested-by: Naga Radhesh 
Acked-by: Linus Walleij 
Cc: Richard Purdie 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds