linux-toradex.git/drivers/leds, branch v3.9.7

leds: leds-gpio: reserve gpio before using it

2013-06-07T19:53:36+00:00

commit 803d19d57a042e86e9e9b685bbc3f4a0a751040f upstream.

This reverts commit a99d76f (leds: leds-gpio: use gpio_request_one)
and commit 2d7c22f (leds: leds-gpio: set devm_gpio_request_one()
flags param correctly) which was a fix of the first one.

The conversion to devm_gpio_request in commit e3b1d44c (leds:
leds-gpio: use devm_gpio_request_one) is not reverted.

The problem is that gpio_cansleep() and gpio_get_value_cansleep()
calls can crash if the gpio is not first reserved. Incidentally this
same bug existed earlier and was fixed similarly in commit d95cbe61
(leds: Fix potential leds-gpio oops). But the OOPS is real. It happens
when GPIOs are provided by module which is not yet loaded.

So this fixes the following BUG during my ALIX boot (3.9.2-vanilla):

BUG: unable to handle kernel NULL pointer dereference at 0000004c
IP: [] __gpio_cansleep+0xe/0x1a
*pde = 00000000
Oops: 0000 [#1] SMP
Modules linked in: leds_gpio(+) via_rhine mii cs5535_mfd mfd_core
geode_rng rng_core geode_aes isofs nls_utf8 nls_cp437 vfat fat
ata_generic pata_amd pata_cs5536 pata_acpi libata ehci_pci ehci_hcd
ohci_hcd usb_storage usbcore usb_common sd_mod scsi_mod squashfs loop
Pid: 881, comm: modprobe Not tainted 3.9.2 #1-Alpine
EIP: 0060:[] EFLAGS: 00010282 CPU: 0
EIP is at __gpio_cansleep+0xe/0x1a
EAX: 00000000 EBX: cf364018 ECX: c132b8b9 EDX: 00000000
ESI: c13993a4 EDI: c1399370 EBP: cded9dbc ESP: cded9dbc
 DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
CR0: 8005003b CR2: 0000004c CR3: 0f0c4000 CR4: 00000090
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
Process modprobe (pid: 881, ti=cded8000 task=cf094aa0 task.ti=cded8000)
Stack:
 cded9de0 d09471cb 00000000 c1399260 cf364014 00000000 c1399260 c1399254
 d0949014 cded9df4 c118cd59 c1399260 d0949014 d0949014 cded9e08 c118ba47
 c1399260 d0949014 c1399294 cded9e1c c118bb75 cded9e24 d0949014 00000000
Call Trace:
 [] gpio_led_probe+0xba/0x203 [leds_gpio]
 [] platform_drv_probe+0x26/0x48
 [] driver_probe_device+0x75/0x15c
 [] __driver_attach+0x47/0x63
 [] bus_for_each_dev+0x3c/0x66
 [] driver_attach+0x14/0x16
 [] ? driver_probe_device+0x15c/0x15c
 [] bus_add_driver+0xbd/0x1bc
 [] ? 0xd08b3fff
 [] ? 0xd08b3fff
 [] driver_register+0x74/0xec
 [] ? 0xd08b3fff
 [] platform_driver_register+0x38/0x3a
 [] gpio_led_driver_init+0xd/0x1000 [leds_gpio]
 [] do_one_initcall+0x6b/0x10f
 [] ? 0xd08b3fff
 [] load_module+0x1631/0x1907
 [] ? insert_vmalloc_vmlist+0x14/0x43
 [] ? __vmalloc_node_range+0x13e/0x15f
 [] sys_init_module+0x62/0x77
 [] syscall_call+0x7/0xb
EIP: [] __gpio_cansleep+0xe/0x1a SS:ESP 0068:cded9dbc
CR2: 000000000000004c
 ---[ end trace 5308fb20d2514822 ]---

Signed-off-by: Timo Teräs 
Cc: Sachin Kamat 
Cc: Raphael Assenat 
Cc: Trent Piepho 
Cc: Javier Martinez Canillas 
Cc: Arnaud Patard 
Cc: Ezequiel Garcia 
Acked-by: Jingoo Han 
Signed-off-by: Bryan Wu 
Signed-off-by: Jonghwan Choi 
Signed-off-by: Greg Kroah-Hartman

drivers/leds/leds-ot200.c: fix error caused by shifted mask

2013-06-07T19:52:39+00:00

commit 4b949b8af12e24b8a48fa5bb775a13b558d9f4da upstream.

During the development of this driver an in-house register documentation
was used.  The last week some integration tests were done and this
problem was found.  It turned out that the released register
documentation is wrong.

The fix is very simple: shift all masks by one.

Signed-off-by: Christian Gmeiner 
Cc: Bryan Wu 
Cc: Sebastian Andrzej Siewior 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds

2013-02-26T17:29:02+00:00

Pull LED subsystem update from Bryan Wu.

* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds: (61 commits)
  leds: leds-sunfire: use dev_err()/pr_err() instead of printk()
  leds: 88pm860x: Add missing of_node_put()
  leds: tca6507: Use of_get_child_count()
  leds: leds-pwm: make it depend on PWM and not HAVE_PWM
  Documentation: leds: update LP55xx family devices
  leds-lp55xx: fix problem on removing LED attributes
  leds-lp5521/5523: add author and copyright description
  leds-lp5521/5523: use new lp55xx common header
  leds-lp55xx: clean up headers
  leds-lp55xx: clean up definitions
  leds-lp55xx: clean up unused data and functions
  leds-lp55xx: clean up _remove()
  leds-lp55xx: add new function for removing device attribtues
  leds-lp55xx: code refactoring on selftest function
  leds-lp55xx: use common device attribute driver function
  leds-lp55xx: support device specific attributes
  leds-lp5523: use generic firmware interface
  leds-lp5521: use generic firmware interface
  leds-lp55xx: support firmware interface
  leds-lp55xx: add new lp55xx_register_sysfs() for the firmware interface
  ...

leds: leds-sunfire: use dev_err()/pr_err() instead of printk()

2013-02-07T00:00:43+00:00

Fixed the checkpatch errors and warnings as below:

  ERROR: spaces required around that '=' (ctx:VxW)
  WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: Jingoo Han 
Signed-off-by: Bryan Wu

leds: 88pm860x: Add missing of_node_put()

2013-02-07T00:00:43+00:00

of_find_node_by_name() returns a node pointer with refcount incremented, use
of_node_put() on it when done.

of_find_node_by_name() will call of_node_put() against from parameter,
thus we also need to call of_node_get(from) before calling
of_find_node_by_name().

Signed-off-by: Axel Lin 
Signed-off-by: Bryan Wu

leds: tca6507: Use of_get_child_count()

2013-02-07T00:00:42+00:00

Signed-off-by: Axel Lin 
Signed-off-by: Bryan Wu

leds: leds-pwm: make it depend on PWM and not HAVE_PWM

2013-02-07T00:00:42+00:00

The correct dependency for the leds-pwm is PWM and not HAVE_PWM
since PWM drivers now have their own subsystem.

Signed-off-by: Peter Ujfalusi 
Signed-off-by: Bryan Wu

leds-lp55xx: fix problem on removing LED attributes

2013-02-06T23:59:30+00:00

 LP55XX common device attributes, 'led_current' and 'max_current' are created
 while loading the driver.
 Those are LED device attributes which are removed automatically on releasing
 led class devices - led_classdev_unregister().
 Therefore, this duplicate code should be removed.

Signed-off-by: Milo(Woogyom) Kim 
Signed-off-by: Bryan Wu

leds-lp5521/5523: add author and copyright description

2013-02-06T23:59:30+00:00

 Now LP5521 and LP5523 drivers are based on new lp55xx structure.
 So the author and copyrights are updated.

Signed-off-by: Milo(Woogyom) Kim 
Signed-off-by: Bryan Wu

leds-lp55xx: clean up headers

2013-02-06T23:59:30+00:00

 Remove unused headers and sort them alphabetically

Signed-off-by: Milo(Woogyom) Kim 
Signed-off-by: Bryan Wu