linux-toradex.git/drivers/leds, branch v4.9.16

leds: triggers: Check return value of kobject_uevent_env()

2016-09-20T08:22:10+00:00

Log error message if kobject_uevent_env() fails in led_trigger_set().

Signed-off-by: Jacek Anaszewski 
Acked-by: Greg Kroah-Hartman

leds: triggers: Return from led_trigger_set() if there is nothing to do

2016-09-20T08:21:17+00:00

If led_trigger_set() is called with "trig" argument set to NULL, and there
is no trigger to remove then the function should return immediately so
as to avoid doing unnecessary allocation and sending uevent.

Signed-off-by: Jacek Anaszewski 
Reported-by: Daniel Romell 
Acked-by Daniel Romell

leds: gpio: fix and simplify error handling in gpio_leds_create

2016-09-15T14:49:43+00:00

Simplify the error handling and add a missing call to fwnode_handle_put
when checking led.name.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: switch to managed version of led_classdev_register

2016-09-15T14:49:42+00:00

Using the managed version of led_classdev_register allows to
significantly simplify the code.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: fix and simplify reading property "label"

2016-09-15T14:49:42+00:00

Checking for the presence of the property first isn't strictly needed
as we can react on the return code of fwnode_property_read_string.
Also, even if the presence of a property "label" was checked,
reading a string value for it theoretically still can fail and
this case isn't handled.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: simplify gpio_leds_create

2016-09-15T14:49:41+00:00

Definition of np can be moved into the loop as well to simplify
the code a little.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: add helper cdev_to_gpio_led_data

2016-09-15T14:49:40+00:00

Add a helper for the container_of as it's used more than once.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: fix an unhandled error case in create_gpio_led

2016-09-15T14:49:40+00:00

gpiod_get_value_cansleep returns 0, 1, or an error code.
So far errors are not handled and treated the same as 1.
Change this to bail out if an error code is returned and
remove the double negation.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: introduce gpio_blink_set_t

2016-09-15T14:49:39+00:00

Introduce a typedef gpio_blink_set_t to improve readability of the code.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: add driver for Mellanox systems LEDs

2016-09-15T14:49:39+00:00

This makes it possible to create a set of LEDs for Mellanox systems:
"msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410",
"msb7800", "msn2740", "msn2100".

Driver obtains LED devices according to system configuration, provided
through system DMI data, like mlxcpld:fan1:green, mlxcpld:fan1:red and
creates devices in form: "devicename:colour:function".

LED setting is controlled through on board CPLD Lattice device.
For setting particular LED off, solid, blink:
echo 0 > /sys/class/leds/mlxcpld\:status\:green/brightness
echo 1 > /sys/class/leds/mlxcpld\:status\:green/brightness
echo timer > /sys/class/leds/mlxcpld\:status\:green/trigger

On module probing all LEDs are set green, on removing - off.

Last setting overwrites previous, f.e. sequence for
changing LED from green - red - green:
echo 1 > /sys/class/leds/mlxcpld\:psu\:green/brightness
echo 1 > /sys/class/leds/mlxcpld\:psu\:red/brightness
echo 1 > /sys/class/leds/mlxcpld\:psu\:green/brightness
Note: LEDs cannot be turned on/off simultaneously.

The Kconfig currently controlling compilation of this code is:
drivers/leds/Kconfig:config LEDS_MLXCPLD

Signed-off-by: Vadim Pasternak 
Reviewed-by: Jiri Pirko 
Reviewed-by: Wei Yongjun 
Signed-off-by: Jacek Anaszewski