linux-toradex.git/drivers/leds, branch v4.9.28

leds: ktd2692: avoid harmless maybe-uninitialized warning

2017-05-14T12:00:15+00:00

commit cbe99c538d1776009e8710755bb6e726f7fffa9b upstream.

gcc gets confused about the control flow in ktd2692_parse_dt(), causing
it to warn about what seems like a potential bug:

drivers/leds/leds-ktd2692.c: In function 'ktd2692_probe':
drivers/leds/leds-ktd2692.c:244:15: error: '*((void *)&led_cfg+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/leds/leds-ktd2692.c:225:7: error: 'led_cfg.flash_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/leds/leds-ktd2692.c:232:3: error: 'led_cfg.movie_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The code is fine, and slightly reworking it in an equivalent way lets
gcc figure that out too, which gets rid of the warning.

Fixes: 77e7915b15bb ("leds: ktd2692: Add missing of_node_put")
Signed-off-by: Arnd Bergmann 
Acked-by: Pavel Machek 
Signed-off-by: Jacek Anaszewski 
Signed-off-by: Greg Kroah-Hartman

leds: triggers: Check return value of kobject_uevent_env()

2016-09-20T08:22:10+00:00

Log error message if kobject_uevent_env() fails in led_trigger_set().

Signed-off-by: Jacek Anaszewski 
Acked-by: Greg Kroah-Hartman

leds: triggers: Return from led_trigger_set() if there is nothing to do

2016-09-20T08:21:17+00:00

If led_trigger_set() is called with "trig" argument set to NULL, and there
is no trigger to remove then the function should return immediately so
as to avoid doing unnecessary allocation and sending uevent.

Signed-off-by: Jacek Anaszewski 
Reported-by: Daniel Romell 
Acked-by Daniel Romell

leds: gpio: fix and simplify error handling in gpio_leds_create

2016-09-15T14:49:43+00:00

Simplify the error handling and add a missing call to fwnode_handle_put
when checking led.name.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: switch to managed version of led_classdev_register

2016-09-15T14:49:42+00:00

Using the managed version of led_classdev_register allows to
significantly simplify the code.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: fix and simplify reading property "label"

2016-09-15T14:49:42+00:00

Checking for the presence of the property first isn't strictly needed
as we can react on the return code of fwnode_property_read_string.
Also, even if the presence of a property "label" was checked,
reading a string value for it theoretically still can fail and
this case isn't handled.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: simplify gpio_leds_create

2016-09-15T14:49:41+00:00

Definition of np can be moved into the loop as well to simplify
the code a little.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: add helper cdev_to_gpio_led_data

2016-09-15T14:49:40+00:00

Add a helper for the container_of as it's used more than once.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: fix an unhandled error case in create_gpio_led

2016-09-15T14:49:40+00:00

gpiod_get_value_cansleep returns 0, 1, or an error code.
So far errors are not handled and treated the same as 1.
Change this to bail out if an error code is returned and
remove the double negation.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski

leds: gpio: introduce gpio_blink_set_t

2016-09-15T14:49:39+00:00

Introduce a typedef gpio_blink_set_t to improve readability of the code.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jacek Anaszewski