linux-toradex.git/drivers/leds, branch v6.10

leds: class: Revert: "If no default trigger is given, make hw_control trigger the default trigger"

2024-06-16T16:33:28+00:00

Commit 66601a29bb23 ("leds: class: If no default trigger is given, make
hw_control trigger the default trigger") causes ledtrig-netdev to get
set as default trigger on various network LEDs.

This causes users to hit a pre-existing AB-BA deadlock issue in
ledtrig-netdev between the LED-trigger locks and the rtnl mutex,
resulting in hung tasks in kernels >= 6.9.

Solving the deadlock is non trivial, so for now revert the change to
set the hw_control trigger as default trigger, so that ledtrig-netdev
no longer gets activated automatically for various network LEDs.

The netdev trigger is not needed because the network LEDs are usually under
hw-control and the netdev trigger tries to leave things that way so setting
it as the active trigger for the LED class device is a no-op.

Fixes: 66601a29bb23 ("leds: class: If no default trigger is given, make hw_control trigger the default trigger")
Reported-by: Genes Lists 
Closes: https://lore.kernel.org/all/9d189ec329cfe68ed68699f314e191a10d4b5eda.camel@sapience.com/
Reported-by: Johannes Wüller 
Closes: https://lore.kernel.org/lkml/e441605c-eaf2-4c2d-872b-d8e541f4cf60@gmail.com/
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede 
Reviewed-by: Andrew Lunn 
Acked-by: Lee Jones 
Signed-off-by: Linus Torvalds

leds: mt6370: Remove unused field 'reg_cfgs' from 'struct mt6370_priv'

2024-05-02T17:12:27+00:00

In 'struct mt6370_priv', the 'reg_cfgs' field is unused. Moreover
'struct reg_cfg' isn't defined anywhere, so remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET 
Reviewed-by: AngeloGioacchino Del Regno 
Link: https://lore.kernel.org/r/e389be5e1012dc05fc2641123883ca3b0747525a.1714328839.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Lee Jones

leds: lp50xx: Remove unused field 'num_of_banked_leds' from 'struct lp50xx'

2024-05-02T17:10:56+00:00

In 'struct lp50xx', the 'num_of_banked_leds' field is only written and
is never used. Moreover, storing such an information in the 'priv'
structure looks pointless, so remove it.

Signed-off-by: Christophe JAILLET 
Link: https://lore.kernel.org/r/a0d472ff587d13a2b91ec32c8776061019caab6a.1714324500.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Lee Jones

leds: lp50xx: Remove unused field 'bank_modules' from 'struct lp50xx_led'

2024-05-02T17:10:28+00:00

In 'struct lp50xx_led', the 'bank_modules' field is unused. Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET 
Link: https://lore.kernel.org/r/bc2e5e57b93ca0a33bcc84e9bdc89f26fc8f6d57.1714324500.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Lee Jones

leds: aat1290: Remove unused field 'torch_brightness' from 'struct aat1290_led'

2024-05-02T17:09:04+00:00

In 'struct aat1290_led', the 'torch_brightness' field is unused. Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET 
Link: https://lore.kernel.org/r/f7c8c22242544b11e95d9a77d7d0ea17f5a24fd5.1714318454.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Lee Jones

leds: sun50i-a100: Use match_string() helper to simplify the code

2024-05-02T17:06:30+00:00

match_string() returns the array index of a matching string.
Use it instead of the open-coded implementation.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Jernej Skrabec 
Link: https://lore.kernel.org/r/20240426152515.872917-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones

leds: pwm: Disable PWM when going to suspend

2024-05-02T17:02:01+00:00

On stm32mp1xx based machines (and others) a PWM consumer has to disable
the PWM because an enabled PWM refuses to suspend. So check the
LED_SUSPENDED flag and depending on that set the .enabled property.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=218559
Fixes: 76fe464c8e64 ("leds: pwm: Don't disable the PWM when the LED should be off")
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20240417153846.271751-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones

leds: trigger: pattern: Add support for hrtimer

2024-05-02T16:32:01+00:00

Currently, led pattern trigger uses timer_list to schedule brightness
changing. As we know from timer_list API [1], it's not accurate to
milliseconds and depends on HZ granularity.

Example:
"0 10 0 0 50 10 50 0 100 10 100 0 150 10 150 0 200 10 200 0 250 10 250 0",
we expect it to be 60ms long, but it can actually be up to ~120ms
(add ~10ms for each pattern when HZ == 100).

But sometimes, userspace needs time accurate led patterns to make sure
that pattern will be executed during expected time slot.
To achieve this goal the patch introduces optional hrtimer usage for
led trigger pattern, because hrtimer is microseconds accurate timer.

[1]: kernel/time/timer.c#L104

Signed-off-by: Martin Kurbanov 
Link: https://lore.kernel.org/r/20240416201847.357099-1-mmkurbanov@salutedevices.com
Signed-off-by: Lee Jones

leds: mt6360: Fix the second LED can not enable torch mode by V4L2

2024-04-12T08:47:17+00:00

V4L2 will disable strobe mode of the LED device when enable torch mode,
but this logic will conflict with the "priv->fled_torch_used"
in "mt6360_strobe_set()". So after enabling torch mode of the first
LED, the second LED will not be able to enable torch mode correctly.

Therefore, at the beginning of "mt6360_strobe_set()", check whether the
state of the upcoming change and the current LED device state are the
same, so as to avoid the above problem.

Signed-off-by: ChiaEn Wu 
Link: https://lore.kernel.org/r/28FE6F1712799128000.chiaen_wu@richtek.com
Signed-off-by: Lee Jones

leds: qcom-lpg: Add support for PMI8950 PWM

2024-04-12T08:47:15+00:00

The PMI8950 PMIC contains 1 PWM channel

Signed-off-by: Gianluca Boiano 
Reviewed-by: Konrad Dybcio 
Link: https://lore.kernel.org/r/20240402-pmi8950-pwm-support-v1-1-1a66899eeeb3@gmail.com
Signed-off-by: Lee Jones