linux-toradex.git/drivers/lightnvm/core.c, branch v4.15-rc2

Revert "lightnvm: prevent bd removal if busy"

2017-10-13T15:36:06+00:00

Christoph correctly points out that this issue is no different
for other block devices, and poking at cross layer internals
is not the right way to solve it.

This reverts commit bb6aa6f08268bbce4e0185b18cab9e04505d6695.

Signed-off-by: Jens Axboe

lightnvm: implement generic path for sync I/O

2017-10-13T14:34:57+00:00

Implement a generic path for sending sync I/O on LightNVM. This allows
to reuse the standard synchronous path trough blk_execute_rq(), instead
of implementing a wait_for_completion on the target side (e.g., pblk).

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: remove stale extern and unused exported symbols

2017-10-13T14:34:57+00:00

Not all exported symbols are being used outside core and there were
some stale entries in lightnvm.h

Signed-off-by: Rakesh Pandit 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: remove unused argument from nvm_set_tgt_bb_tbl

2017-10-13T14:34:57+00:00

vblk isn't being used anyway and if we ever have a usecase we can
introduce this again.  This makes the logic easier and removes
unnecessary checks.

Signed-off-by: Rakesh Pandit 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: remove already calculated nr_chnls

2017-10-13T14:34:57+00:00

Remove repeated calculation for number of channels while creating a
target device.

Signed-off-by: Rakesh Pandit 
Reviewed-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: protect target type list with correct locks

2017-10-13T14:34:57+00:00

nvm_tgt_types list was protected by wrong lock for NVM_INFO ioctl call
and can race with addition or removal of target types.  Also
unregistering target type was not protected correctly.

Fixes: 5cd907853 ("lightnvm: remove nested lock conflict with mm")
Signed-off-by: Rakesh Pandit 
Reviewed-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: prevent bd removal if busy

2017-10-13T14:34:57+00:00

When a virtual block device is formatted and mounted after creating
with "nvme lnvm create... -t pblk", a removal from "nvm lnvm remove"
would result in this:

446416.309757] bdi-block not registered
[446416.309773] ------------[ cut here ]------------
[446416.309780] WARNING: CPU: 3 PID: 4319 at fs/fs-writeback.c:2159
  __mark_inode_dirty+0x268/0x340

Ideally removal should return -EBUSY as block device is mounted after
formatting.  This patch tries to address this checking if whole device
or any partition of it already mounted or not before removal.

Whole device is checked using "bd_super" member of block device.  This
member is always set once block device has been mounted using a
filesystem.  Another member "bd_part_count" takes care of checking any
if any partitions are under use.  "bd_part_count" is only updated
under locks when partitions are opened or closed (first open and last
release).  This at least does take care sending -EBUSY if removal is
being attempted while whole block device or any partition is mounted.

Signed-off-by: Rakesh Pandit 
Reviewed-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: prevent target type module removal when in use

2017-10-13T14:34:57+00:00

If target type module e.g. pblk here is unloaded (rmmod) while module
is in use (after creating target) system crashes.  We fix this by
using module API refcnt.

Signed-off-by: Rakesh Pandit 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: if LUNs are already allocated fix return

2017-06-27T14:22:09+00:00

While creating new device with NVM_DEV_CREATE if LUNs are already
allocated ioctl would return -ENOMEM which is wrong.  This patch
propagates -EBUSY from nvm_reserve_luns which is correct response.

Fixes: ade69e243 ("lightnvm: merge gennvm with core")
Reviewed-by: Frans Klaver 
Signed-off-by: Rakesh Pandit 
Signed-off-by: Jens Axboe

lightnvm: re-convert ppa format on I/O failure

2017-06-26T22:24:53+00:00

In case of a failure when submitting a request, convert the ppa_list
addresses to the target format so that it can interpret ppas for
recovery

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe