linux-toradex.git/drivers/lightnvm/pblk-core.c, branch v5.0

lightnvm: pblk: support packed metadata

2018-12-11T19:22:35+00:00

pblk performs recovery of open lines by storing the LBA in the per LBA
metadata field. Recovery therefore only works for drives that has this
field.

This patch adds support for packed metadata, which store l2p mapping
for open lines in last sector of every write unit and enables drives
without per IO metadata to recover open lines.

After this patch, drives with OOB size <16B will use packed metadata
and metadata size larger than16B will continue to use the device per
IO metadata.

Reviewed-by: Javier González 
Signed-off-by: Igor Konopko 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: dynamic DMA pool entry size

2018-12-11T19:22:35+00:00

Currently lightnvm and pblk uses single DMA pool, for which the entry
size always is equal to PAGE_SIZE. The contents of each entry allocated
from the DMA pool consists of a PPA list (8bytes * 64), leaving
56bytes * 64 space for metadata. Since the metadata field can be bigger,
such as 128 bytes, the static size does not cover this use-case.

This patch adds support for I/O metadata above 56 bytes by changing DMA
pool size based on device meta size and allows pblk to use OOB metadata
>=16B.

Reviewed-by: Javier González 
Signed-off-by: Igor Konopko 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: add helpers for OOB metadata

2018-12-11T19:22:35+00:00

pblk currently assumes that size of OOB metadata on drive is always
equal to size of pblk_sec_meta struct. This commit add helpers which will
allow to handle different sizes of OOB metadata on drive in the future.

After this patch only OOB metadata equal to 16 bytes is supported.

Reviewed-by: Javier González 
Signed-off-by: Igor Konopko 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: add comments wrt locking in recovery path

2018-12-11T19:22:34+00:00

pblk's recovery path is single threaded and therefore a number of
assumptions regarding concurrency can be made. To avoid confusion, make
this explicit with a couple of comments in the code.

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: add lock protection to list operations

2018-12-11T19:22:34+00:00

Protect the list_add on the pblk_line_init_bb() error
path in case this code is used for some other purpose
in the future.

Signed-off-by: Hua Su 
Reviewed-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: fix chunk close trace event check

2018-12-11T19:22:33+00:00

The check for chunk closes suffers from an off-by-one issue, leading
to chunk close events not being traced.

Fixes: 4c44abf43d00 ("lightnvm: pblk: add trace events for chunk states")
Signed-off-by: Hans Holmberg 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: fix race on sysfs line state

2018-10-09T14:25:08+00:00

pblk exposes a sysfs interface that represents its internal state. Part
of this state is the map bitmap for the current open line, which should
be protected by the line lock to avoid a race when freeing the line
metadata. Currently, it is not.

This patch makes sure that the line state is consistent and NULL
bitmap pointers are not dereferenced.

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: add SPDX license tag

2018-10-09T14:25:08+00:00

Add GLP-2.0 SPDX license tag to all pblk files

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: take write semaphore on metadata

2018-10-09T14:25:08+00:00

pblk guarantees write ordering at a chunk level through a per open chunk
semaphore. At this point, since we only have an open I/O stream for both
user and GC data, the semaphore is per parallel unit.

For the metadata I/O that is synchronous, the semaphore is not needed as
ordering is guaranteed. However, if the metadata scheme changes or
multiple streams are open, this guarantee might not be preserved.

This patch makes sure that all writes go through the semaphore, even for
synchronous I/O. This is consistent with pblk's write I/O model. It also
simplifies maintenance since changes in the metadata scheme could cause
ordering issues.

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: refactor metadata paths

2018-10-09T14:25:07+00:00

pblk maintains two different metadata paths for smeta and emeta, which
store metadata at the start of the line and at the end of the line,
respectively. Until now, these path has been common for writing and
retrieving metadata, however, as these paths diverge, the common code
becomes less clear and unnecessary complicated.

In preparation for further changes to the metadata write path, this
patch separates the write and read paths for smeta and emeta and
removes the synchronous emeta path as it not used anymore (emeta is
scheduled asynchronously to prevent jittering due to internal I/Os).

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe