linux-toradex.git/drivers/mcb/mcb-pci.c, branch v6.7

mcb-pci: Reallocate memory region to avoid memory overlapping

2023-04-20T12:24:01+00:00

mcb-pci requests a fixed-size memory region to parse the chameleon
table, however, if the chameleon table is smaller that the allocated
region, it could overlap with the IP Cores' memory regions.

After parsing the chameleon table, drop/reallocate the memory region
with the actual chameleon table size.

Co-developed-by: Jorge Sanjuan Garcia 
Signed-off-by: Jorge Sanjuan Garcia 
Signed-off-by: Javier Rodriguez 
Signed-off-by: Johannes Thumshirn 
Link: https://lore.kernel.org/r/20230411083329.4506-3-jth@kernel.org
Signed-off-by: Greg Kroah-Hartman

drivers: mcb: use symbol namespaces

2019-11-03T18:54:53+00:00

Now that we have symbol namespaces, use them in MCB to not pollute the
default namespace with MCB internals.

Signed-off-by: Johannes Thumshirn 
Reviewed-by: Jessica Yu 
Reviewed-by: Michael Moese 
Link: https://lore.kernel.org/r/20191016100158.1400-1-jthumshirn@suse.de
Signed-off-by: Greg Kroah-Hartman

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441

2019-06-05T15:37:17+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation version 2 of the license

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 315 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Reviewed-by: Armijn Hemel 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190531190115.503150771@linutronix.de
Signed-off-by: Greg Kroah-Hartman

mcb: add Altera PCI ID to mcb-pci

2018-03-14T18:13:48+00:00

Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead
of the MEN one. Add it to the PCI ID table so the driver automatically
attaches to it.

Signed-off-by: Johannes Thumshirn 
Reported-by: Ben Turner 
Tested-by: Ben Turner 
Cc: Andreas Geißler 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Greg Kroah-Hartman

mcb: Enable PCI bus mastering by default

2016-09-27T10:33:47+00:00

In order to successfully perform DMA operations on PCI devices,
it is necessary to enble PCI bus mastering, so enable it by default.

Signed-off-by: Michael Moese 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Delete num_cells variable which is not required

2016-05-03T22:52:28+00:00

The num_cells variable is only used in the dev_dbg print,
but we can directly use the ret variable which also includes the same
value.

Signed-off-by: Andreas Werner 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Replace ioremap and request_region with the devm version

2016-05-03T22:52:28+00:00

Replaced ioremap with devm_ioremap and request_mem_region with
devm_request_mem_region. This makes the code much more cleaner.

Signed-off-by: Andreas Werner 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Do not return zero on error path in mcb_pci_probe()

2015-10-29T00:02:16+00:00

There is an error path in mcb_pci_probe() where
it returns zero instead of error code.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Fix error handling in mcb_pci_probe()

2015-10-05T04:10:01+00:00

If a MCB PCI Carrier device is IO mapped insted of memory-mapped,
the memory of the PCI device is still not unmapped.

Also the patch adds deallocation of the bus
if chameleon_parse_cells() fails.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: request_mem_region() returns NULL on error

2015-04-03T14:15:30+00:00

The code here is checking for IS_ERR() when request_mem_region() only
returns NULL on error and never an ERR_PTR.

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman