linux-toradex.git/drivers/md/bcache/debug.c, branch v5.1-rc4

bcache: do not check if debug dentry is ERR or NULL explicitly on remove

2018-12-13T15:15:54+00:00

debugfs_remove and debugfs_remove_recursive will check if the dentry
pointer is NULL or ERR, and will do nothing in that case.

Remove the check in cache_set_free and bch_debug_init.

Signed-off-by: Shenghui Wang 
Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: remove useless parameter of bch_debug_init()

2018-10-08T14:19:53+00:00

Parameter "struct kobject *kobj" in bch_debug_init() is useless,
remove it in this patch.

Signed-off-by: Dongbo Cao 
Signed-off-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: replace printk() by pr_*() routines

2018-08-11T21:46:41+00:00

There are still many places in bcache use printk to display kernel
message, which are suggested to be preplaced by pr_*() routines like
pr_err(), pr_info(), or pr_notice().

This patch replaces all printk() with a proper pr_*() routine for
bcache code.

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe

bcache: style fixes for lines over 80 characters

2018-08-11T21:46:41+00:00

This patch fixes the lines over 80 characters into more lines, to minimize
warnings by checkpatch.pl. There are still some lines exceed 80 characters,
but it is better to be a single line and I don't change them.

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe

bcache: style fix to add a blank line after declarations

2018-08-11T21:46:41+00:00

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe

bcache: style fix to replace 'unsigned' by 'unsigned int'

2018-08-11T21:46:41+00:00

This patch fixes warning reported by checkpatch.pl by replacing 'unsigned'
with 'unsigned int'.

Signed-off-by: Coly Li 
Reviewed-by: Shenghui Wang 
Signed-off-by: Jens Axboe

bcache: do not check return value of debugfs_create_dir()

2018-08-09T14:21:01+00:00

Greg KH suggests that normal code should not care about debugfs. Therefore
no matter successful or failed of debugfs_create_dir() execution, it is
unncessary to check its return value.

There are two functions called debugfs_create_dir() and check the return
value, which are bch_debug_init() and closure_debug_init(). This patch
changes these two functions from int to void type, and ignore return values
of debugfs_create_dir().

This patch does not fix exact bug, just makes things work as they should.

Signed-off-by: Coly Li 
Suggested-by: Greg Kroah-Hartman 
Cc: stable@vger.kernel.org
Cc: Kai Krakow 
Cc: Kent Overstreet 
Signed-off-by: Jens Axboe

bcache: don't clone bio in bch_data_verify

2018-07-24T20:43:19+00:00

We immediately overwrite the biovec array, so instead just allocate
a new bio and copy over the disk, setor and size.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Ming Lei 
Acked-by: Coly Li 
Signed-off-by: Jens Axboe

bcache: return 0 from bch_debug_init() if CONFIG_DEBUG_FS=n

2018-05-17T15:43:40+00:00

Commit 539d39eb2708 ("bcache: fix wrong return value in bch_debug_init()")
returns the return value of debugfs_create_dir() to bcache_init(). When
CONFIG_DEBUG_FS=n, bch_debug_init() always returns 1 and makes
bcache_init() failedi.

This patch makes bch_debug_init() always returns 0 if CONFIG_DEBUG_FS=n,
so bcache can continue to work for the kernels which don't have debugfs
enanbled.

Changelog:
v4: Add Acked-by from Kent Overstreet.
v3: Use IS_ENABLED(CONFIG_DEBUG_FS) to replace #ifdef DEBUG_FS.
v2: Remove a warning information
v1: Initial version.

Fixes: Commit 539d39eb2708 ("bcache: fix wrong return value in bch_debug_init()")
Cc: stable@vger.kernel.org
Signed-off-by: Coly Li 
Reported-by: Massimo B. 
Reported-by: Kai Krakow 
Tested-by: Kai Krakow 
Acked-by: Kent Overstreet 
Signed-off-by: Jens Axboe

bcache: store disk name in struct cache and struct cached_dev

2018-05-03T14:35:08+00:00

Current code uses bdevname() or bio_devname() to reference gendisk
disk name when bcache needs to display the disk names in kernel message.
It was safe before bcache device failure handling patch set merged in,
because when devices are failed, there was deadlock to prevent bcache
printing error messages with gendisk disk name. But after the failure
handling patch set merged, the deadlock is fixed, so it is possible
that the gendisk structure bdev->hd_disk is released when bdevname() is
called to reference bdev->bd_disk->disk_name[]. This is why I receive
bug report of NULL pointers deference panic.

This patch stores gendisk disk name in a buffer inside struct cache and
struct cached_dev, then print out the offline device name won't reference
bdev->hd_disk anymore. And this patch also avoids extra function calls
of bdevname() and bio_devnmae().

Changelog:
v3, add Reviewed-by from Hannes.
v2, call bdevname() earlier in register_bdev()
v1, first version with segguestion from Junhui Tang.

Fixes: c7b7bd07404c5 ("bcache: add io_disable to struct cached_dev")
Fixes: 5138ac6748e38 ("bcache: fix misleading error message in bch_count_io_errors()")
Signed-off-by: Coly Li 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Jens Axboe