linux-toradex.git/drivers/md/dm-raid1.c, branch v3.11

block: Use bio_sectors() more consistently

2013-03-23T21:15:30+00:00

Bunch of places in the code weren't using it where they could be -
this'll reduce the size of the patch that puts bi_sector/bi_size/bi_idx
into a struct bvec_iter.

Signed-off-by: Kent Overstreet 
CC: Jens Axboe 
CC: "Ed L. Cashin" 
CC: Nick Piggin 
CC: Jiri Kosina 
CC: Jim Paris 
CC: Geoff Levand 
CC: Alasdair Kergon 
CC: dm-devel@redhat.com
CC: Neil Brown 
CC: Steven Rostedt 
Acked-by: Ed Cashin

dm kcopyd: introduce configurable throttling

2013-03-01T22:45:49+00:00

This patch allows the administrator to reduce the rate at which kcopyd
issues I/O.

Each module that uses kcopyd acquires a throttle parameter that can be
set in /sys/module/*/parameters.

We maintain a history of kcopyd usage by each module in the variables
io_period and total_period in struct dm_kcopyd_throttle. The actual
kcopyd activity is calculated as a percentage of time equal to
"(100 * io_period / total_period)".  This is compared with the user-defined
throttle percentage threshold and if it is exceeded, we sleep.

Signed-off-by: Mikulas Patocka 
Signed-off-by: Alasdair G Kergon

dm: rename request variables to bios

2013-03-01T22:45:47+00:00

Use 'bio' in the name of variables and functions that deal with
bios rather than 'request' to avoid confusion with the normal
block layer use of 'request'.

No functional changes.

Signed-off-by: Alasdair G Kergon

dm: fix truncated status strings

2013-03-01T22:45:44+00:00

Avoid returning a truncated table or status string instead of setting
the DM_BUFFER_FULL_FLAG when the last target of a table fills the
buffer.

When processing a table or status request, the function retrieve_status
calls ti->type->status. If ti->type->status returns non-zero,
retrieve_status assumes that the buffer overflowed and sets
DM_BUFFER_FULL_FLAG.

However, targets don't return non-zero values from their status method
on overflow. Most targets returns always zero.

If a buffer overflow happens in a target that is not the last in the
table, it gets noticed during the next iteration of the loop in
retrieve_status; but if a buffer overflow happens in the last target, it
goes unnoticed and erroneously truncated data is returned.

In the current code, the targets behave in the following way:
* dm-crypt returns -ENOMEM if there is not enough space to store the
  key, but it returns 0 on all other overflows.
* dm-thin returns errors from the status method if a disk error happened.
  This is incorrect because retrieve_status doesn't check the error
  code, it assumes that all non-zero values mean buffer overflow.
* all the other targets always return 0.

This patch changes the ti->type->status function to return void (because
most targets don't use the return code). Overflow is detected in
retrieve_status: if the status method fills up the remaining space
completely, it is assumed that buffer overflow happened.

Cc: stable@vger.kernel.org
Signed-off-by: Mikulas Patocka 
Signed-off-by: Alasdair G Kergon

dm: remove map_info

2012-12-21T20:23:41+00:00

This patch removes map_info from bio-based device mapper targets.
map_info is still used for request-based targets.

Signed-off-by: Mikulas Patocka 
Signed-off-by: Alasdair G Kergon

dm raid1: dont use map_context

2012-12-21T20:23:40+00:00

Don't use map_info any more in dm-raid1.

map_info was used for writes to hold the region number. For this purpose
we add a new field dm_bio_details to dm_raid1_bio_record.

map_info was used for reads to hold a pointer to dm_raid1_bio_record (if
the pointer was non-NULL, bio details were saved; if the pointer was
NULL, bio details were not saved). We use
dm_raid1_bio_record.details->bi_bdev for this purpose. If bi_bdev is
NULL, details were not saved, if bi_bdev is non-NULL, details were
saved.

Signed-off-by: Mikulas Patocka 
Signed-off-by: Alasdair G Kergon

dm raid1: rename read_record to bio_record

2012-12-21T20:23:39+00:00

Rename struct read_record to bio_record in dm-raid1.

In the following patch, the structure will be used for both read and
write bios, so rename it.

Signed-off-by: Mikulas Patocka 
Signed-off-by: Alasdair G Kergon

dm raid1: use per_bio_data

2012-12-21T20:23:38+00:00

Replace read_record_pool with per_bio_data in dm-raid1.

Signed-off-by: Mikulas Patocka 
Signed-off-by: Alasdair G Kergon

dm raid: use DM_ENDIO_INCOMPLETE

2012-12-21T20:23:32+00:00

Use a defined macro DM_ENDIO_INCOMPLETE instead of a numeric constant.

Signed-off-by: Mikulas Patocka 
Signed-off-by: Alasdair G Kergon

dm raid1: remove impossible mempool_alloc error test

2012-12-21T20:23:32+00:00

mempool_alloc can't fail if __GFP_WAIT is specified, so the condition
that tests if read_record is non-NULL is always true.

Signed-off-by: Mikulas Patocka 
Signed-off-by: Alasdair G Kergon