linux-toradex.git/drivers/md/md-cluster.c, branch v4.4.136 Linux kernel for Apalis and Colibri modules md-cluster: fix potential lock issue in add_new_disk 2018-04-13T17:50:09+00:00 Guoqing Jiang gqjiang@suse.com 2017-05-16T06:01:25+00:00 0850cb7b028b6b57ca72843ff7d4ad6d7858c068 [ Upstream commit 2dffdc0724004f38f5e39907747b53e4b0d80e59 ] The add_new_disk returns with communication locked if __sendmsg returns failure, fix it with call unlock_comm before return. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> CC: Goldwyn Rodrigues <rgoldwyn@suse.com> Signed-off-by: Guoqing Jiang <gqjiang@suse.com> Signed-off-by: Shaohua Li <shli@fb.com> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
[ Upstream commit 2dffdc0724004f38f5e39907747b53e4b0d80e59 ]

The add_new_disk returns with communication locked if
__sendmsg returns failure, fix it with call unlock_comm
before return.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
CC: Goldwyn Rodrigues <rgoldwyn@suse.com>
Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
md-cluster: free md_cluster_info if node leave cluster 2017-12-20T09:04:52+00:00 Guoqing Jiang gqjiang@suse.com 2017-02-24T03:15:12+00:00 0d0456ec2b089457233f4a33c9939dfeff11fbbd [ Upstream commit 9c8043f337f14d1743006dfc59c03e80a42e3884 ] To avoid memory leak, we need to free the cinfo which is allocated when node join cluster. Reviewed-by: NeilBrown <neilb@suse.com> Signed-off-by: Guoqing Jiang <gqjiang@suse.com> Signed-off-by: Shaohua Li <shli@fb.com> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
[ Upstream commit 9c8043f337f14d1743006dfc59c03e80a42e3884 ]

To avoid memory leak, we need to free the cinfo which
is allocated when node join cluster.

Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
md-cluster: remove mddev arg from add_resync_info() 2015-10-24T06:16:18+00:00 NeilBrown neilb@suse.com 2015-10-19T04:44:00+00:00 30661b49be784e8eecde60330ad7a8bdeb5291b1 The arg isn't used, so its presence is only confusing. Signed-off-by: NeilBrown <neilb@suse.com> 
The arg isn't used, so its presence is only confusing.

Signed-off-by: NeilBrown <neilb@suse.com>
md-cluster: don't cast void pointers when assigning them. 2015-10-24T06:16:18+00:00 NeilBrown neilb@suse.com 2015-10-19T04:42:18+00:00 2e2a7cd96f5a076db4d4a4bd564652d37dd034c2 It is common practice in the kernel to leave out this case. It isn't needed and adds little if any value. Signed-off-by: NeilBrown <neilb@suse.com> 
It is common practice in the kernel to leave out this case.
It isn't needed and adds little if any value.

Signed-off-by: NeilBrown <neilb@suse.com>
md-cluster: discard unused sb_mutex. 2015-10-24T06:16:18+00:00 NeilBrown neilb@suse.com 2015-10-19T04:36:07+00:00 823815238f5e2bfd3783602ca9c50da9fe41c778 Signed-off-by: NeilBrown <neilb@suse.com> 
Signed-off-by: NeilBrown <neilb@suse.com>
md-cluster: Fix warnings when build with CF=-D__CHECK_ENDIAN__ 2015-10-24T06:16:18+00:00 Guoqing Jiang gqjiang@suse.com 2015-10-16T07:40:22+00:00 cf97a348c8f700e448588bad4de3504d8d65c2f9 This patches fixes sparse warnings like incorrect type in assignment (different base types), cast to restricted __le64. Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Guoqing Jiang <gqjiang@suse.com> Signed-off-by: NeilBrown <neilb@suse.com> 
This patches fixes sparse warnings like incorrect type in assignment
(different base types), cast to restricted __le64.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: NeilBrown <neilb@suse.com>
md-cluster: metadata_update_finish: consistently use cmsg.raid_slot as le32 2015-10-16T02:48:35+00:00 NeilBrown neilb@suse.com 2015-10-16T02:48:35+00:00 ba2746b0facf83c62bebf8aed8f0a3fd446de612 As cmsg.raid_slot is le32, comparing for >0 is not meaningful. So introduce cpu-endian 'raid_slot' and only assign to cmsg.raid_slot when we know value is valid. Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: NeilBrown <neilb@suse.com> 
As cmsg.raid_slot is le32, comparing for >0 is not meaningful.

So introduce cpu-endian 'raid_slot' and only assign to cmsg.raid_slot
when we know value is valid.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: NeilBrown <neilb@suse.com>
md-cluster: Add 'SUSE' as author for md-cluster.c 2015-10-12T16:58:15+00:00 Guoqing Jiang gqjiang@suse.com 2015-10-12T09:21:25+00:00 86b572770e7964f006d438c4e05008914e9db79b Signed-off-by: Guoqing Jiang <gqjiang@suse.com> 
Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
md-cluster: zero cmsg before it was sent 2015-10-12T16:58:15+00:00 Guoqing Jiang gqjiang@suse.com 2015-10-12T09:21:24+00:00 aee177ac5a4225ac4eeed0aa5edf2338c2d713a4 Signed-off-by: Guoqing Jiang <gqjiang@suse.com> 
Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
md-cluster: make sure the node do not receive it's own msg 2015-10-12T16:58:14+00:00 Guoqing Jiang gqjiang@suse.com 2015-10-12T09:21:23+00:00 256f5b245aab93bfa2d8b86d66545fceea05408e During the past test, the node occasionally received the msg which is sent from itself, this case should not happen in theory, but it is better to avoid it in case something wrong happened. Signed-off-by: Guoqing Jiang <gqjiang@suse.com> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com> 
During the past test, the node occasionally received the msg which is
sent from itself, this case should not happen in theory, but it is
better to avoid it in case something wrong happened.

Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>