linux-toradex.git/drivers/md/md.c, branch v5.16

md: fix double free of mddev->private in autorun_array()

2021-12-10T17:11:07+00:00

In driver/md/md.c, if the function autorun_array() is called,
the problem of double free may occur.

In function autorun_array(), when the function do_md_run() returns an
error, the function do_md_stop() will be called.

The function do_md_run() called function md_run(), but in function
md_run(), the pointer mddev->private may be freed.

The function do_md_stop() called the function __md_stop(), but in
function __md_stop(), the pointer mddev->private also will be freed
without judging null.

At this time, the pointer mddev->private will be double free, so it
needs to be judged null or not.

Signed-off-by: zhangyue 
Signed-off-by: Song Liu

md: fix update super 1.0 on rdev size change

2021-12-10T17:11:07+00:00

The superblock of version 1.0 doesn't get moved to the new position on a
device size change. This leads to a rdev without a superblock on a known
position, the raid can't be re-assembled.

The line was removed by mistake and is re-added by this patch.

Fixes: d9c0fa509eaf ("md: fix max sectors calculation for super 1.0")
Cc: stable@vger.kernel.org
Signed-off-by: Markus Hochholdinger 
Reviewed-by: Xiao Ni 
Signed-off-by: Song Liu

Merge tag 'for-5.16/bdev-size-2021-10-29' of git://git.kernel.dk/linux-block

2021-11-01T16:50:37+00:00

Pull bdev size cleanups from Jens Axboe:
 "Clean up the bdev size handling with new bdev_nr_bytes() helper"

* tag 'for-5.16/bdev-size-2021-10-29' of git://git.kernel.dk/linux-block: (34 commits)
  partitions/ibm: use bdev_nr_sectors instead of open coding it
  partitions/efi: use bdev_nr_bytes instead of open coding it
  block/ioctl: use bdev_nr_sectors and bdev_nr_bytes
  block: cache inode size in bdev
  udf: use sb_bdev_nr_blocks
  reiserfs: use sb_bdev_nr_blocks
  ntfs: use sb_bdev_nr_blocks
  jfs: use sb_bdev_nr_blocks
  ext4: use sb_bdev_nr_blocks
  block: add a sb_bdev_nr_blocks helper
  block: use bdev_nr_bytes instead of open coding it in blkdev_fallocate
  squashfs: use bdev_nr_bytes instead of open coding it
  reiserfs: use bdev_nr_bytes instead of open coding it
  pstore/blk: use bdev_nr_bytes instead of open coding it
  ntfs3: use bdev_nr_bytes instead of open coding it
  nilfs2: use bdev_nr_bytes instead of open coding it
  nfs/blocklayout: use bdev_nr_bytes instead of open coding it
  jfs: use bdev_nr_bytes instead of open coding it
  hfsplus: use bdev_nr_sectors instead of open coding it
  hfs: use bdev_nr_sectors instead of open coding it
  ...

md: update superblock after changing rdev flags in state_store

2021-10-18T20:50:35+00:00

When the in memory flag is changed, we need to persist the change in the
rdev superblock flags. This is needed for "writemostly" and "failfast".

Reviewed-by: Li Feng 
Signed-off-by: Xiao Ni 
Signed-off-by: Song Liu 
Signed-off-by: Jens Axboe

md: remove unused argument from md_new_event

2021-10-18T20:50:33+00:00

Actually, mddev is not used by md_new_event.

Signed-off-by: Guoqing Jiang 
Signed-off-by: Song Liu 
Signed-off-by: Jens Axboe

md: properly unwind when failing to add the kobject in md_alloc

2021-10-18T20:50:23+00:00

Add proper error handling to delete the gendisk when failing to add
the md kobject and clean up the error unwinding in general.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Song Liu 
Signed-off-by: Jens Axboe

md: extend disks_mutex coverage

2021-10-18T20:50:21+00:00

disks_mutex is intended to serialize md_alloc.  Extended it to also cover
the kobject_uevent call and getting the sysfs dirent to help reducing
error handling complexity.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Song Liu 
Signed-off-by: Jens Axboe

md: add the bitmap group to the default groups for the md kobject

2021-10-18T20:50:19+00:00

Replace the deprecated default_attrs with the default_groups mechanism,
and add the always visible bitmap group to the groups created add
kobject_add time.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Song Liu 
Signed-off-by: Jens Axboe

md: add error handling support for add_disk()

2021-10-18T20:50:10+00:00

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

We just do the unwinding of what was not done before, and are
sure to unlock prior to bailing.

Signed-off-by: Luis Chamberlain 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Song Liu 
Signed-off-by: Jens Axboe

md: use bdev_nr_sectors instead of open coding it

2021-10-18T20:43:22+00:00

Use the proper helper to read the block device size.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Kees Cook 
Acked-by: Song Liu 
Link: https://lore.kernel.org/r/20211018101130.1838532-7-hch@lst.de
Signed-off-by: Jens Axboe