linux-toradex.git/drivers/md, branch v2.6.34-rc1

Driver core: Constify struct sysfs_ops in struct kobj_type

2010-03-08T01:04:49+00:00

Constify struct sysfs_ops.

This is part of the ops structure constification
effort started by Arjan van de Ven et al.

Benefits of this constification:

 * prevents modification of data that is shared
   (referenced) by many other structure instances
   at runtime

 * detects/prevents accidental (but not intentional)
   modification attempts on archs that enforce
   read-only kernel data at runtime

 * potentially better optimized code as the compiler
   can assume that the const data cannot be changed

 * the compiler/linker move const data into .rodata
   and therefore exclude them from false sharing

Signed-off-by: Emese Revfy 
Acked-by: David Teigland 
Acked-by: Matt Domsch 
Acked-by: Maciej Sosnowski 
Acked-by: Hans J. Koch 
Acked-by: Pekka Enberg 
Acked-by: Jens Axboe 
Acked-by: Stephen Hemminger 
Signed-off-by: Greg Kroah-Hartman

dm raid1: fix deadlock when suspending failed device

2010-03-06T02:32:35+00:00

To prevent deadlock, bios in the hold list should be flushed before
dm_rh_stop_recovery() is called in mirror_suspend().

The recovery can't start because there are pending bios and therefore
dm_rh_stop_recovery deadlocks.

When there are pending bios in the hold list, the recovery waits for
the completion of the bios after recovery_count is acquired.
The recovery_count is released when the recovery finished, however,
the bios in the hold list are processed after dm_rh_stop_recovery() in
mirror_presuspend(). dm_rh_stop_recovery() also acquires recovery_count,
then deadlock occurs.

Signed-off-by: Takahiro Yasui 
Signed-off-by: Alasdair G Kergon 
Reviewed-by: Mikulas Patocka

dm: eliminate some holes data structures

2010-03-06T02:32:33+00:00

Eliminate a 4-byte hole in 'struct dm_io_memory' by moving 'offset' above the
'ptr' to which it applies (size reduced from 24 to 16 bytes).  And by
association, 1-4 byte hole is eliminated in 'struct dm_io_request' (size
reduced from 56 to 48 bytes).

Eliminate all 6 4-byte holes and 1 cache-line in 'struct dm_snapshot' (size
reduced from 392 to 368 bytes).

Signed-off-by: Mike Snitzer 
Signed-off-by: Alasdair G Kergon

dm ioctl: introduce flag indicating uevent was generated

2010-03-06T02:32:31+00:00

Set a new DM_UEVENT_GENERATED_FLAG when returning from ioctls to
indicate that a uevent was actually generated.  This tells the userspace
caller that it may need to wait for the event to be processed.

Signed-off-by: Peter Rajnoha 
Signed-off-by: Alasdair G Kergon

dm: free dm_io before bio_endio not after

2010-03-06T02:32:29+00:00

Free the dm_io structure before calling bio_endio() instead of after it,
to ensure that the io_pool containing it is not referenced after it is
freed.

This partially fixes a problem described here
  https://www.redhat.com/archives/dm-devel/2010-February/msg00109.html

thread 1:
bio_endio(bio, io_error);
/* scheduling happens */
					thread 2:
					close the device
					remove the device
thread 1:
free_io(md, io);

Thread 2, when removing the device, sees non-empty md->io_pool (because the
io hasn't been freed by thread 1 yet) and may crash with BUG in mempool_free.
Thread 1 may also crash, when freeing into a nonexisting mempool.

To fix this we must make sure that bio_endio() is the last call and
the md structure is not accessed afterwards.

There is another bio_endio in process_barrier, but it is called from the thread
and the thread is destroyed prior to freeing the mempools, so this call is
not affected by the bug.

A similar bug exists with module unloads - the module may be unloaded
immediately after bio_endio - but that is more difficult to fix.

Signed-off-by: Mikulas Patocka 
Cc: stable@kernel.org
Signed-off-by: Alasdair G Kergon

dm table: remove unused dm_get_device range parameters

2010-03-06T02:32:27+00:00

Remove unused parameters(start and len) of dm_get_device()
and fix the callers.

Signed-off-by: Nikanth Karthikesan 
Signed-off-by: Alasdair G Kergon

dm ioctl: only issue uevent on resume if state changed

2010-03-06T02:32:24+00:00

Only issue a uevent on a resume if the state of the device changed,
i.e. if it was suspended and/or its table was replaced.

Signed-off-by: Dave Wysochanski 
Signed-off-by: Mike Snitzer 
Cc: stable@kernel.org
Signed-off-by: Alasdair G Kergon

dm raid1: always return error if all legs fail

2010-03-06T02:32:22+00:00

If all mirror legs fail, always return an error instead of holding the
bio, even if the handle_errors option was set.  At present it is the
responsibility of the driver underneath us to deal with retries,
multipath etc.

The patch adds the bio to the failures list instead of holding it
directly.  do_failures tests first if all legs failed and, if so,
returns the bio with -EIO.  If any leg is still alive and handle_errors
is set, do_failures calls hold_bio.

Reviewed-by: Takahiro Yasui 
Signed-off-by: Mikulas Patocka 
Signed-off-by: Alasdair G Kergon

dm mpath: refactor pg_init

2010-03-06T02:32:18+00:00

This patch pulls the pg_init path activation code out of
process_queued_ios() into a new function.

No functional change.

Signed-off-by: Kiyoshi Ueda 
Signed-off-by: Jun'ichi Nomura 
Signed-off-by: Alasdair G Kergon

dm mpath: wait for pg_init completion when suspending

2010-03-06T02:32:13+00:00

When suspending the device we must wait for all I/O to complete, but
pg-init may be still in progress even after flushing the workqueue
for kmpath_handlerd in multipath_postsuspend.

This patch waits for pg-init completion correctly in
multipath_postsuspend().

Signed-off-by: Kiyoshi Ueda 
Signed-off-by: Jun'ichi Nomura 
Signed-off-by: Alasdair G Kergon