linux-toradex.git/drivers/media/IR/ir-nec-decoder.c, branch v2.6.35-rc5

V4L/DVB: ir-core: change duration to be coded as a u32 integer

2010-05-19T15:57:42+00:00

This patch implements the agreed upon 1:31 integer encoded pulse/duration
struct for ir-core raw decoders. All decoders have been tested after the
change. Comments are welcome.

Signed-off-by: David Härdeman 
Signed-off-by: Mauro Carvalho Chehab

V4L/DVB: Add NECx support to ir-core

2010-05-19T15:57:16+00:00

This patch adds NECx support to drivers/media/IR/ir-nec-decoder.c

Signed-off-by: David Härdeman 
Signed-off-by: Mauro Carvalho Chehab

V4L/DVB: ir-core: move subsystem internal calls to ir-core-priv.h

2010-05-19T15:57:04+00:00

ir-core.h has the kABI to be used by the bridge drivers, when needing to register
IR protocols and pass IR events. However, the same file also contains IR subsystem
internal calls, meant to be used inside ir-core and between ir-core and the raw
decoders.

Better to move those functions to an internal header, for some reasons:

1) Header will be a little more cleaner;

2) It avoids the need of recompile everything (bridge/hardware drivers, etc),
   just because a new decoder were added, or some other internal change were needed;

3) Better organize the ir-core API, splitting the functions that are internal to
   IR core and the ancillary drivers (decoders, lirc_dev) from the features that
   should be exported to IR subsystem clients.

Signed-off-by: Mauro Carvalho Chehab

V4L/DVB: Teach drivers/media/IR/ir-raw-event.c to use durations

2010-05-19T15:57:03+00:00

drivers/media/IR/ir-raw-event.c is currently written with the assumption
that all "raw" hardware will generate events only on state change (i.e.
when a pulse or space starts).

However, some hardware (like mceusb, probably the most popular IR receiver
out there) only generates duration data (and that data is buffered so using
any kind of timing on the data is futile).

Furthermore, using signed int's to represent pulse/space durations is a
well-known approach when writing ir decoders.

With this patch:

- s64 int's are used to represent pulse/space durations in ns

- a workqueue is used to decode the ir protocols outside of interrupt context

- #defines are added to make decoders clearer

- decoder reset is implemented by passing a zero duration to the kfifo queue
  and decoders are updated accordingly

Signed-off-by: David Härdeman 
Signed-off-by: Mauro Carvalho Chehab

V4L/DVB: ir: Make sure that the spinlocks are properly initialized

2010-05-19T15:57:01+00:00

Some spinlocks are not properly initialized on ir core:

[  471.714132] BUG: spinlock bad magic on CPU#0, modprobe/1899
[  471.719838]  lock: f92a08ac, .magic: 00000000, .owner: /-1, .owner_cpu: 0
[  471.727301] Pid: 1899, comm: modprobe Not tainted 2.6.33 #36
[  471.733062] Call Trace:
[  471.735537]  [] ? printk+0x1d/0x22
[  471.739866]  [] spin_bug+0xa3/0xf0
[  471.744224]  [] do_raw_spin_lock+0x7d/0x160
[  471.749364]  [] ? ir_rc5_register+0x6f/0xf0 [ir_rc5_decoder]

So, use static initialization for the static spinlocks, instead of the
dynamic ones (currently used), as proposed by David Härdeman on one
of his RFC patches.

Signed-off-by: Mauro Carvalho Chehab

V4L/DVB: re-add enable/disable check to the IR decoders

2010-05-19T15:56:59+00:00

A previous cleanup patch removed more than needed. Re-add the logic that
disable the decoders.

Signed-off-by: Mauro Carvalho Chehab

V4L-DVB: ir-core: remove the ancillary buffer

2010-05-19T15:56:57+00:00

Now that the decoders are state machine, there's no need to create
an ancillary buffer while decoding the protocol. Just call the decoders
code directly, event by event.

Signed-off-by: Mauro Carvalho Chehab

V4L/DVB: ir-nec-decoder: Cleanups

2010-05-19T15:56:56+00:00

Remove dead code and properly name a few constants

Signed-off-by: Mauro Carvalho Chehab

V4L/DVB: ir-nec-decoder: Reimplement the entire decoder

2010-05-19T15:56:55+00:00

Thanks to Andy Walls  for pointing me his
code, that gave me some ideas to better implement it.

After some work with saa7134 bits, I found a way to catch both IRQ
edge pulses. By enabling it, the NEC decoder can now take both
pulse and spaces into account, making it more precise.

Instead of the old strategy of handling the events all at once,
this code implements a state machine. Due to that, it handles
individual pulse or space events, validating them against the
protocol, producing a much more reliable decoding.

With the new implementation, the protocol trailer bits are properly
handled, making possible for the repeat key to work.

Also, the code is now capable of handling both NEC and NEC extended
IR devices. With NEC, it produces a 16 bits code, while with NEC
extended, a 24 bits code is returned.

Signed-off-by: Mauro Carvalho Chehab

V4L/DVB: ir-core: improve keyup/keydown logic

2010-05-19T15:56:54+00:00

Rewrites the keyup/keydown logic in drivers/media/IR/ir-keytable.c.

All knowledge of keystates etc is now internal to ir-keytable.c
and not scattered around ir-raw-event.c and ir-nec-decoder.c (where
it doesn't belong).

In addition, I've changed the API slightly so that ir_input_dev is
passed as the first argument rather than input_dev. If we're ever
going to support multiple keytables we need to move towards making
ir_input_dev the main interface from a driver POV and obscure away
the input_dev as an implementational detail in ir-core.

Signed-off-by: David Härdeman 
Signed-off-by: Mauro Carvalho Chehab