linux-toradex.git/drivers/media/dvb-core/dmxdev.c, branch v4.4.28

[media] dvb: get rid of enum dmx_success

2015-10-06T22:53:02+00:00

This enum is not actually used anymore. The only value used from
the enum is DMX_OK, passed as a parameter on two callbacks.

Yet, this value is not used anywhere. So, just remove it.

Signed-off-by: Mauro Carvalho Chehab

[media] dvb: don't keep support for undocumented features

2015-10-06T21:49:37+00:00

There are two DVB demux callbacks and ioctls that aren't documented
and aren't used at all by the DVB core or by any DVB driver upstream.

Let's comment out the code for those two ioctls and remove on some
future version.

Signed-off-by: Mauro Carvalho Chehab

[media] dvb core: rename the media controller entities

2015-02-26T11:44:19+00:00

Prefix all DVB media controller entities with "dvb-" and use dash
instead of underline at the names.

Requested-by: Hans Verkuil 

Acked-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] dmxdev: add support for demux/dvr nodes at media controller

2015-02-13T23:10:13+00:00

Make the dvb core demux support aware of the media controller and
register the corresponding devices.

Signed-off-by: Mauro Carvalho Chehab

[media] dmxdev: don't use before checking file->private_data

2014-09-03T17:38:06+00:00

As reported by smatch:
	drivers/media/dvb-core/dmxdev.c:1091 dvb_demux_poll() warn: variable dereferenced before check 'dmxdevfilter' (see line 1088)

This was introduced by changeset d102cac8097c.

We need to test before using it.

Signed-off-by: Mauro Carvalho Chehab

[media] media: check status of dmxdev->exit in poll functions of demux&dvr

2014-09-02T14:50:42+00:00

when usb-type tuner is pulled out, user applications did not close device's FD,
and go on polling the device, we should return POLLERR directly.

Signed-off-by: Changbing Xiong 
Signed-off-by: Mauro Carvalho Chehab

[media] media: correct return value in dvb_demux_poll

2014-09-02T14:49:00+00:00

Data type of return value is unsigned int, but in function of dvb_demux_poll,
when the pointer of dmxdevfilter equals NULL, it will return -EINVAL, which
is invalid.

Signed-off-by: Changbing Xiong 
Signed-off-by: Mauro Carvalho Chehab

dmxdev: get rid of pointless clearing ->f_op

2013-10-25T03:34:53+00:00

nobody else will see that struct file after return from ->release()
anyway; just leave ->f_op as is and let __fput() do that fops_put().

Signed-off-by: Al Viro

[media] media: dmxdev: remove dvb_ringbuffer_flush() on writer side

2013-06-19T14:48:09+00:00

In dvb_ringbuffer lock-less synchronizationof reader and writer threads is done
with separateread and write pointers. Sincedvb_ringbuffer_flush() modifies the
read pointer, this function must not be called from the writer thread.
This patch removes the dvb_ringbuffer_flush() calls in the dmxdev ringbuffer
write functions, this fixes Oopses "Unable to handle kernel paging request"
I could observe for the call chaindvb_demux_read ->dvb_dmxdev_buffer_read ->
dvb_ringbuffer_read_user -> __copy_to_user (the reader side of the ringbuffer).
The flush calls at the write side are not necessary anyway since ringbuffer_flush
is also called in dvb_dmxdev_buffer_read() when an error condition is set in the
ringbuffer.
This patch should also be applied to stable kernels.

Signed-off-by: Soeren Moch 
CC: 
Reviewed-by: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab

[media] demux.h: Remove duplicated enum

2013-04-08T09:53:15+00:00

"enum dmx_ts_pes" and "typedef enum dmx_pes_type_t" are just the
same enum declared twice, since Kernel (2.6.12). There's no reason
to duplicate it there, and sparse complains about that:
	drivers/media/dvb-core/dmxdev.c:600:55: warning: mixing different enum types
So, remove the internal define, keeping just the external one.
Internally, use only "enum dmx_ts_pes", as it is too late to drop
dmx_pes_type_t from the userspace API.

Signed-off-by: Mauro Carvalho Chehab