linux-toradex.git/drivers/media/dvb-frontends/si2168.c, branch v4.4.156

media: [RESEND] media: dvb-frontends: Add delay to Si2168 restart

2018-03-24T09:58:47+00:00

[ Upstream commit 380a6c86457573aa42d27ae11e025eb25941a0b7 ]

On faster CPUs a delay is required after the resume command and the restart command. Without the delay, the restart command often returns -EREMOTEIO and the Si2168 does not restart.

Note that this patch fixes the same issue as https://patchwork.linuxtv.org/patch/44304/, but I believe my udelay() fix addresses the actual problem.

Signed-off-by: Ron Economos 
Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

[media] si2168: Bounds check firmware

2015-10-22T17:48:25+00:00

When reading the firmware and sending commands, the length must
be bounds checked to avoid overrunning the size of the command
buffer and smashing the stack if the firmware is not in the expected
format:

si2168 11-0064: found a 'Silicon Labs Si2168-B40'
si2168 11-0064: downloading firmware from file 'dvb-demod-si2168-b40-01.fw'
si2168 11-0064: firmware download failed -95
Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: ffffffffa085708f

Add the proper check.

Cc: stable@kernel.org
Reported-by: Stuart Auchterlonie 
Reviewed-by: Antti Palosaari 
Signed-off-by: Laura Abbott 
Signed-off-by: Mauro Carvalho Chehab

[media] dvb-frontends: Drop owner assignment from i2c_driver

2015-08-11T15:58:20+00:00

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Mauro Carvalho Chehab

[media] dvb: Get rid of typedev usage for enums

2015-06-09T20:47:35+00:00

The DVB API was originally defined using typedefs. This is against
Kernel CodingStyle, and there's no good usage here. While we can't
remove its usage on userspace, we can avoid its usage in Kernelspace.

So, let's do it.

This patch was generated by this shell script:

	for j in $(grep typedef include/uapi/linux/dvb/frontend.h |cut -d' ' -f 3); do for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f); do sed "s,${j}_t,enum $j," <$i >a && mv a $i; done; done

While here, make CodingStyle fixes on the affected lines.

Signed-off-by: Mauro Carvalho Chehab 
Acked-by: Stefan Richter  # for drivers/media/firewire/*

[media] si2168: Implement own I2C adapter locking

2015-06-05T09:32:05+00:00

We need own I2C locking because of tuner I2C adapter/repeater.
Firmware command is executed using I2C send + reply message. Default
I2C adapter locking protects only single I2C operation, not whole
send + reply sequence as needed. Due to that, it was possible tuner
I2C message interrupts firmware command sequence.

Reported-by: Adam Baker 
Signed-off-by: Antti Palosaari 
Reviewed-by: Adam Baker 
Signed-off-by: Mauro Carvalho Chehab

[media] si2168: add I2C error handling

2015-05-12T16:19:26+00:00

Return error from si2168_cmd_execute in case the demodulator returns an
error.

Signed-off-by: Olli Salonen 
Signed-off-by: Antti Palosaari 
Signed-off-by: Mauro Carvalho Chehab

[media] si2168: add support for gapped clock

2015-05-12T16:16:37+00:00

Add a parameter in si2168_config to support gapped clock. This might be
necessary on some devices with higher bitrates.

Signed-off-by: Olli Salonen 
Signed-off-by: Antti Palosaari 
Signed-off-by: Mauro Carvalho Chehab

[media] si2168: add support for 1.7MHz bandwidth

2015-02-03T20:13:12+00:00

This patch is based on Antti's silabs branch.

Add support for 1.7 MHz bandwidth. Supported in all versions of Si2168 according to short data sheets.

[mchehab@osg.samsung.com: Fix CodingStyle]
Signed-off-by: Olli Salonen 
Reviewed-by: Antti Palosaari 

Signed-off-by: Mauro Carvalho Chehab

[media] si2168: return error if set_frontend is called with invalid parameters

2015-02-03T20:12:46+00:00

This patch should is based on Antti's silabs branch.

According to dvb-frontend.h set_frontend may be called with bandwidth_hz set to 0 if automatic bandwidth is required. Si2168 does not support automatic bandwidth and does not declare FE_CAN_BANDWIDTH_AUTO in caps.

This patch will change the behaviour in a way that EINVAL is returned if bandwidth_hz is 0.

Signed-off-by: Olli Salonen 
Reviewed-by: Antti Palosaari 
Signed-off-by: Mauro Carvalho Chehab

[media] si2168: change firmware variable name and type

2015-01-29T20:46:05+00:00

Rename firmware variable from fw_file to fw_name and change its type
from u8 to const char as request_firmware() input defines.

Signed-off-by: Antti Palosaari 
Signed-off-by: Mauro Carvalho Chehab