linux-toradex.git/drivers/media/media-entity.c, branch v4.8-rc2

[media] media: change pipeline validation return error

2016-04-29T11:07:17+00:00

According to the V4L2 API, the VIDIOC_STREAMON ioctl should return EPIPE
if there is a format mismatch in the pipeline configuration.

As the .vidioc_streamon in the v4l2_ioctl_ops usually forwards the error
caused by the v4l2_subdev_link_validate_default (if it is in use), it
should return -EPIPE when it detect the mismatch.

When an entity is connected to a non enabled link,
media_entity_pipeline_start should return -ENOLINK, as the link does not
exist.

Signed-off-by: Helen Mae Koike Fornazier 
Acked-by: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab

[media] media-device: get rid of the spinlock

2016-04-20T16:12:02+00:00

Right now, the lock schema for media_device struct is messy,
since sometimes, it is protected via a spin lock, while, for
media graph traversal, it is protected by a mutex.

Solve this conflict by always using a mutex.

As a side effect, this prevents a bug when the media notifiers
is called at atomic context, while running the notifier callback:

 BUG: sleeping function called from invalid context at mm/slub.c:1289
 in_atomic(): 1, irqs_disabled(): 0, pid: 3479, name: modprobe
 4 locks held by modprobe/3479:
 #0:  (&dev->mutex){......}, at: [] __driver_attach+0xa3/0x160
 #1:  (&dev->mutex){......}, at: [] __driver_attach+0xb1/0x160
 #2:  (register_mutex#5){+.+.+.}, at: [] usb_audio_probe+0x257/0x1c90 [snd_usb_audio]
 #3:  (&(&mdev->lock)->rlock){+.+.+.}, at: [] media_device_register_entity+0x1cb/0x700 [media]
 CPU: 2 PID: 3479 Comm: modprobe Not tainted 4.5.0-rc3+ #49
 Hardware name:                  /NUC5i7RYB, BIOS RYBDWi35.86A.0350.2015.0812.1722 08/12/2015
 0000000000000000 ffff8803b3f6f288 ffffffff81933901 ffff8803c4bae000
 ffff8803c4bae5c8 ffff8803b3f6f2b0 ffffffff811c6af5 ffff8803c4bae000
 ffffffff8285d7f6 0000000000000509 ffff8803b3f6f2f0 ffffffff811c6ce5
 Call Trace:
 [] dump_stack+0x85/0xc4
 [] ___might_sleep+0x245/0x3a0
 [] __might_sleep+0x95/0x1a0
 [] kmem_cache_alloc_trace+0x20e/0x300
 [] ? media_add_link+0x4d/0x140 [media]
 [] media_add_link+0x4d/0x140 [media]
 [] media_create_pad_link+0xa1/0x600 [media]
 [] au0828_media_graph_notify+0x173/0x360 [au0828]
 [] ? media_gobj_create+0x1ba/0x480 [media]
 [] media_device_register_entity+0x3ab/0x700 [media]

Reviewed-by: Javier Martinez Canillas 
Acked-by: Sakari Ailus 
Acked-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] media: add prefixes to interface types

2016-03-05T12:03:16+00:00

Add missing prefixes for DVB, V4L, and ALSA interface types.

Signed-off-by: Shuah Khan 
Acked-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] media: Media Controller non-locking __media_entity_pipeline_start/stop()

2016-02-27T11:33:28+00:00

Add non-locking __media_entity_pipeline_start/stop()
interfaces to be called from code paths that hold the
graph_mutex.

Signed-off-by: Shuah Khan 
Signed-off-by: Mauro Carvalho Chehab

[media] media: Media Controller export non locking __media_entity_setup_link()

2016-02-27T11:33:27+00:00

Export __media_entity_setup_link() to be used from code paths
that hold the graph_mutex.

Signed-off-by: Shuah Khan 
Signed-off-by: Mauro Carvalho Chehab

[media] uapi/media.h: Declare interface types for ALSA

2016-02-27T11:14:44+00:00

Declare the interface types to be used on alsa for
the new G_TOPOLOGY ioctl.

Signed-off-by: Shuah Khan 
Acked-by: Takashi Iwai 
Signed-off-by: Mauro Carvalho Chehab

[media] media: Use all bits of an enumeration

2016-02-19T13:45:03+00:00

The allocation takes place in longs. Assign the size of the enum
accordingly.

Signed-off-by: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab

[media] media: Media Controller fix to not let stream_count go negative

2016-02-01T15:32:50+00:00

Change media_entity_pipeline_stop() to not decrement
stream_count of an inactive media pipeline. Doing so,
results in preventing starting the pipeline.

Signed-off-by: Shuah Khan 
Signed-off-by: Mauro Carvalho Chehab

[media] media-entitiy: add a function to create multiple links

2016-01-11T14:19:26+00:00

Sometimes, it is desired to create 1:n and n:1 or even
n:n links between different entities with the same
function.

This is actually needed to support DVB devices that
have multiple frontends. While we could do a function
like that internally at the DVB core, such function is
generic enough to be at media-entity, and it could be
useful on some other places.

So, add such function.

Signed-off-by: Mauro Carvalho Chehab

[media] media-entity: increase max number of PADs

2016-01-11T14:19:24+00:00

The DVB drivers may have 257 PADs. Get the next power of two
that would accomodate that amount.

Signed-off-by: Mauro Carvalho Chehab