linux-toradex.git/drivers/media/platform/omap3isp/isp.c, branch v5.13-rc3

media: omap3isp: Acquire graph mutex for graph traversal

2021-04-06T12:34:20+00:00

Acquire the graph_mutex for traversing the media graph. This seems to have
been missing all the time.

Signed-off-by: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab

media: v4l2-async: Improve v4l2_async_notifier_add_*_subdev() API

2021-02-06T08:18:53+00:00

The functions that add an async subdev to an async subdev notifier take
as an argument the size of the container structure they need to
allocate. This is error prone, as passing an invalid size will not be
caught by the compiler. Wrap those functions in macros that take a
container type instead of a size, and cast the returned pointer to the
desired type. The compiler will catch mistakes if the incorrect type is
passed to the macro, as the assignment types won't match.

Signed-off-by: Laurent Pinchart 
Reviewed-by: Niklas Söderlund 
Reviewed-by: Jacopo Mondi 
Signed-off-by: Ezequiel Garcia 
Signed-off-by: Sakari Ailus 
Reviewed-by: Helen Koike 
Reviewed-by: Tomi Valkeinen  (core+ti-cal)
Signed-off-by: Mauro Carvalho Chehab

media: v4l2-async: Clean v4l2_async_notifier_add_fwnode_remote_subdev

2021-02-06T07:40:36+00:00

Change v4l2_async_notifier_add_fwnode_remote_subdev semantics
so it allocates the struct v4l2_async_subdev pointer.

This makes the API consistent: the v4l2-async subdevice addition
functions have now a unified usage model. This model is simpler,
as it makes v4l2-async responsible for the allocation and release
of the subdevice descriptor, and no longer something the driver
has to worry about.

On the user side, the change makes the API simpler for the drivers
to use and less error-prone.

Signed-off-by: Ezequiel Garcia 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Sakari Ailus 
Reviewed-by: Helen Koike 
Signed-off-by: Mauro Carvalho Chehab

media: omap3isp: Fix memleak in isp_probe

2020-09-10T12:09:25+00:00

When devm_ioremap_resource() fails, isp should be
freed just like other error paths in isp_probe.

Fixes: 8644cdf972dd6 ("[media] omap3isp: Replace many MMIO regions by two")
Signed-off-by: Dinghao Liu 
Signed-off-by: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab

media: omap: Replace HTTP links with HTTPS ones

2020-09-01T12:13:27+00:00

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
  If not .svg:
    For each line:
      If doesn't contain `\bxmlns\b`:
	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
            If both the HTTP and HTTPS versions
            return 200 OK and serve the same content:
              Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab

media: omap3isp: remove cacheflush.h

2020-06-26T07:27:37+00:00

After mm.h was removed from the asm-generic version of cacheflush.h,
s390 allyesconfig shows several warnings of the following nature:

  In file included from arch/s390/include/generated/asm/cacheflush.h:1,
                   from drivers/media/platform/omap3isp/isp.c:42:
  include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' declared inside parameter list will not be visible outside of this definition or declaration

As Geert and Laurent point out, this driver does not need this header in
the two files that include it.  Remove it so there are no warnings.

Link: http://lkml.kernel.org/r/20200622234740.72825-2-natechancellor@gmail.com
Fixes: e0cf615d725c ("asm-generic: don't include  in cacheflush.h")
Signed-off-by: Nathan Chancellor 
Suggested-by: Geert Uytterhoeven 
Suggested-by: Laurent Pinchart 
Reviewed-by: Laurent Pinchart 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Mauro Carvalho Chehab 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

media: omap3isp: Ignore failure of stopping streaming on external subdev

2020-01-03T15:35:01+00:00

The isp was marked to have failed to stop if stopping streaming on an
external subdev failed. The return value from the external subdev should
be ignored instead as it is not part of the ISP and thus the ISP does not
need to be reset for that reason.

Signed-off-by: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab

media: omap3isp: Don't set streaming state on random subdevs

2019-08-15T11:07:04+00:00

The streaming state should be set to the first upstream sub-device only,
not everywhere, for a sub-device driver itself knows how to best control
the streaming state of its own upstream sub-devices.

Signed-off-by: Sakari Ailus 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Mauro Carvalho Chehab

media: Remove dev_err() usage after platform_get_irq()

2019-08-07T20:08:33+00:00

We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// 
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// 

While we're here, remove braces on if statements that only have one
statement (manually).

Cc: Greg Kroah-Hartman 
Signed-off-by: Stephen Boyd 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: omap3isp: Rework OF endpoint parsing

2019-07-25T14:59:49+00:00

Rework OF endpoint parsing for the omap3isp driver. This does add some
lines of code. The benefits are still clear:

- the great complication related to callbacks in endpoint parsing is gone;
  instead endpoints are obtained port by port and

- endpoints may now have a default bus configuration which was not
  possible while using callbacks. This driver does not benefit from that
  feature, but as the omap3isp is one of the exemplary drivers, this works
  as an example for driver developers.

Signed-off-by: Sakari Ailus 
Tested-by: Niklas Söderlund 
Signed-off-by: Mauro Carvalho Chehab