linux-toradex.git/drivers/media/platform/soc_camera/mx2_camera.c, branch v4.3.3

[media] v4l2: replace s_mbus_fmt by set_fmt in bridge drivers

2015-05-01T12:01:16+00:00

Replace all calls to s_mbus_fmt in bridge drivers by calls to the
set_fmt pad op.

Remove the old try/s_mbus_fmt video ops since they are now no longer used.

Signed-off-by: Hans Verkuil 
Cc: Guennadi Liakhovetski 
Acked-by: Prabhakar Lad 
Acked-by: Scott Jiang 
Cc: Jonathan Corbet 
Signed-off-by: Mauro Carvalho Chehab

[media] v4l2: replace try_mbus_fmt by set_fmt in bridge drivers

2015-05-01T11:59:28+00:00

Replace all calls to try_mbus_fmt in bridge drivers by calls to the
set_fmt pad op.

[mchehab@osg.samsung.com: fix a merge conflict at mcam-core.c]
Signed-off-by: Hans Verkuil 
Cc: Guennadi Liakhovetski 
Acked-by: Scott Jiang 
Cc: Jonathan Corbet 

Signed-off-by: Mauro Carvalho Chehab

[media] v4l2: replace video op g_mbus_fmt by pad op get_fmt

2015-05-01T11:36:17+00:00

The g_mbus_fmt video op is a duplicate of the pad op. Replace all uses
by the get_fmt pad op and remove the video op.

Signed-off-by: Hans Verkuil 
Acked-by: Guennadi Liakhovetski 
Acked-by: Prabhakar Lad 
Cc: Kamil Debski 
Signed-off-by: Mauro Carvalho Chehab

[media] v4l2: replace enum_mbus_fmt by enum_mbus_code

2015-05-01T11:33:45+00:00

Replace all calls to the enum_mbus_fmt video op by the pad
enum_mbus_code op and remove the duplicate video op.

Signed-off-by: Hans Verkuil 
Acked-by: Guennadi Liakhovetski 
Acked-by: Scott Jiang 
Cc: Jonathan Corbet 
Cc: Kamil Debski 
Acked-by: Prabhakar Lad 
Signed-off-by: Mauro Carvalho Chehab

[media] soc-camera: fix device capabilities in multiple camera host drivers

2015-01-21T23:05:45+00:00

The V4L2 API requires both .capabilities and .device_caps fields of
struct v4l2_capability to be set. Otherwise the compliance checker
complains and since commit "v4l2-ioctl: WARN_ON if querycap didn't fill
device_caps" a compile-time warning is issued. Fix this non-compliance
in several soc-camera camera host drivers.

Reported-by: Geert Uytterhoeven 
Signed-off-by: Guennadi Liakhovetski 
Tested-by: Geert Uytterhoeven 
Signed-off-by: Mauro Carvalho Chehab

[media] platform: Make use of media_bus_format enum

2014-11-14T19:54:08+00:00

In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.

Reference new definitions in all platform drivers.

Signed-off-by: Boris Brezillon 
Acked-by: Hans Verkuil 
Acked-by: Sakari Ailus 
Acked-by: Sekhar Nori 
Acked-by: Lad, Prabhakar 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] mx2-camera: potential negative underflow bug

2014-09-26T09:47:43+00:00

My static checker complains:

	drivers/media/platform/soc_camera/mx2_camera.c:1070
	mx2_emmaprp_resize() warn: no lower bound on 'num'

The heuristic is that it's looking for values which the user can
influence and we put an upper bound on them but we (perhaps
accidentally) allow negative numbers.

I am not very familiar with this code but I have looked at it and think
there might be a bug.  Making the variable unsigned seems like a safe
option either way and this silences the static checker warning.

The call tree is:
  -> subdev_do_ioctl()
     -> mx2_camera_set_fmt()
        -> mx2_emmaprp_resize()
The check:
	if (num > RESIZE_NUM_MAX)
can underflow and then we use "num" on the else path.

Signed-off-by: Dan Carpenter 
Signed-off-by: Guennadi Liakhovetski 
Signed-off-by: Mauro Carvalho Chehab

[media] mx2_camera: get rid of a warning

2014-08-26T21:52:14+00:00

drivers/media/platform/soc_camera/mx2_camera.c: In function 'mx27_camera_emma_prp_reset':
drivers/media/platform/soc_camera/mx2_camera.c:812:6: warning: variable 'cntl' set but not used [-Wunused-but-set-variable]
  u32 cntl;
      ^

Signed-off-by: Mauro Carvalho Chehab

[media] vb2: stop_streaming should return void

2014-04-23T13:12:51+00:00

The vb2 core ignores any return code from the stop_streaming op.
And there really isn't anything it can do anyway in case of an error.
So change the return type to void and update any drivers that implement it.

The int return gave drivers the idea that this operation could actually
fail, but that's really not the case.

The pwc amd sdr-msi3101 drivers both had this construction:

        if (mutex_lock_interruptible(&s->v4l2_lock))
                return -ERESTARTSYS;

This has been updated to just call mutex_lock(). The stop_streaming op
expects this to really stop streaming and I very much doubt this will
work reliably if stop_streaming just returns without really stopping the
DMA.

Signed-off-by: Hans Verkuil 
Acked-by: Pawel Osciak 
Acked-by: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab

[media] v4l: Rename vb2_queue.timestamp_type as timestamp_flags

2014-03-05T19:34:14+00:00

The timestamp_type field used to contain only the timestamp type. Soon it
will be used for timestamp source flags as well. Rename the field
accordingly.

[m.chehab@samsung.com: do the change also to drivers/staging/media and at s2255]
Signed-off-by: Sakari Ailus 
Acked-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab