linux-toradex.git/drivers/media/platform/vim2m.c, branch v5.3.2

media: vim2m: fix two double-free issues

2019-05-28T16:49:42+00:00

vim2m_device_release() will be called by video_unregister_device() to release
various objects.

There are two double-free issue,
1. dev->m2m_dev will be freed twice in error_m2m path/vim2m_device_release
2. the error_v4l2 and error_free path in vim2m_probe() will release
   same objects, since vim2m_device_release has done.

Fixes: ea6c7e34f3b2 ("media: vim2m: replace devm_kzalloc by kzalloc")

Cc: Laurent Pinchart 
Reported-by: Hulk Robot 
Signed-off-by: Kefeng Wang 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: replace strncpy() by strscpy()

2019-03-29T14:26:13+00:00

The strncpy() function is being deprecated upstream. Replace
it by the safer strscpy().

While here, replace a few occurences of strlcpy() that were
recently added to also use strscpy().

Reviewed-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: vim2m: Fix RGB 565 BE/LE support

2019-03-29T13:46:15+00:00

The support for those two formats are archtecture-dependent.
Use the endianness to CPU macros to do it right.

Signed-off-by: Mauro Carvalho Chehab

media: vim2m: replace devm_kzalloc by kzalloc

2019-03-19T17:23:19+00:00

It is not possible to use devm_kzalloc since that memory is
freed immediately when the device instance is unbound.

Various objects like the video device may still be in use
since someone has the device node open, and when that is closed
it expects the memory to be around.

So use kzalloc and release it at the appropriate time.

Signed-off-by: Hans Verkuil 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Mauro Carvalho Chehab

media: vim2m: Address some coding style issues

2019-03-01T16:51:23+00:00

As we did lots of change at vim2m driver, let's take the
opportunity and make checkpatch happier, addressing the
errors/warnings that makes sense.

While here, increment driver's version.

No functional changes.

Signed-off-by: Mauro Carvalho Chehab

media: vim2m: don't use BUG()

2019-03-01T16:48:56+00:00

There's no reason why this driver should use BUG(). Instead,
just properly handle issue, returning an error code where
pertinent.

Signed-off-by: Mauro Carvalho Chehab

media: vim2m: speedup passthrough copy

2019-03-01T16:31:07+00:00

When in passthrough mode, copy the entire line at once, in
order to make it faster (if not HFLIP).

Signed-off-by: Mauro Carvalho Chehab

media: vim2m: add an horizontal scaler

2019-03-01T16:25:05+00:00

Add an horizontal linear scaler using Breseham algorithm in
order to speep up its calculus.

Signed-off-by: Mauro Carvalho Chehab

media: vim2m: don't accept YUYV anymore as output format

2019-03-01T16:16:48+00:00

Handling any Y,Cr,Cb formats require some extra logic, as it
handles a group of two pixels. That's easy while we don't do
horizontal scaling.

However, doing horizontal scaling with such formats would require
a lot more code, in order to avoid distortions, as, if it scales
to two non-consecutive points, the logic would need to read 4
points in order to properly convert to RGB.

As this is just a test driver, and we want fast algorithms,
let's just get rid of this format as an output one.

Signed-off-by: Mauro Carvalho Chehab

media: vim2m: add vertical linear scaler

2019-03-01T16:16:21+00:00

When resolutions are different, the expected behavior is to
scale the image. Implement a vertical scaler as the first step.

Signed-off-by: Mauro Carvalho Chehab