linux-toradex.git/drivers/media/test-drivers/vimc/vimc-core.c, branch v6.12

media: vimc: Constify the ent_config array

2024-06-26T14:39:34+00:00

The ent_config array contains data that is never modified. Make it
const.

Signed-off-by: Laurent Pinchart 
Signed-off-by: Shuah Khan 
Signed-off-by: Hans Verkuil

media: vimc-core: Convert to platform remove callback returning void

2023-04-11T14:59:21+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Hans Verkuil

media: vimc: Fix wrong function called when vimc_init() fails

2022-11-25T07:26:16+00:00

In vimc_init(), when platform_driver_register(&vimc_pdrv) fails,
platform_driver_unregister(&vimc_pdrv) is wrongly called rather than
platform_device_unregister(&vimc_pdev), which causes kernel warning:

 Unexpected driver unregister!
 WARNING: CPU: 1 PID: 14517 at drivers/base/driver.c:270 driver_unregister+0x8f/0xb0
 RIP: 0010:driver_unregister+0x8f/0xb0
 Call Trace:
  
  vimc_init+0x7d/0x1000 [vimc]
  do_one_initcall+0xd0/0x4e0
  do_init_module+0x1cf/0x6b0
  load_module+0x65c2/0x7820

Fixes: 4a29b7090749 ("[media] vimc: Subdevices as modules")
Signed-off-by: Chen Zhongjin 
Signed-off-by: Shuah Khan 
Signed-off-by: Mauro Carvalho Chehab

media: vimc: wrong pointer is used with PTR_ERR

2022-07-27T18:24:56+00:00

Fix smatch warning:

drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'

Signed-off-by: Hans Verkuil 
Reviewed-by: Kieran Bingham 
Signed-off-by: Mauro Carvalho Chehab

media: vimc: use data link entities enum to index the ent_config array

2022-07-15T13:43:55+00:00

Future additions to the ent_config[] could break the association between
the index of the struct vimc_ent_config entries in the ent_config[] array,
and the index defined by the enum proposed in the previous patch. Using
designated initializers solves this by linking the 2 together clearly in
code and prevents the array not reflecting the enum. There is no
functional change intended.

Suggested-by: Kieran Bingham 
Signed-off-by: Daniel Oakley 
Signed-off-by: Shuah Khan 
Signed-off-by: Mauro Carvalho Chehab

media: vimc: enumerate data link entities for clarity

2022-07-15T13:43:32+00:00

The data_links array was hard to read and understand. By implementing
enumerated vimc data link entities, clarity has been improved when
defining data_links. This therefore should help new programmers to
understand the codebase better. There is no functional change intended.

Suggested-by: Kieran Bingham 
Signed-off-by: Daniel Oakley 
Signed-off-by: Shuah Khan 
Signed-off-by: Mauro Carvalho Chehab

media: vimc: expand the names of vimc entity types

2022-07-15T13:42:14+00:00

When introducing the lens controller, it became apparent that the vimc
entity type names were hard to understand, e.g. vimc_len_type refers to the
lens. The names of the vimc entity types have been expanded to make the
code easier to understand. There is no functional change intended.

Suggested-by: Kieran Bingham 
Signed-off-by: Daniel Oakley 
Signed-off-by: Shuah Khan 
Signed-off-by: Mauro Carvalho Chehab

media: vimc: add ancillary lens

2022-07-15T13:40:09+00:00

Add lens to vimc driver and link them with sensors using ancillary links.
Provides an example of ancillary link usage.The lens supports
FOCUS_ABSOLUTE control.

Test example: With default vimc topology
> media-ctl -p
Media controller API version 5.18.0
...
- entity 28: Lens A (0 pad, 0 link)
             type V4L2 subdev subtype Lens flags 0
             device node name /dev/v4l-subdev6
- entity 29: Lens B (0 pad, 0 link)
             type V4L2 subdev subtype Lens flags 0
             device node name /dev/v4l-subdev7
> v4l2-ctl -d /dev/v4l-subdev7 -C focus_absolute
focus_absolute: 0

Reviewed-by: Kieran Bingham 
Signed-off-by: Yunke Cao 
Signed-off-by: Shuah Khan 
Signed-off-by: Mauro Carvalho Chehab

media: vimc: Add support for contiguous DMA buffers

2022-02-16T11:47:02+00:00

The vimc driver is used for testing purpose, and some test use cases
involve sharing buffers with a consumer device. Consumers often require
DMA contiguous memory, which vimc doesn't currently support. This leads
in the best case to usage of bounce buffers, which is very slow, and in
the worst case in a complete failure.

Add support for the dma-contig allocator in vimc to support those use
cases properly. The allocator is selected through a new "allocator"
module parameter, which defaults to vmalloc.

[hverkuil: add missing 'select VIDEOBUF2_DMA_CONFIG' to Kconfig]

Signed-off-by: Laurent Pinchart 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: vimc: Add a control to display info on test image

2020-07-19T11:39:22+00:00

Add a control in VIMC to display information such as the correct order of
colors for a given test pattern, counter, brightness, hue, saturation,
contrast, width and height at sensor over test image.

Signed-off-by: Kaaira Gupta 
Acked-by: Helen Koike 
Reviewed-by: Kieran Bingham 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab