linux-toradex.git/drivers/media/usb/pvrusb2, branch v5.13

media: pvrusb2: use semicolons rather than commas to separate statements

2020-11-16T09:31:06+00:00

Replace commas with semicolons.  Commas introduce unnecessary
variability in the code structure and are hard to see.  What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):

// 
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: pvrusb2: fix parsing error

2020-08-26T16:50:11+00:00

pvr2_std_str_to_id() returns 0 on failure and 1 on success,
however the caller is checking failure case using <0

Acked-by: Mike Isely 
Co-developed-by: Hans Verkuil 
Signed-off-by: Hans Verkuil 
Signed-off-by: Tong Zhang 
Signed-off-by: Mauro Carvalho Chehab

media: usb: pvrusb2: convert to use i2c_new_client_device()

2020-04-14T09:32:04+00:00

Move away from the deprecated API.

Signed-off-by: Wolfram Sang 
Acked-by: Mike Isely 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

Revert "media: Kconfig: better support hybrid TV devices"

2020-04-14T09:00:30+00:00

Changing from "depends on" to "select" may cause some
side-effects. This patch is not ready to be merged yet,
as it requires some adjustments.

So, let's revert it.

This reverts commit a3b91d8bd1e034c8ed89d3f55243478af97a0a52.

Signed-off-by: Mauro Carvalho Chehab

media: Kconfig: better support hybrid TV devices

2020-04-14T08:29:05+00:00

Right now, if one has an hybrid TV card, it has to select
both analog and digital TV support, as otherwise the needed
core support won't be selected.

Change the logic to auto-select the core support for those
drivers, as this is a way more intuitive.

It should be noticed that, as now both DVB_CORE and VIDEO_DEV
defaults depends on selecting a hybrid cards, we had to remove
the explicit dependencies there, in order to avoid circular
dependencies.

That requires some tricks:

1) the prompt should not be not visible when an hybrid card
   is selected, as the user shold not change it.

2) When a media hybrid device is selected, the modular
   option for DVB_CORE and VIDEO_DEV will follow the
   MEDIA_SUPPORT dependency, as we can't have a core
   built with "y" with a driver built as module.

Note: while here, moved two pure V4L2 PCI drivers out of the
"hybrid" part of config and consider pvrusb2 as an hybrid
device.

Signed-off-by: Mauro Carvalho Chehab

media: media/usb: rename VFL_TYPE_GRABBER to _VIDEO

2020-02-24T15:53:16+00:00

'GRABBER' is a weird name, all other types map to the /dev
device names. Rename to 'VIDEO' to be consistent with the
other types.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: pvrusb2: Remove unneeded semicolon and add newline

2020-01-08T13:36:32+00:00

Fixes coccicheck warning:

drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288:2-3: Unneeded semicolon

Reported-by: Hulk Robot 
Signed-off-by: Ma Feng 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: pvrusb2: Fix oops on tear-down when radio support is not present

2019-11-09T08:10:06+00:00

In some device configurations there's no radio or radio support in the
driver.  That's OK, as the driver sets itself up accordingly.  However
on tear-down in these caes it's still trying to tear down radio
related context when there isn't anything there, leading to
dereferences through a null pointer and chaos follows.

How this bug survived unfixed for 11 years in the pvrusb2 driver is a
mystery to me.

[hverkuil: fix two checkpatch warnings]

Signed-off-by: Mike Isely 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code

2019-08-29T13:22:39+00:00

Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag
will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL.
However, it will be used in the later if statement, which is
potentially unsafe.

Signed-off-by: Yizhuo 
Acked-by: Mike Isely 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: don't do a 31 bit shift on a signed int

2019-08-26T17:11:10+00:00

On 32-bits archs, a signed integer has 31 bits plus on extra
bit for signal. Due to that, touching the 32th bit with something
like:

	int bar = 1 << 31;

has an undefined behavior in C on 32 bit architectures, as it
touches the signal bit. This is warned by cppcheck.

Instead, force the numbers to be unsigned, in order to solve this
issue.

Signed-off-by: Mauro Carvalho Chehab