linux-toradex.git/drivers/media/v4l2-core, branch master

media: v4l2-fwnode: Fix subdev owner overwritten in v4l2_async_register_subdev_sensor()

2026-06-05T07:28:03+00:00

The v4l2 helper v4l2_async_register_subdev_sensor() calls
v4l2_async_register_subdev(), which is a macro that expands to
__v4l2_async_register_subdev(sd,THIS_MODULE). Since the macro is expanded
inside v4l2-fwnode.c, THIS_MODULE resolves to the v4l2-fwnode module
rather than the sensor driver module that originally set sd->owner. When
v4l2-fwnode is built-in, THIS_MODULE evaluates to NULL, which then
overwrites the sensor driver's owner with NULL.

This causes the problem that the sensor module's reference count is never
incremented during async registration, so the module can be removed while
the subdevice is still in use by a notifier (e.g., a CSI-2 receiver
bridge driver).

Fix this by renaming v4l2_async_register_subdev_sensor() to
__v4l2_async_register_subdev_sensor() with an added explicit module
argument and introducing a wrapper macro:
    #define v4l2_async_register_subdev_sensor(sd) \
        __v4l2_async_register_subdev_sensor(sd, THIS_MODULE)

This ensures the sensor driver module is properly referenced even when
the sensor driver does not init the owner field before calling
v4l2_async_register_subdev_sensor() and prevents premature module removal.

Fixes: aef69d54755d ("media: v4l: fwnode: Add a convenience function for registering sensors")
Cc: stable@vger.kernel.org
Suggested-by: Frank Li 
Link: https://lore.kernel.org/linux-media/20240315073125.275501-2-sakari.ailus@linux.intel.com/
Signed-off-by: Mirela Rabulea 
Reviewed-by: Laurent Pinchart 
Reviewed-by: Frank Li 
Signed-off-by: Sakari Ailus

media: v4l2-common: add v4l2_fill_pixfmt_mp_aligned helper

2026-05-21T10:32:19+00:00

Add a v4l2_fill_pixfmt_mp_aligned helper which allows the user to
specify a custom stride alignment in bytes. This is necessary for
hardware like the Rockchip RGA3, which requires the stride value to be
aligned to a 16 bytes boundary.

The code makes some assumptions about the v4l2 format to simplify the
calculation. They currently hold for all known v4l2 formats.

v4l2_format_plane_stride uses an unsigned int as argument type to avoid
the later multiplication from overflowing the u8 value. All other places
use u8, as no practical use cases for a larger alignment are known at
the moment.

Reviewed-by: Nicolas Dufresne 
Signed-off-by: Sven Püschel 
Signed-off-by: Nicolas Dufresne 
Signed-off-by: Hans Verkuil

media: v4l2-common: add has_alpha to v4l2_format_info

2026-05-21T10:32:18+00:00

Add a has_alpha value to the v4l2_format_info struct to indicate if the
format contains an alpha component. This information can currently not
be queried in a generic way, but might be useful for potential drivers
to properly setup alpha blending to copy or set the alpha value.
The implementation is based on the drm_format_info implementation.

Reviewed-by: Nicolas Dufresne 
Signed-off-by: Sven Püschel 
Signed-off-by: Nicolas Dufresne 
Signed-off-by: Hans Verkuil

media: v4l2-common: add missing 1 and 2 byte RGB formats to v4l2_format_info

2026-05-21T10:32:18+00:00

Add all missing one and two byte RGB formats to v4l2_format_info. This
allows drivers to more consistently use v4l2_format_info, as it now
covers all currently defined RGB formats.

Reviewed-by: Nicolas Dufresne 
Signed-off-by: Sven Püschel 
Signed-off-by: Nicolas Dufresne 
Signed-off-by: Hans Verkuil

media: v4l2-common: sort RGB formats in v4l2_format_info

2026-05-21T10:32:18+00:00

Sort the RGB formats in v4l2_format_info to match the format definitions
in include/uapi/linux/videodev2.h . Also introduce the same sections to
partition the list of formats and align the format info in each section.

The alignment of the 1 or 2 bytes RGB formats contains an additional
space in preparation of adding the missing formats to the list, as for
V4L2_PIX_FMT_ARGB555X an additional space is necessary.

Reviewed-by: Nicolas Dufresne 
Signed-off-by: Sven Püschel 
Signed-off-by: Nicolas Dufresne 
Signed-off-by: Hans Verkuil

media: Use named initializers for arrays of i2c_device_data

2026-05-20T07:03:40+00:00

While being less compact, using named initializers allows to more easily
see which members of the structs are assigned which value without having
to lookup the declaration of the struct. And it's also more robust
against changes to the struct definition.

The mentioned robustness is relevant for a planned change to struct
i2c_device_id that replaces .driver_data by an anonymous union.

While touching all these arrays, unify usage of whitespace and commas.

This patch doesn't modify the compiled arrays, only their representation
in source form benefits. The former was confirmed with x86 and arm64
builds.

Signed-off-by: Uwe Kleine-König (The Capable Hub) 
Signed-off-by: Hans Verkuil

media: v4l2-dev: Add range check for vdev->minor

2026-05-12T07:39:02+00:00

If the fixed minor ranges are not properly set we could end up in a
situation where the calculated minor is invalid. Add a check for this in
the code to make it more robust.

This check also fixes the following false positive smatch warning:

drivers/media/v4l2-core/v4l2-dev.c:1036 __video_register_device() error: buffer overflow 'video_devices' 256 <= 288
drivers/media/v4l2-core/v4l2-dev.c:1043 __video_register_device() error: buffer overflow 'video_devices' 256 <= 288
drivers/media/v4l2-core/v4l2-dev.c:1101 __video_register_device() error: buffer overflow 'video_devices' 256 <= 288

Reviewed-by: Sakari Ailus 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Ricardo Ribalda 
Signed-off-by: Hans Verkuil

media: v4l2-subdev: Allow accessing routes with STREAMS client capability

2026-05-07T10:23:50+00:00

Disable access to routes when the STREAMS client capability bit isn't set.
Routes aren't relevant otherwise anyway.

Signed-off-by: Sakari Ailus 
Reviewed-by: Jacopo Mondi 
Reviewed-by: Mirela Rabulea 
Reviewed-by: Michael Riesch 
Reviewed-by: Laurent Pinchart

media: v4l2-subdev: Refactor returning routes

2026-05-07T10:23:49+00:00

Refactor returning the routes by adding a new function that essentially
does a memcopy and sets the number of the routes in the routing table.

Signed-off-by: Sakari Ailus 
Reviewed-by: Michael Riesch 
Reviewed-by: Laurent Pinchart

media: v4l2-common: Always register clock with device-specific name

2026-05-06T07:17:37+00:00

If we need to register a dummy fixed-frequency clock, always register it
using a device-specific name.

This supports the use case where a system has two of the same sensor,
meaning two instances of the same driver, which previously both tried
(and failed) to create a clock with the same name.

Signed-off-by: Paul Cercueil 
Reviewed-by: Mehdi Djait 
Signed-off-by: Hans Verkuil