linux-toradex.git/drivers/media/video/tvaudio.c, branch v3.2.63

[media] tvaudio: fix compiler warnings

2011-09-06T17:44:30+00:00

This is indeed a bug: balance and volume must be used to set the left and right
channel volume. Fixed.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

V4L/DVB: tvaudio: remove obsolete tda8425 initialization

2010-10-21T03:06:09+00:00

The tda8425 initialization function sets up the inputmap for riva boards.
After some digging I discovered that this was for the V4L rivatv driver
that is found on sourceforge. This driver hasn't been maintained since the
last 5 years and will no longer work with the current v4l framework.

So we can safely remove this.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

V4L/DVB: tvaudio: remove obsolete v4l2-i2c-drv.h header

2010-10-21T03:06:00+00:00

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

V4L/DVB (13166): remove duplicate structure field initialization

2009-12-05T20:40:40+00:00

The definition of tvaudio_tuner_ops initializes the s_tuner field twice.
It appears that the second case should initialize the g_tuner field.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@

if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column):
  cocci.print_main(fld,p0)
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Mauro Carvalho Chehab

V4L/DVB (11380): v4l2-subdev: change s_routing prototype

2009-04-07T00:44:27+00:00

It is no longer needed to use a struct pointer as argument, since v4l2_subdev
doesn't require that ioctl-like approach anymore. Instead just pass the input,
output and config (new!) arguments directly.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

V4L/DVB (11372): v4l2: use old-style i2c API for kernels < 2.6.26 instead of < 2.6.22

2009-04-07T00:44:23+00:00

Originally the intention was to switch to the new style i2c API starting with
the introduction of the API in 2.6.22. However, the i2c_new_probed_device()
function has a lethal bug that wasn't fixed until 2.6.25. Or more accurately,
it was only fixed in the stable series of 2.6.25 and 2.6.26.

Given the fact that the new i2c API also changed starting with 2.6.26 (the
addition of i2c_device_id), it is easiest to switch APIs starting with
2.6.26.

This patch updates all the legacy code accordingly.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

V4L/DVB (11370): v4l2-subdev: move s_std from tuner to core.

2009-04-07T00:44:22+00:00

s_std didn't belong in the tuner ops. Stricly speaking it should be part of
the video ops, but it is used by audio and tuner devices as well, so it is
more efficient to make it part of the core ops.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

V4L/DVB (11365): tvaudio: remove i2c legacy code

2009-04-07T00:44:19+00:00

All drivers that use tvaudio now use v4l2_subdev, so we can remove the
legacy code from tvaudio.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

V4L/DVB (11277): tvaudio: always call init_timer to prevent rmmod crash.

2009-03-30T15:43:46+00:00

In the tvaudio_remove function del_timer_sync(&chip->wt) is called.
However, chip->wt isn't always initialized depending on the type of
audio chip. Since del_timer_sync hangs when given an uninitialized timer
we should always initialize it.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab