linux-toradex.git/drivers/memory/tegra/tegra30-emc.c, branch v6.9

interconnect: constify of_phandle_args in xlate

2024-02-25T22:38:17+00:00

The xlate callbacks are supposed to translate of_phandle_args to proper
provider without modifying the of_phandle_args.  Make the argument
pointer to const for code safety and readability.

Acked-by: Konrad Dybcio 
Acked-by: Thierry Reding  # Tegra
Signed-off-by: Krzysztof Kozlowski 
Acked-by: Alim Akhtar  # Samsung
Link: https://lore.kernel.org/r/20240220072213.35779-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Georgi Djakov

memory: Explicitly include correct DT includes

2023-07-25T20:09:37+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Link: https://lore.kernel.org/r/20230714174717.4059518-1-robh@kernel.org
Signed-off-by: Krzysztof Kozlowski

memory: tegra30-emc: fix interconnect registration race

2023-03-13T19:13:49+00:00

The current interconnect provider registration interface is inherently
racy as nodes are not added until the after adding the provider. This
can specifically cause racing DT lookups to fail.

Switch to using the new API where the provider is not registered until
after it has been fully initialised.

Fixes: d5ef16ba5fbe ("memory: tegra20: Support interconnect framework")
Cc: stable@vger.kernel.org      # 5.11
Cc: Dmitry Osipenko 
Acked-by: Krzysztof Kozlowski 
Signed-off-by: Johan Hovold 
Link: https://lore.kernel.org/r/20230306075651.2449-21-johan+linaro@kernel.org
Signed-off-by: Georgi Djakov

memory: tegra30-emc: use DEFINE_SHOW_ATTRIBUTE to simplify code

2022-10-17T21:49:17+00:00

Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.
No functional change.

Signed-off-by: Liu Shixin 
Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20220926130025.1061373-3-liushixin2@huawei.com

memory: tegra30-emc: Print additional memory info

2022-01-27T09:40:34+00:00

Print out memory type and LPDDR2 configuration on Tegra30, making it
similar to the memory info printed by the Tegra20 memory driver. This
info is useful for debugging purposes.

Tested-by: Svyatoslav Ryhel  # T30 ASUS TF201 LPDDR2
Signed-off-by: Dmitry Osipenko 
Link: https://lore.kernel.org/r/20211222043215.28237-1-digetx@gmail.com
Signed-off-by: Krzysztof Kozlowski

memory: tegra30-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-09-15T07:33:05+00:00

Fix the following coccicheck warning:
  drivers/memory/tegra/tegra30-emc.c:1322:0-23:WARNING:
    tegra_emc_debug_max_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE

Signed-off-by: jing yangyang 
Link: https://lore.kernel.org/r/20210821035223.28282-1-jing.yangyang@zte.com.cn
Signed-off-by: Krzysztof Kozlowski

memory: tegra: Delete dead debugfs checking code

2021-06-10T07:18:15+00:00

The debugfs_create_dir() function does not return NULL, it returns error
pointers.  But in normal situations like this where the caller is not
dereferencing "emc->debugfs.root" then we are not supposed to check the
return.  So instead of fixing these checks, we should delete them.

Signed-off-by: Dan Carpenter 
Link: https://lore.kernel.org/r/YMCQDTSyG8UuQoh0@mwanda
Signed-off-by: Krzysztof Kozlowski

memory: tegra30-emc: Use devm_tegra_core_dev_init_opp_table()

2021-06-03T12:24:03+00:00

Use common devm_tegra_core_dev_init_opp_table() helper for the OPP table
initialization.

Tested-by: Peter Geis  # Ouya T30
Tested-by: Matt Merhar  # Ouya T30
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Dmitry Osipenko 
Signed-off-by: Thierry Reding

memory: tegra: Fix compilation warnings on 64bit platforms

2021-06-01T11:42:53+00:00

Fix compilation warning on 64bit platforms caused by implicit promotion
of 32bit signed integer to a 64bit unsigned value which happens after
enabling compile-testing of the EMC drivers.

Reported-by: kernel test robot 
Reviewed-by: Nathan Chancellor 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Dmitry Osipenko 
Signed-off-by: Thierry Reding

memory: tegra: Print out info-level once per driver probe

2021-04-01T17:58:22+00:00

Probing of EMC drivers may be deferred and in this case we get duplicated
info messages during kernel boot. Use dev_info_once() helper to silence
the duplicated messages.

Signed-off-by: Dmitry Osipenko 
Link: https://lore.kernel.org/r/20210330230445.26619-7-digetx@gmail.com
Signed-off-by: Krzysztof Kozlowski