linux-toradex.git/drivers/memstick/host, branch v4.9.60

memstick: rtsx_usb_ms: Manage runtime PM when accessing the device

2016-10-17T13:43:05+00:00

Accesses to the rtsx usb device, which is the parent of the rtsx memstick
device, must not be done unless it's runtime resumed. This is currently not
the case and it could trigger various errors.

Fix this by properly deal with runtime PM in this regards. This means
making sure the device is runtime resumed, when serving requests via the
->request() callback or changing settings via the ->set_param() callbacks.

Cc: 
Cc: Ritesh Raj Sarraf 
Cc: Alan Stern 
Signed-off-by: Ulf Hansson

memstick: rtsx_usb_ms: Runtime resume the device when polling for cards

2016-10-17T13:43:04+00:00

Accesses to the rtsx usb device, which is the parent of the rtsx memstick
device, must not be done unless it's runtime resumed.

Therefore when the rtsx_usb_ms driver polls for inserted memstick cards,
let's add pm_runtime_get|put*() to make sure accesses is done when the
rtsx usb device is runtime resumed.

Reported-by: Ritesh Raj Sarraf 
Tested-by: Ritesh Raj Sarraf 
Signed-off-by: Alan Stern 
Cc: 
Signed-off-by: Ulf Hansson

rtsx_usb_ms: use schedule_timeout_idle() in polling loop

2016-05-24T00:04:14+00:00

First version of this patch has already been posted to LKML by Ben
Hutchings ~6 months ago, but no further action were performed.

Ben's original message:

: rtsx_usb_ms creates a task that mostly sleeps, but tasks in
: uninterruptible sleep still contribute to the load average (for
: bug-compatibility with Unix).  A load average of ~1 on a system that
: should be idle is somewhat alarming.
:
: Change the sleep to be interruptible, but still ignore signals.

References: https://bugs.debian.org/765717
Link: http://lkml.kernel.org/r/b49f95ae83057efa5d96f532803cba47@natalenko.name
Signed-off-by: Oleksandr Natalenko 
Cc: Oleg Nesterov 
Cc: Ben Hutchings 
Cc: Lee Jones 
Cc: Wolfram Sang 
Cc: Roger Tseng 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/memstick/host/r592.c: avoid gcc-6 warning

2016-03-25T23:37:42+00:00

The r592 driver relies on behavior of the DMA mapping API that is
normally observed but not guaranteed by the API.  Instead it uses a
runtime check to fail transfers if the API ever behaves

When CONFIG_NEED_SG_DMA_LENGTH is not set, one of the checks turns into a
comparison of a variable with itself, which gcc-6.0 now warns about:

drivers/memstick/host/r592.c: In function 'r592_transfer_fifo_dma':
drivers/memstick/host/r592.c:302:31: error: self-comparison always evaluates to false [-Werror=tautological-compare]
    (sg_dma_len(&dev->req->sg) < dev->req->sg.length)) {
                               ^

The check itself is not a problem, so this patch just rephrases the
condition in a way that gcc does not consider an indication of a mistake.
We already know that dev->req->sg.length was initially R592_LFIFO_SIZE, so
we can compare it to that constant again.

Signed-off-by: Arnd Bergmann 
Cc: Maxim Levitsky 
Cc: Quentin Lambert 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

memstick: remove deprecated use of pci api

2015-07-01T02:44:57+00:00

Replace occurences of the pci api by appropriate call to the dma api.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr)

@deprecated@
idexpression id;
position p;
@@

(
  pci_dma_supported@p ( id, ...)
|
  pci_alloc_consistent@p ( id, ...)
)

@bad1@
idexpression id;
position deprecated.p;
@@
...when != &id->dev
   when != pci_get_drvdata ( id )
   when != pci_enable_device ( id )
(
  pci_dma_supported@p ( id, ...)
|
  pci_alloc_consistent@p ( id, ...)
)

@depends on !bad1@
idexpression id;
expression direction;
position deprecated.p;
@@

(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
  )
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
  )
)

Signed-off-by: Quentin Lambert 
Cc: Maxim Levitsky 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

memstick: host: drop owner assignment from platform_drivers

2014-10-20T14:20:53+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

memstick: r592: fix build warnings for !PM_SLEEP

2014-10-14T00:18:22+00:00

When PM_SLEEP is not enabled, the r592_clear_interrupts() function is
never used.  If so, don't build it to prevent a compiler warning.

Signed-off-by: Thierry Reding 
Cc: Maxim Levitsky 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/memstick/host/rtsx_pci_ms.c: add cancel_work when remove driver

2014-06-23T23:47:44+00:00

Add cancel_work_sync() in rtsx_pci_ms_drv_remove() to cancel pending
request work when removing the driver.

Signed-off-by: Micky Ching 
Cc: Samuel Ortiz  says:
Cc: Maxim Levitsky 
Cc: Greg Kroah-Hartman 
Cc: Alex Dubov 
Cc: Roger Tseng 
Cc: Wei WANG 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

memstick: Add realtek USB memstick host driver

2014-04-28T10:02:46+00:00

Realtek USB memstick host driver provides memstick host support based on the
Realtek USB card reader MFD driver.

Signed-off-by: Roger Tseng 
Signed-off-by: Lee Jones

drivers/memstick/host/rtsx_pci_ms.c: fix ms card data transfer bug

2014-01-24T00:37:04+00:00

This patch is used to add support for ms card. The main difference
between ms card and mspro card is long data transfer mode. mspro card
can use auto mode DMA for long data transfer, but ms can not use this
mode, it should use normal mode DMA.

The memstick core added support for ms card, but the original driver will
make ms card fail at initialization, because it uses auto mode DMA.  This
patch makes the ms card work properly.

Signed-off-by: Micky Ching 
Cc: Maxim Levitsky 
Cc: Samuel Ortiz 
Cc: Alex Dubov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds