linux-toradex.git/drivers/message/fusion/mptbase.c, branch v3.3.4

[SCSI] fusion: ensure NUL-termination of MptCallbacksName elements

2011-12-15T06:57:29+00:00

Using strlcpy instead of memcpy makes the strlen() calls superfluous
and also ensures zero-termination of the copied string.
At the same time get rid of the magic constant 50.

Actually, I can't see why copying the callback name is necessary
instead of simply storing a pointer to it (just like to the callback
function itself), but that goes beyond the scope of this fix.

Signed-off-by: Ferenc Wagner 
Acked-by: "Nandigama, Nagalakshmi" 
Signed-off-by: James Bottomley

[SCSI] mptfusion: Fix for device offline while doing aggressive HBA reset

2011-08-27T14:35:53+00:00

[Resend patch as per Bernd Schubert comment ]

Issue:

Device goes offline while doing aggressive HBA reset
along with IO using some utility.

Root cause:

FW goes into bad state due to aggressive reset. Softreset does not
help to recover FW. And also aggressive reset open up the window for
Error handling thread to kicked off at the same time HBA will be in
constant RESET loop as part of aggressive reset test case can lead
Device to goes offline.

Changes:

1. Added extra check as below inside eh_timed_out call back as below.
   if(ioc->ioc_reset_in_progress) Rc = EH_TIMER_RESET

2. Removed " DOORBELL_ACTIVE" check for SAS controller from task
   management context.  Since SAS controller uses high priority queue
   for task management. This check is not required for SAS controller.

3. Moved SoftReset call to HardReset from Task Mgmt context.

Signed-off-by: Kashyap Desai 
Signed-off-by: James Bottomley

[SCSI] mptfusion: Better handling of DEAD IOC PCI-E Link down error condition

2011-08-27T14:35:16+00:00

Find Non-Operation IOC and remove it from OS: Detecting
dead(non-functional) ioc will be done reading doorbell register value
from fault reset thread, which has been called from work thread
context after each specific interval. If doorbell value is 0xFFFFFFFF,
it will be considered as IOC is non-operational and marked as dead
ioc.

Once Dead IOC has been detected, it will be removed at pci layer using
"pci_remove_bus_device" API.

Signed-off-by: Kashyap Desai 
Signed-off-by: James Bottomley

treewide: cleanup continuations and remove logging message whitespace

2011-04-26T08:24:37+00:00

Using C line continuation inside format strings is error prone.
Clean up the unintended whitespace introduced by misuse of \.
Neaten correctly used line continations as well for consistency.

drivers/scsi/arcmsr/arcmsr_hba.c has these errors as well,
but arcmsr needs a lot more work and the driver should likely be
moved to staging instead.

Signed-off-by: Joe Perches 
Acked-by: Randy Dunlap 
Signed-off-by: Jiri Kosina

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

[SCSI] mptfusion: Support SAS2.0 Devices with SAS1.0 Controllers

2011-02-12T19:57:28+00:00

SAS1.0 Controller was not able to detect SAS2.0 Expanders due to Link
RATE detection was limited to 1.5 Gbps and 3.0 Gbps for SAS1
controllers. Added detection for 6.0 Gbps link.  Now, user can mix-up
6.0 Gpbs links with SAS1.0 controller.

e.g SAS1.0 HBA <----> SAS2.0 Expander <------> SAS2.0 Expander <--------> SAS1.0 Drive.

Signed-off-by: Kashyap Desai 
Signed-off-by: James Bottomley

tree-wide: fix comment/printk typos

2010-11-01T19:38:34+00:00

"gadget", "through", "command", "maintain", "maintain", "controller", "address",
"between", "initiali[zs]e", "instead", "function", "select", "already",
"equal", "access", "management", "hierarchy", "registration", "interest",
"relative", "memory", "offset", "already",

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Jiri Kosina

[SCSI] drivers/message/fusion: Return -ENOMEM on memory allocation failure

2010-09-05T17:55:57+00:00

In this code, 0 is returned on memory allocation failure, even though other
failures return -ENOMEM or other similar values.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// 
@@
expression ret;
expression x,e1,e2,e3;
@@

ret = 0
... when != ret = e1
*x = \(kmalloc\|kcalloc\|kzalloc\)(...)
... when != ret = e2
if (x == NULL) { ... when != ret = e3
  return ret;
}
// 

Signed-off-by: Julia Lawall 
Acked-by: "Desai, Kashyap" 
Signed-off-by: James Bottomley

fusion: add function parameter names to kernel-doc

2010-08-14T23:21:00+00:00

Fix fusion missing kernel-doc:

  Warning(drivers/message/fusion/mptbase.c:649): No description found for parameter 'func_name'
  Warning(drivers/message/fusion/mptbase.c:8010): No description found for parameter 'cb_idx'

Signed-off-by: Randy Dunlap 
Signed-off-by: Linus Torvalds

fusion: fix non-kernel-doc comment block

2010-08-14T23:20:59+00:00

Fix comment begin notation not to look like kernel-doc
since it's not.  Removes kernel-doc warnings.

Signed-off-by: Randy Dunlap 
Signed-off-by: Linus Torvalds