linux-toradex.git/drivers/message/i2o/exec-osm.c, branch v3.14.3

drivers/message/i2o/exec-osm.c: add missing mutex_unlock

2010-08-11T15:59:05+00:00

Add a mutex_unlock missing on the error path.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
expression E1;
@@

* mutex_lock(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* mutex_unlock(E1,...);
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

i2o: Update my address

2009-01-06T02:28:04+00:00

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

i2o: Fix 32/64bit DMA locking

2008-10-16T18:21:38+00:00

The I2O ioctls assume 32bits.  In itself that is fine as they are old
cards and nobody uses 64bit.  However on LKML it was noted this
assumption is also made for allocated memory and is unsafe on 64bit
systems.

Fixing this is a mess.  It turns out there is tons of crap buried in a
header file that does racy 32/64bit filtering on the masks.

So we:
- Verify all callers of the racy code can sleep (i2o_dma_[re]alloc)
- Move the code into a new i2o/memory.c file
- Remove the gfp_mask argument so nobody can try and misuse the function
- Wrap a mutex around the problem area (a single mutex is easy to do and
  none of this is performance relevant)
- Switch the remaining problem kmalloc holdout to use i2o_dma_alloc

Cc: Markus Lidel 
Cc: Vasily Averin 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Convert files to UTF-8 and some cleanups

2007-10-19T21:21:04+00:00

* Convert files to UTF-8.

  * Also correct some people's names
    (one example is Eißfeldt, which was found in a source file.
    Given that the author used an ß at all in a source file
    indicates that the real name has in fact a 'ß' and not an 'ss',
    which is commonly used as a substitute for 'ß' when limited to
    7bit.)

  * Correct town names (Goettingen -> Göttingen)

  * Update Eberhard Mönkeberg's address (http://lkml.org/lkml/2007/1/8/313)

Signed-off-by: Jan Engelhardt 
Signed-off-by: Adrian Bunk

I2O: Fix "defined but not used" build warnings

2007-10-17T15:42:56+00:00

drivers/message/i2o/exec-osm.c:539: warning: `i2o_exec_lct_notify' defined but not used

comes when CONFIG_I2O_LCT_NOTIFY_ON_CHANGES=n, because its only callsite
is #ifdef'ed as such. So let's #ifdef the function definition also. Also
move the definition to before the callsite, to get rid of forward prototype.

[akpm@linux-foundation.org: fix warnings]
Signed-off-by: Satyam Sharma 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

i2o proc reading oops

2007-07-17T17:23:06+00:00

Fix oops on reading from some i2o proc files (i2o_seq_show_driver_store() and
other) because their handlers uses "exec" field in struct i2o_controller

Signed-off-by: Vasily Averin 
Acked-by: Alan Cox 
Cc: Markus Lidel 
Acked-by: Kirill Korotaev 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

i2o message leak in i2o_msg_post_wait_mem()

2007-07-17T17:23:06+00:00

We need to free i2o msg in case of error.

Signed-off-by: Vasily Averin 
Acked-by: Alan Cox 
Cc: Markus Lidel 
Acked-by: Kirill Korotaev 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Use mutexes instead of semaphores in I2O driver

2007-07-16T16:05:41+00:00

The I2O driver uses two semaphores as mutexes.  Use the mutex API instead of
the (binary) semaphores.

Signed-off-by: Matthias Kaehlcke 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] fix kernel-doc warnings in 2.6.20-rc1

2006-12-22T16:55:47+00:00

Fix kernel-doc warnings in 2.6.20-rc1.

Signed-off-by: Randy Dunlap 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] i2o_exec_exit and i2o_driver_exit should not be __exit.

2006-12-13T17:05:47+00:00

i2o_exec_exit and i2o_driver_exit were marked as __exit which is a bug
because both are invoked from __init and __exit functions.

Signed-off-by: Ralf Baechle 
Cc: Markus Lidel 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds