linux-toradex.git/drivers/mfd/ab3100-core.c, branch v4.9.58

mfd: ab3100-core.c: Fix multiple warnings reported by Checkpatch

2016-01-14T08:43:53+00:00

WARNING: Missing a blank line after declarations
+       struct ab3100 *ab3100 = dev_get_drvdata(dev->parent);
+       if (!ab3100->startup_events_read)

WARNING: Possible unnecessary 'out of memory' message
+       if (!ab3100) {
+               dev_err(&client->dev, "could not allocate AB3100 device\n");

WARNING: else is not generally useful after a break or return
+                               break;
+                       } else {

total: 0 errors, 3 warnings, 996 lines checked

Cc: Linus Walleij 
Signed-off-by: Lee Jones

mfd: Drop owner assignment from i2c_drivers

2015-08-11T14:08:48+00:00

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: ab3100-core: Correct code sytle problems

2014-07-09T15:38:05+00:00

Corrects the following checkpatch gripes:

    WARNING: quoted string split across lines
    #95: FILE: drivers/mfd/ab3100-core.c:95:
    +			"write error (write register) "
    +			"%d bytes transferred (expected 2)\n",

    WARNING: quoted string split across lines
    #139: FILE: drivers/mfd/ab3100-core.c:139:
    +			"write error (write test register) "
    +			"%d bytes transferred (expected 2)\n",

    WARNING: quoted string split across lines
    #175: FILE: drivers/mfd/ab3100-core.c:175:
    +			"write error (send register address) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    #193: FILE: drivers/mfd/ab3100-core.c:193:
    +			"write error (read register) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    #241: FILE: drivers/mfd/ab3100-core.c:241:
    +			"write error (send first register address) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    #256: FILE: drivers/mfd/ab3100-core.c:256:
    +			"write error (read register page) "
    +			"%d bytes transferred (expected %d)\n",

    WARNING: quoted string split across lines
    #299: FILE: drivers/mfd/ab3100-core.c:299:
    +			"write error (maskset send address) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    #314: FILE: drivers/mfd/ab3100-core.c:314:
    +			"write error (maskset read register) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    #334: FILE: drivers/mfd/ab3100-core.c:334:
    +			"write error (write register) "
    +			"%d bytes transferred (expected 2)\n",

    WARNING: please, no spaces at the start of a line
    #374: FILE: drivers/mfd/ab3100-core.c:374:
    +  return blocking_notifier_chain_unregister(&ab3100->event_subscribers,$

    WARNING: Prefer seq_puts to seq_printf
    #458: FILE: drivers/mfd/ab3100-core.c:458:
    +	seq_printf(s, "AB3100 registers:\n");

    WARNING: quoted string split across lines
    #564: FILE: drivers/mfd/ab3100-core.c:564:
    +			 "debug write reg[0x%02x] with 0x%02x, "
    +			 "after readback: 0x%02x\n",

    WARNING: quoted string split across lines
    #723: FILE: drivers/mfd/ab3100-core.c:723:
    +			 "AB3100 P1E variant detected, "
    +			 "forcing chip to 32KHz\n");

    WARNING: quoted string split across lines
    #882: FILE: drivers/mfd/ab3100-core.c:882:
    +			"could not communicate with the AB3100 analog "
    +			"baseband chip\n");

    WARNING: quoted string split across lines
    #906: FILE: drivers/mfd/ab3100-core.c:906:
    +		dev_err(&client->dev, "accepting it anyway. Please update "
    +			"the driver.\n");

    total: 0 errors, 15 warnings, 999 lines checked

Reviewed-by: Linus Walleij 
Signed-off-by: Lee Jones

mfd: Use dev_get_platdata()

2013-07-31T12:01:29+00:00

Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.

Signed-off-by: Jingoo Han 
Signed-off-by: Lee Jones

mfd: Replace strict_strtoul() with kstrtoul() in ab* and att*

2013-06-13T09:51:56+00:00

The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.

Signed-off-by: Jingoo Han 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Lee Jones

regulator: ab3100: device tree support

2013-04-24T09:54:07+00:00

This implements device tree support for the AB3100 regulators
driver. The initial settings are moved out of platform data
and into the driver for the device tree case, as it appears
that there is no way to supply this as AUXDATA for an I2C
device. The style and bindings are heavily inspired by
Lee Jones' style for AB8500.

Signed-off-by: Linus Walleij 
Acked-by: Lee Jones 
Signed-off-by: Mark Brown

mfd: remove use of __devexit

2012-11-28T20:22:27+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Cc: Srinidhi Kasagar 
Cc: Peter Tyser 
Cc: Daniel Walker 
Cc: Bryan Huntsman 
Acked-by: David Brown 
Acked-by: Linus Walleij 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

mfd: remove use of __devinitconst

2012-11-28T20:21:40+00:00

CONFIG_HOTPLUG is going away as an option so __devinitconst is no
longer needed.

Signed-off-by: Bill Pemberton 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

mfd: remove use of __devinit

2012-11-28T20:20:19+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Srinidhi Kasagar 
Cc: Peter Tyser 
Cc: Daniel Walker 
Cc: Bryan Huntsman 
Acked-by: David Brown 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

mfd: remove use of __devexit_p

2012-11-28T20:16:42+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Srinidhi Kasagar 
Cc: Peter Tyser 
Cc: Daniel Walker 
Cc: Bryan Huntsman 
Acked-by: David Brown 
Acked-by: Linus Walleij 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman