linux-toradex.git/drivers/mfd/altera-sysmgr.c, branch v5.18

mfd: altera-sysmgr: Fix a mistake caused by resource_size conversion

2021-11-05T14:40:26+00:00

The resource_size defines that:
	res->end - res->start + 1;
The origin original code is:
	sysmgr_config.max_register = res->end - res->start - 3;

So, the correct fix is that:
	sysmgr_config.max_register = resource_size(res) - 4;

Fixes: d12edf9661a4 ("mfd: altera-sysmgr: Use resource_size function on resource object")
Signed-off-by: Kai Song 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20211006141926.6120-1-songkai01@inspur.com

mfd: altera-sysmgr: Fix physical address storing more

2021-02-08T13:54:03+00:00

A recent fix improved the way the resource gets passed to
the low-level accessors, but left one warning that appears
in configurations with a resource_size_t that is wider than
a pointer:

In file included from drivers/mfd/altera-sysmgr.c:19:
drivers/mfd/altera-sysmgr.c: In function 'sysmgr_probe':
drivers/mfd/altera-sysmgr.c:148:40: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
  148 |   regmap = devm_regmap_init(dev, NULL, (void *)res->start,
      |                                        ^
include/linux/regmap.h:646:6: note: in definition of macro '__regmap_lockdep_wrapper'
  646 |   fn(__VA_ARGS__, &_key,     \
      |      ^~~~~~~~~~~
drivers/mfd/altera-sysmgr.c:148:12: note: in expansion of macro 'devm_regmap_init'
  148 |   regmap = devm_regmap_init(dev, NULL, (void *)res->start,
      |            ^~~~~~~~~~~~~~~~

I had tried a different approach that would store the address
in the private data as a phys_addr_t, but the easiest solution
now seems to be to add a double cast to shut up the warning.

As the address is passed to an inline assembly, it is guaranteed
to not be wider than a register anyway.

Fixes: d9ca7801b6e5 ("mfd: altera-sysmgr: Fix physical address storing hacks")
Signed-off-by: Arnd Bergmann 
Signed-off-by: Lee Jones

mfd: altera-sysmgr: Use resource_size function on resource object

2020-11-27T07:40:35+00:00

drivers/mfd/altera-sysmgr.c:155:36-39: WARNING: Suspicious code. resource_size is maybe missing with res

Generated by: scripts/coccinelle/api/resource_size.cocci

Signed-off-by: Zou Wei 
Signed-off-by: Lee Jones

mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args

2020-07-06T07:32:00+00:00

Kerneldoc syntax is used, but not complete.  Arg descriptions are required.

Fixes the following W=1 build warnings:

 drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'np' not described in 'altr_sysmgr_regmap_lookup_by_phandle'
 drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'property' not described in 'altr_sysmgr_regmap_lookup_by_phandle'

Cc: Thor Thayer 
Signed-off-by: Lee Jones

mfd: altera-sysmgr: Fix physical address storing hacks

2020-07-06T07:31:54+00:00

Sparse reports:

 drivers/mfd/altera-sysmgr.c:150:30: warning: incorrect type in assignment (different address spaces)
 drivers/mfd/altera-sysmgr.c:150:30:    expected unsigned int [usertype] *base
 drivers/mfd/altera-sysmgr.c:150:30:    got void [noderef]  *
 drivers/mfd/altera-sysmgr.c:156:26: warning: incorrect type in argument 3 (different address spaces)
 drivers/mfd/altera-sysmgr.c:156:26:    expected void [noderef]  *regs
 drivers/mfd/altera-sysmgr.c:156:26:    got unsigned int [usertype] *base

It appears as though the driver data property 'resource_size_t *base'
was being used to store 2 different types of addresses (physical and
IO-mapped) under a single declared type.

Fortunately, no value is recalled from the driver data entry, so it
can be easily omitted.  Instead we can use the value obtained directly
from the platform resource to pass through  Regmap into the call-backs
to be used for the SMCC call and use a local dedicated __iomem
variable for IO-remapping.

Cc: Thor Thayer 
Signed-off-by: Lee Jones

drivers: Introduce device lookup variants by of_node

2019-07-30T11:07:41+00:00

Introduce wrappers for {bus/driver/class}_find_device() to
locate devices by its of_node.

Cc: Maarten Lankhorst 
Cc: Maxime Ripard 
Cc: dri-devel@lists.freedesktop.org
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: devicetree@vger.kernel.org
Cc: Florian Fainelli 
Cc: Frank Rowand 
Cc: Heiko Stuebner 
Cc: Liam Girdwood 
Cc: linux-i2c@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-spi@vger.kernel.org
Cc: Mathieu Poirier 
Cc: Rob Herring 
Cc: Srinivas Kandagatla 
Cc: Takashi Iwai 
Cc: Alan Tull 
Cc: linux-fpga@vger.kernel.org
Cc: Peter Rosin 
Cc: Florian Fainelli 
Cc: Heiner Kallweit 
Cc: "David S. Miller" 
Cc: Andrew Lunn 
Cc: Liam Girdwood 
Cc: "Rafael J. Wysocki" 
Cc: Thor Thayer 
Cc: Jiri Slaby 
Cc: Andrew Lunn 
Cc: Peter Rosin 
Signed-off-by: Suzuki K Poulose 
Acked-by: Lee Jones 
Acked-by: Wolfram Sang  # I2C part
Acked-by: Moritz Fischer  # For FPGA part
Acked-by: Mark Brown 
Link: https://lore.kernel.org/r/20190723221838.12024-3-suzuki.poulose@arm.com
Signed-off-by: Greg Kroah-Hartman

driver_find_device: Unify the match function with class_find_device()

2019-06-24T03:22:31+00:00

The driver_find_device() accepts a match function pointer to
filter the devices for lookup, similar to bus/class_find_device().
However, there is a minor difference in the prototype for the
match parameter for driver_find_device() with the now unified
version accepted by {bus/class}_find_device(), where it doesn't
accept a "const" qualifier for the data argument. This prevents
us from reusing the generic match functions for driver_find_device().

For this reason, change the prototype of the driver_find_device() to
make the "match" parameter in line with {bus/class}_find_device()
and adjust its callers to use the const qualifier. Also, we could
now promote the "data" parameter to const as we pass it down
as a const parameter to the match functions.

Cc: Corey Minyard 
Cc: Russell King 
Cc: Thierry Reding 
Cc: Greg Kroah-Hartman 
Cc: "Rafael J. Wysocki" 
Cc: Will Deacon 
Cc: Joerg Roedel 
Cc: Peter Oberparleiter 
Cc: Sebastian Ott 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: Nehal Shah 
Cc: Shyam Sundar S K 
Cc: Lee Jones 
Cc: Christian Borntraeger 
Signed-off-by: Suzuki K Poulose 
Signed-off-by: Greg Kroah-Hartman

mfd: altera-sysmgr: Add SOCFPGA System Manager

2019-04-02T06:37:45+00:00

The SOCFPGA System Manager register block aggregates different
peripheral functions into one area.
On 32 bit ARM parts, handle in the same way as syscon.
On 64 bit ARM parts, the System Manager can only be accessed by
EL3 secure mode. Since a SMC call to EL3 is required, this new
driver uses regmaps similar to syscon to handle the SMC call.

Since regmaps abstract out the underlying register access, the
changes to drivers accessing the System Manager are minimal.

Signed-off-by: Thor Thayer 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Lee Jones