linux-toradex.git/drivers/mfd/cros_ec_spi.c, branch v4.4.51

spi: Drop owner assignment from spi_drivers

2015-10-28T01:30:17+00:00

An spi_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Andrew F. Davis 
Acked-by: Jonathan Cameron 
Signed-off-by: Mark Brown

mfd: cros_ec: spi: Add OF match table

2015-08-24T14:27:59+00:00

The Documentation/devicetree/bindings/mfd/cros-ec.txt DT binding doc lists
"google,cros-ec-spi" as a compatible string but the corresponding driver
does not have an OF match table. Add the table to the driver so the SPI
core can do an OF style match.

Signed-off-by: Javier Martinez Canillas 
Signed-off-by: Lee Jones

mfd: cros_ec: spi: Add delay for asserting CS

2015-06-15T12:18:24+00:00

Some ECs need a little time for waking up before they can accept
SPI data at a high speed. This is configurable via a DT property
"google,cros-ec-spi-pre-delay".

This patch makes the cros_ec_spi driver to cause a delay before
the beginning of a SPI transaction, to make sure that the EC has
already woken up, if the property has been defined in the DTS.

Signed-off-by: Alexandru M Stan 
Reviewed-by: Doug Anderson 
Signed-off-by: Chris Zhong 
Signed-off-by: Javier Martinez Canillas 
Tested-by: Heiko Stuebner 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones

mfd: cros_ec: Support multiple EC in a system

2015-06-15T12:18:23+00:00

Chromebooks can have more than one Embedded Controller so the
cros_ec device id has to be incremented for each EC registered.

Add a new structure to represent multiple EC as different char
devices (e.g: /dev/cros_ec, /dev/cros_pd). It connects to
cros_ec_device and allows sysfs inferface for cros_pd.

Also reduce number of allocated objects, make chromeos sysfs
class object a static and add refcounting to prevent object
deletion while command is in progress.

Signed-off-by: Gwendal Grignou 
Reviewed-by: Dmitry Torokhov 
Signed-off-by: Javier Martinez Canillas 
Tested-by: Heiko Stuebner 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones

mfd: cros_ec: add bus-specific proto v3 code

2015-06-15T12:18:22+00:00

Add proto v3 support to the SPI, I2C, and LPC.

Signed-off-by: Stephen Barber 
Signed-off-by: Javier Martinez Canillas 
Tested-by: Heiko Stuebner 
Reviewed-by: Gwendal Grignou 
Tested-by: Gwendal Grignou 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones

mfd: cros_ec: add proto v3 skeleton

2015-06-15T12:18:21+00:00

Add support in cros_ec.c to handle EC host command protocol v3.
For v3+, probe for maximum shared protocol version and max
request, response, and passthrough sizes. For now, this will
always fall back to v2, since there is no bus-specific code
for handling proto v3 packets.

Signed-off-by: Stephen Barber 
Signed-off-by: Javier Martinez Canillas 
Reviewed-by: Gwendal Grignou 
Tested-by: Gwendal Grignou 
Tested-by: Heiko Stuebner 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones

mfd: cros_ec: Use a zero-length array for command data

2015-06-15T12:18:19+00:00

Commit 1b84f2a4cd4a ("mfd: cros_ec: Use fixed size arrays to transfer
data with the EC") modified the struct cros_ec_command fields to not
use pointers for the input and output buffers and use fixed length
arrays instead.

This change was made because the cros_ec ioctl API uses that struct
cros_ec_command to allow user-space to send commands to the EC and
to get data from the EC. So using pointers made the API not 64-bit
safe. Unfortunately this approach was not flexible enough for all
the use-cases since there may be a need to send larger commands
on newer versions of the EC command protocol.

So to avoid to choose a constant length that it may be too big for
most commands and thus wasting memory and CPU cycles on copy from
and to user-space or having a size that is too small for some big
commands, use a zero-length array that is both 64-bit safe and
flexible. The same buffer is used for both output and input data
so the maximum of these values should be used to allocate it.

Suggested-by: Gwendal Grignou 
Signed-off-by: Javier Martinez Canillas 
Tested-by: Heiko Stuebner 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones

mfd: cros_ec: Remove parent field

2015-06-15T12:18:17+00:00

Parent and device were pointing to the same device structure.

Parent is unused, removed.

Signed-off-by: Gwendal Grignou 
Tested-by: Stephen Barber 
Tested-by: Heiko Stuebner 
Tested-by: Gwendal Grignou 
Reviewed-by: Puthikorn Voravootivat 
Signed-off-by: Javier Martinez Canillas 
Signed-off-by: Lee Jones

mfd: cros_ec: move locking into cros_ec_cmd_xfer

2014-10-06T20:29:50+00:00

Now that there's a central cros_ec_cmd_xfer(), move the locking
out of the SPI driver.

Signed-off-by: Andrew Bresticker 
Reviewed-by: Simon Glass 
Signed-off-by: Javier Martinez Canillas 
Reviewed-by: Doug Anderson 
Signed-off-by: Lee Jones

mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC

2014-10-06T20:28:48+00:00

If someone sends a EC_CMD_REBOOT_EC to the EC, the EC will likely be
unresponsive for quite a while.  Add a delay to the end of the command
to prevent random failures of future commands.

NOTES:
* This could be optimized a bit by simply delaying the next command
  sent, but EC_CMD_REBOOT_EC is such a rare command that the extra
  complexity doesn't seem worth it.
* This is a bit of an "ugly hack" since the SPI driver is effectively
  snooping on the communication and making a lot of assumptions.  It
  would be nice to architect in some better solution long term.
* This same logic probably needs to be applied to the i2c driver.

Signed-off-by: Doug Anderson 
Reviewed-by: Randall Spangler 
Reviewed-by: Vadim Bendebury 
Signed-off-by: Javier Martinez Canillas 
Signed-off-by: Lee Jones