linux-toradex.git/drivers/mfd/cs42l43.c, branch v6.11

mfd: cs42l43: Update patching revision check

2024-05-10T14:39:17+00:00

The firmware can only be patched once. The current code checks if the
firmware supports the features required by the driver and then patches
if it does not. This could lead to the device being patched twice if
the device was patched before the driver took control, but with a
firmware that doesn't support the features the driver requires. This
would fail but potentially in unpredictable ways.

The check should actually check the device is at the ROM version, and
patch the device if it is. Then a separate later check should error out
if the devices firmware is still too old to be supported. This will at
least fail in a clean way with a nice error message.

Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20240423102339.2363400-1-ckeepax@opensource.cirrus.com
Signed-off-by: Lee Jones

mfd: cs42l43: Fix wrong GPIO_FN_SEL and SPI_CLK_CONFIG1 defaults

2024-03-05T10:40:30+00:00

Two regs have wrong values in existing fields, change them to match
the datasheet.

Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")

Signed-off-by: Maciej Strozek 
Reviewed-by: Charles Keepax 
Link: https://lore.kernel.org/r/20240301101547.2136948-1-mstrozek@opensource.cirrus.com
Signed-off-by: Lee Jones

mfd: cs42l43: Fix wrong register defaults

2024-02-29T17:54:42+00:00

A few regs have unnecessary values in defaults, change them to match the
datasheet

Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")

Signed-off-by: Maciej Strozek 
Link: https://lore.kernel.org/r/20240229155616.118457-1-mstrozek@opensource.cirrus.com
Signed-off-by: Lee Jones

mfd: cs42l43: Handle error from devm_pm_runtime_enable()

2024-02-23T14:58:02+00:00

As it devm_pm_runtime_enable() can fail due to memory allocations, it
is best to handle the error.

Suggested-by: Andy Shevchenko 
Signed-off-by: Charles Keepax 
Reviewed-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20240129152557.3221212-6-ckeepax@opensource.cirrus.com
Signed-off-by: Lee Jones

mfd: cs42l43: Add time postfixes on defines

2024-02-23T14:58:02+00:00

Make the defines a little clearer by adding time based postfixes.

Suggested-by: Andy Shevchenko 
Signed-off-by: Charles Keepax 
Reviewed-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20240129152557.3221212-4-ckeepax@opensource.cirrus.com
Signed-off-by: Lee Jones

mfd: cs42l43: Use __u8 type rather than u8 for firmware interface

2024-02-23T14:58:01+00:00

__xxx is the preferred type for firmware interfaces.

Suggested-by: Andy Shevchenko 
Signed-off-by: Charles Keepax 
Reviewed-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20240129152557.3221212-3-ckeepax@opensource.cirrus.com
Signed-off-by: Lee Jones

mfd: cs42l43: Tidy up header includes

2024-02-23T14:58:01+00:00

Use more forward declarations, move header guards to cover other
includes, and rely less on including headers through other headers.

Suggested-by: Andy Shevchenko 
Signed-off-by: Charles Keepax 
Reviewed-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20240129152557.3221212-2-ckeepax@opensource.cirrus.com
Signed-off-by: Lee Jones

mfd: cs42l43: Use correct macro for new-style PM runtime ops

2023-09-23T18:10:23+00:00

The code was accidentally mixing new and old style macros, update the
macros used to remove an unused function warning whilst building with
no PM enabled in the config.

Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/all/20230822114914.340359-1-ckeepax@opensource.cirrus.com/
Reviewed-by: Nathan Chancellor 
Tested-by: Geert Uytterhoeven 
Acked-by: Lee Jones 
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Linus Torvalds

mfd: cs42l43: Add support for cs42l43 core driver

2023-08-17T11:06:11+00:00

The CS42L43 is an audio CODEC with integrated MIPI SoundWire interface
(Version 1.2.1 compliant), I2C, SPI, and I2S/TDM interfaces designed
for portable applications. It provides a high dynamic range, stereo
DAC for headphone output, two integrated Class D amplifiers for
loudspeakers, and two ADCs for wired headset microphone input or
stereo line input. PDM inputs are provided for digital microphones.

The MFD component registers and initialises the device and provides
PM/system power management.

Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20230804104602.395892-4-ckeepax@opensource.cirrus.com
Signed-off-by: Lee Jones