linux-toradex.git/drivers/mfd/max8925-i2c.c, branch v4.17

mfd: max8925-i2c: Drop unnecessary static

2017-09-05T07:46:00+00:00

Drop static on a local variable, when the variable is initialized before
any use, on every possible execution path through the function.  The static
has no benefit, and dropping it reduces the code size.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;
// 

The change in code size is indicates by the following output from the size
command.

before:
   text    data     bss     dec     hex filename
   2579     240      16    2835     b13 drivers/mfd/max8925-i2c.o

after:
   text    data     bss     dec     hex filename
   2531     240       8    2779     adb drivers/mfd/max8925-i2c.o

Signed-off-by: Julia Lawall 
Acked-by: Kees Cook 
Signed-off-by: Lee Jones

mfd: max8925-i2c: Make it explicitly non-modular

2016-06-29T09:14:30+00:00

The Kconfig currently controlling compilation of this code is:

drivers/mfd/Kconfig: config MFD_MAX8925
drivers/mfd/Kconfig:    bool "Maxim Semiconductor MAX8925 PMIC Support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_init was not in use by this code, the init ordering
remains unchanged with this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Signed-off-by: Paul Gortmaker 
Signed-off-by: Lee Jones

mfd: Use to_i2c_client() instead of open-coding it

2016-01-14T08:43:50+00:00

Signed-off-by: Geliang Tang 
Signed-off-by: Lee Jones

mfd: Drop owner assignment from i2c_drivers

2015-08-11T14:08:48+00:00

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: max8925-i2c: Fix variable length array Sparse warning

2014-09-26T07:15:46+00:00

The largest byte size in use currently is 8.  Fix array size to 9.

drivers/mfd/max8925-i2c.c:40:33:
  warning: Variable length array is used

Signed-off-by: Lee Jones

mfd: max8925-i2c: Fix 'blank line after declarations' warning

2014-07-21T15:58:41+00:00

This is part of an effort to clean-up the MFD subsystem.

WARNING: Missing a blank line after declarations
+       int ret;
+       ret = i2c_add_driver(&max8925_driver);

total: 0 errors, 1 warnings, 275 lines checked

Signed-off-by: Lee Jones

mfd: max8925: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-03-19T08:58:10+00:00

During probe the driver allocates dummy I2C devices for RTC and ADC
with i2c_new_dummy() but it does not check the return value of this
calls.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by i2c_unregister_device().

If i2c_new_dummy() fails for RTC or ADC devices, fail also the probe
for main MFD driver.

Cc: stable@vger.kernel.org
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: max8925: Remove redundant of_match_ptr

2013-10-23T15:21:49+00:00

The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.

Signed-off-by: Sachin Kamat 
Signed-off-by: Lee Jones

mfd: Use dev_get_platdata()

2013-07-31T12:01:29+00:00

Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.

Signed-off-by: Jingoo Han 
Signed-off-by: Lee Jones

mfd: max8925: Convert to managed resources for allocating memory

2013-06-13T10:11:45+00:00

Signed-off-by: Lee Jones 
Signed-off-by: Samuel Ortiz