linux-toradex.git/drivers/mfd/max8997.c, branch v3.18-rc5

mfd: max8997: Make of_device_id array const

2014-06-03T07:11:30+00:00

Array of struct of_device_id may be be const as expected by both
of_match_table field and of_match_node() call.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: max8997: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-03-19T08:58:08+00:00

During probe the driver allocates dummy I2C devices for RTC, haptic and
MUIC with i2c_new_dummy() but it does not check the return value of this
calls.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by i2c_unregister_device().

If i2c_new_dummy() fails for RTC, haptic or MUIC devices, fail also the
probe for main MFD driver.

Cc: stable@vger.kernel.org
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: max8997: Naturalise cross-architecture discrepancies

2014-02-19T13:30:23+00:00

If we compile the MAX8997 for a 64bit architecture we receive the following
warnings:

  drivers/mfd/max8997.c: In function ‘max8997_i2c_get_driver_data’:
  drivers/mfd/max8997.c:173:10:
    warning: cast from pointer to integer of different size
     return (int)match->data;
            ^

Signed-off-by: Lee Jones

mfd: max8997: Use "IS_ENABLED(CONFIG_OF)" for DT code.

2014-01-21T08:28:58+00:00

Instead of "#if define CONFIG_OF" use "IS_ENABLED(CONFIG_OF)"
option for DT code to avoid if-deffery in code.

Signed-off-by: Manish Badarkhe 
Signed-off-by: Lee Jones

mfd: max8997: Enforce mfd_add_devices() return value check

2014-01-21T08:28:10+00:00

The original author provided a random return value check which is
redundant and seemingly floating. This patch not only relocates
the check so it is more clearly associated with the invokation of
mfd_add_devices(), but provides a store for the error value. We
also print a meaningful message on error before returning.

Signed-off-by: Laszlo Papp 
Signed-off-by: Lee Jones

mfd: maxim: Constify struct mfd_cell where possible

2014-01-06T09:13:27+00:00

As of commit 03e361b25ee8dfb1fd9b890072c23c4aae01c6c7 ("mfd: Stop setting
refcounting pointers in original mfd_cell arrays"), the "cell" parameter of
mfd_add_devices() is "const" again. Hence make all cell data passed to
mfd_add_devices() const where possible.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Lee Jones

mfd: max8997: Include linux/of.h header

2013-10-23T15:22:18+00:00

'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid breakage in the future.

Signed-off-by: Sachin Kamat 
Signed-off-by: Lee Jones

mfd: max8997: Use devm_*() functions

2013-08-20T07:51:13+00:00

Use devm_*() functions to make cleanup paths simpler.

Signed-off-by: Jingoo Han 
Signed-off-by: Lee Jones

mfd: max8997: Cast void pointer to data of max8997_pmic_dt_match

2013-08-01T08:54:53+00:00

Casting (void *) data of max8997_pmic_dt_match is necessary,
because variable 'data' of struct 'of_device_id' is defined as
'const void *data'. Thus, pointer should be used instead of value.

Signed-off-by: Jingoo Han 
Signed-off-by: Lee Jones

mfd: Use dev_get_platdata()

2013-07-31T12:01:29+00:00

Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.

Signed-off-by: Jingoo Han 
Signed-off-by: Lee Jones