linux-toradex.git/drivers/mfd/max8998.c, branch v5.9-rc5

mfd: max8998: Convert to i2c_new_dummy_device

2019-08-12T07:53:58+00:00

Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.

Signed-off-by: Wolfram Sang 
Signed-off-by: Lee Jones

mfd: maxim: Add SPDX license identifiers

2018-10-23T07:58:34+00:00

Replace GPL v2.0+ license statements with SPDX license identifiers.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: max8998: Fix potential NULL pointer dereference

2017-09-05T07:46:00+00:00

if 'max8998_i2c_parse_dt_pdata() fails (when out of memory), a NULL
pointer dereference will occur in the error handling code.

Return directly instead.

Fixes: ee999fb3f17f("mfd: max8998: Add support for Device Tree")
Signed-off-by: Christophe JAILLET 
Signed-off-by: Lee Jones

mfd: max8998: Make it explicitly non-modular

2016-06-29T09:14:29+00:00

The Kconfig currently controlling compilation of this code is:

mfd/Kconfig:config MFD_MAX8998
mfd/Kconfig:    bool "Maxim Semiconductor MAX8998/National LP3974 PMIC Support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.

Since module_init was not in use by this code, the init ordering
remains unchanged with this commit.

We delete the include of module.h as well as an unused include of
moduleparam.h too.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Signed-off-by: Paul Gortmaker 
Signed-off-by: Lee Jones

mfd: Use to_i2c_client() instead of open-coding it

2016-01-14T08:43:50+00:00

Signed-off-by: Geliang Tang 
Signed-off-by: Lee Jones

mfd: Drop owner assignment from i2c_drivers

2015-08-11T14:08:48+00:00

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: max8998: Make of_device_id array const

2014-06-03T07:11:34+00:00

Array of struct of_device_id may be be const as expected by both
of_match_table field and of_match_node() call.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: max8998: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-03-19T08:58:09+00:00

During probe the driver allocates dummy I2C device for RTC with i2c_new_dummy() but it does not check the return value of this call.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by i2c_unregister_device().

If i2c_new_dummy() fails for RTC device, fail also the probe for
main MFD driver.

Cc: stable@vger.kernel.org
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: max8998: Naturalise cross-architecture discrepancies

2014-02-19T13:30:25+00:00

If we compile the MAX8998 for a 64bit architecture we receive the following
warnings:

  drivers/mfd/max8998.c: In function ‘max8998_i2c_get_driver_data’:
  drivers/mfd/max8998.c:178:10:
    warning: cast from pointer to integer of different size
     return (int)match->data;
            ^

Signed-off-by: Lee Jones

drivers/mfd/max8998.c: fix pointer-integer size mismatch warning in max8998_i2c_get_driver_data()

2014-01-24T00:36:55+00:00

Fix up the following pointer-integer size mismatch warning in
max8998_i2c_get_driver_data():

	drivers/mfd/max8998.c: In function 'max8998_i2c_get_driver_data':
	drivers/mfd/max8998.c:178:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
		return (int)match->data;
		       ^

Signed-off-by: David Howells 
Cc: Tomasz Figa 
Cc: Mark Brown 
Cc: Samuel Ortiz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds