linux-toradex.git/drivers/mfd/qcom-pm8008.c, branch v6.17

mfd: qcom-pm8008: Add missing MODULE_DESCRIPTION() macro

2024-07-04T16:38:40+00:00

make allmodconfig && make W=1 C=1 reports:

  WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/qcom-pm8008.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson 
Link: https://lore.kernel.org/r/20240603-md-drivers-mfd-qcom-v1-1-88e48013eccc@quicinc.com
Signed-off-by: Lee Jones

mfd: pm8008: Rework to match new DT binding

2024-06-13T17:42:21+00:00

Rework the pm8008 driver to match the new devicetree binding which no
longer describes internal details like interrupts and register offsets
(including which of the two consecutive I2C addresses the registers
belong to).

Instead make the interrupt controller implementation internal and pass
interrupts to the subdrivers using MFD cell resources.

Note that subdrivers may either get their resources, like register block
offsets, from the parent MFD or this can be included in the subdrivers
directly.

In the current implementation, the temperature alarm driver is generic
enough to just get its base address and alarm interrupt from the parent
driver, which already uses this information to implement the interrupt
controller.

The regulator driver, however, needs additional information like parent
supplies and regulator characteristics so in that case it is easier to
just augment its table with the regulator register base addresses.

Similarly, the current GPIO driver already holds the number of pins and
that lookup table can therefore also be extended with register offsets.

Note that subdrivers can now access the two regmaps by name, even if the
primary regmap is registered last so that it is returned by default when
no name is provided in lookups.

Finally, note that the temperature alarm and GPIO subdrivers need some
minor rework before they can be used with non-SPMI devices like the
PM8008. The temperature alarm MFD cell name specifically uses a "qpnp"
rather than "spmi" prefix to prevent binding until the driver has been
updated.

Tested-by: Bryan O'Donoghue 
Signed-off-by: Johan Hovold 
Link: https://lore.kernel.org/r/20240608155526.12996-11-johan+linaro@kernel.org
Signed-off-by: Lee Jones

mfd: pm8008: Drop unused driver data

2024-06-13T17:42:21+00:00

The i2c client driver data pointer has never been used so drop the
unnecessary assignment.

Reviewed-by: Bryan O'Donoghue 
Reviewed-by: Stephen Boyd 
Signed-off-by: Johan Hovold 
Link: https://lore.kernel.org/r/20240608155526.12996-8-johan+linaro@kernel.org
Signed-off-by: Lee Jones

mfd: pm8008: Rename irq chip

2024-06-13T17:42:20+00:00

Drop the redundant "irq" suffix from the irq chip name.

Reviewed-by: Bryan O'Donoghue 
Reviewed-by: Stephen Boyd 
Signed-off-by: Johan Hovold 
Link: https://lore.kernel.org/r/20240608155526.12996-7-johan+linaro@kernel.org
Signed-off-by: Lee Jones

mfd: pm8008: Use lower case hex notation

2024-06-13T17:42:20+00:00

Use lower case hex notation for consistency.

Reviewed-by: Bryan O'Donoghue 
Reviewed-by: Stephen Boyd 
Signed-off-by: Johan Hovold 
Link: https://lore.kernel.org/r/20240608155526.12996-6-johan+linaro@kernel.org
Signed-off-by: Lee Jones

mfd: pm8008: Mark regmap structures as const

2024-06-13T17:42:20+00:00

The regmap irq chip structures can be const so mark them as such.

Reviewed-by: Bryan O'Donoghue 
Reviewed-by: Stephen Boyd 
Signed-off-by: Johan Hovold 
Link: https://lore.kernel.org/r/20240608155526.12996-5-johan+linaro@kernel.org
Signed-off-by: Lee Jones

mfd: pm8008: Deassert reset on probe

2024-06-13T17:42:20+00:00

Request and deassert any (optional) reset gpio during probe in case it
has been left asserted by the boot firmware.

Note the reset line is not asserted to avoid reverting to the default
I2C address in case the firmware has configured an alternate address.

Tested-by: Bryan O'Donoghue 
Reviewed-by: Linus Walleij 
Signed-off-by: Johan Hovold 
Link: https://lore.kernel.org/r/20240608155526.12996-4-johan+linaro@kernel.org
Signed-off-by: Lee Jones

mfd: pm8008: Fix regmap irq chip initialisation

2024-06-13T17:42:20+00:00

The regmap irq array is potentially shared between multiple PMICs and
should only contain static data.

Use a custom macro to initialise also the type fields and drop the
unnecessary updates on each probe.

Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
Reviewed-by: Bryan O'Donoghue 
Signed-off-by: Johan Hovold 
Link: https://lore.kernel.org/r/20240608155526.12996-3-johan+linaro@kernel.org
Signed-off-by: Lee Jones

mfd: Explicitly include correct DT includes

2023-08-18T20:48:03+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Link: https://lore.kernel.org/r/20230714174731.4059811-1-robh@kernel.org
Signed-off-by: Lee Jones

mfd: pm8008: Drop bogus i2c module alias

2023-06-15T08:19:38+00:00

Prior to commit af503716ac14 ("i2c: core: report OF style module alias
for devices registered via OF") drivers using OF matching needed an i2c
module alias such as "i2c:pm8008" for module autoloading to work.

Drop the bogus i2c alias from the pm8008 driver which was merged long
after i2c core was fixed and whose alias did not match the driver name
("pm8008") to begin with.

Signed-off-by: Johan Hovold 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20230526091646.17318-3-johan+linaro@kernel.org