linux-toradex.git/drivers/mfd/retu-mfd.c, branch v7.2-rc5

mfd: retu: Constify read-only regmap structs

2024-08-30T08:40:12+00:00

The regmap_bus, regmap_irq and regmap_irq_chip structs are not modified
and can be declared as const to move their data to a read-only section.

The pointer to reference the regmap_irq_chip structs has been converted
to const.

Signed-off-by: Javier Carrasco 
Link: https://lore.kernel.org/r/20240704-mfd-const-regmap_config-v2-11-0c8785b1331d@gmail.com
Signed-off-by: Lee Jones

mfd: Drop explicit initialization of struct i2c_device_id::driver_data to 0

2024-07-04T16:08:02+00:00

These drivers don't use the driver_data member of struct i2c_device_id,
so don't explicitly initialize this member.

This prepares putting driver_data in an anonymous union which requires
either no initialization or named designators. But it's also a nice
cleanup on its own.

While add it, also remove commas after the sentinel entries.

Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20240510211011.2273978-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones

mfd: Switch i2c drivers back to use .probe()

2023-06-15T08:19:37+00:00

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
back to (the new) .probe() to be able to eventually drop .probe_new() from
struct i2c_driver.

Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20230515182752.10050-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones

mfd: retu-mfd: Convert to i2c's .probe_new()

2022-12-07T13:27:23+00:00

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20221118224540.619276-453-uwe@kleine-koenig.org

i2c: Make remove callback return void

2022-08-16T10:46:26+00:00

The value returned by an i2c driver's remove function is mostly ignored.
(Only an error message is printed if the value is non-zero that the
error is ignored.)

So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.

Reviewed-by: Peter Senna Tschudin 
Reviewed-by: Jeremy Kerr 
Reviewed-by: Benjamin Mugnier 
Reviewed-by: Javier Martinez Canillas 
Reviewed-by: Crt Mori 
Reviewed-by: Heikki Krogerus 
Acked-by: Greg Kroah-Hartman 
Acked-by: Marek Behún  # for leds-turris-omnia
Acked-by: Andy Shevchenko 
Reviewed-by: Petr Machata  # for mlxsw
Reviewed-by: Maximilian Luz  # for surface3_power
Acked-by: Srinivas Pandruvada  # for bmc150-accel-i2c + kxcjk-1013
Reviewed-by: Hans Verkuil  # for media/* + staging/media/*
Acked-by: Miguel Ojeda  # for auxdisplay/ht16k33 + auxdisplay/lcd2s
Reviewed-by: Luca Ceresoli  # for versaclock5
Reviewed-by: Ajay Gupta  # for ucsi_ccg
Acked-by: Jonathan Cameron  # for iio
Acked-by: Peter Rosin  # for i2c-mux-*, max9860
Acked-by: Adrien Grassein  # for lontium-lt8912b
Reviewed-by: Jean Delvare  # for hwmon, i2c-core and i2c/muxes
Acked-by: Corey Minyard  # for IPMI
Reviewed-by: Vladimir Oltean 
Acked-by: Dmitry Torokhov 
Acked-by: Sebastian Reichel  # for drivers/power
Acked-by: Krzysztof Hałasa 
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Wolfram Sang

mfd: Constify static struct resources

2020-11-19T08:34:21+00:00

Constify a number of static struct resource. The only usage of the
structs are to assign their address to the resources field in the
mfd_cell struct. This allows the compiler to put them in read-only
memory. Done with the help of Coccinelle.

Signed-off-by: Rikard Falkeborn 
Signed-off-by: Lee Jones

mfd: retu: Add OF device ID table

2017-07-18T07:27:18+00:00

The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:.

But this could change in the future so the correct approach is to have a
OF device ID table if the devices are registered via OF.

Signed-off-by: Javier Martinez Canillas 
Acked-by: Rob Herring 
Acked-by: Aaro Koskinen 
Acked-by: Tony Lindgren 
Reviewed-by: Wolfram Sang 
Signed-off-by: Lee Jones

mfd: retu: Drop -mfd suffix from I2C device ID name

2017-07-18T07:26:30+00:00

It's not correct to encode the subsystem in the I2C device name, so
drop the -mfd suffix. To maintain bisect-ability, change driver and
platform code / DTS users in the same patch.

Suggested-by: Lee Jones 
Signed-off-by: Javier Martinez Canillas 
Acked-by: Rob Herring 
Acked-by: Aaro Koskinen 
Acked-by: Tony Lindgren 
Reviewed-by: Wolfram Sang 
Signed-off-by: Lee Jones

mfd: Drop owner assignment from i2c_drivers

2015-08-11T14:08:48+00:00

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: retu: Constify struct regmap_config

2015-01-22T15:56:19+00:00

The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones