linux-toradex.git/drivers/mfd/tps65910.c, branch v5.1-rc4

mfd: tps65910: Make it explicitly non-modular

2019-02-01T08:21:13+00:00

The Kconfig currently controlling compilation of this code is:

drivers/mfd/Kconfig:config MFD_TPS65910
drivers/mfd/Kconfig-    bool "TI TPS65910 Power Management chip"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_init was not in use by this code, the init ordering
remains unchanged with this commit.

We don't replace module.h with init.h since the file already has that.
We do delete an unused moduleparam.h include though.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Signed-off-by: Paul Gortmaker 
Acked-by: Linus Walleij 
Acked-by: Tony Lindgren 
Signed-off-by: Lee Jones

mfd: tps65910: Move an assignment in tps65910_sleepinit()

2018-05-16T08:21:48+00:00

Move the assignment for the local variable "dev" so that its setting
will be performed after a configuration check by this function.

Signed-off-by: Markus Elfring 
Signed-off-by: Lee Jones

mfd: tps65910: Delete an unnecessary variable initialisation in tps65910_sleepinit()

2018-05-16T08:21:48+00:00

The local variable "dev" will be reassigned by a following statement.
Thus omit the explicit initialisation at the beginning.

Signed-off-by: Markus Elfring 
Signed-off-by: Lee Jones

mfd: tps65910: Delete an unnecessary variable initialisation in four functions

2018-05-16T08:21:48+00:00

The local variable "ret" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.

Signed-off-by: Markus Elfring 
Signed-off-by: Lee Jones

mfd: tps65910: Delete an error message for a failed memory allocation in tps65910_parse_dt()

2018-05-16T08:21:48+00:00

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Lee Jones

regulator: tps65910: wire up sleep control configuration

2017-06-15T17:23:27+00:00

This enables configuring the PMIC's sleep mode via device-tree.

A pointer indirection to sleep mode data is removed, as it simplifies
the implementation slightly. In current kernel tree, platform data
structure is not used outside MFD cell drivers.

Signed-off-by: Michał Mirosław 
Signed-off-by: Mark Brown

mfd: tps65910: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-05-09T12:27:39+00:00

Use devm_mfd_add_devices() for adding MFD child devices and
devm_regmap_add_irq_chip() for IRQ chip registration.

This reduces the error code path and .remove callback for removing
MFD child devices and deleting IRQ chip data.

Signed-off-by: Laxman Dewangan 
Signed-off-by: Lee Jones

mfd: tps65910: Use devm_mfd_add_devices() for mfd_device registration

2016-04-19T06:56:56+00:00

Use devm_mfd_add_devices() for MFD devices registration and remove
the call of mfd_remove_devices() from .remove callback to remove
MFD child-devices. This is done by managed device framework.

CC: Tony Lindgren 
Signed-off-by: Laxman Dewangan 
Signed-off-by: Lee Jones

mfd: Drop owner assignment from i2c_drivers

2015-08-11T14:08:48+00:00

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones

mfd: tps65910: Work around silicon erratum SWCZ010

2014-09-26T07:15:48+00:00

http://www.ti.com/lit/pdf/SWCZ010:
  Glitch on SDA-SCL not managed correctly by the I2C IP

Impact:
The standard specifies that the I2C transfer should restart on a start
event in all cases. The current design does not support two consecutive
Start conditions. This can cause the first real access after such a
glitch to be corrupted.

Description:
An unexpected glitch on SDA and SCL can generate a wrong start event.
In the current design, the SCL line must toggle two times to detect a
new start event and completely restart the I2C access; hence the real
start event is not detected in the case of a single SCL toggle.

Workaround:
Repeat I2C access.

A simpler workaround is to make a dummy transfer just before the first
access to the tps65910 chip. This can be done unconditionally.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) 
Acked-by: Mark Brown 
Signed-off-by: Lee Jones