linux-toradex.git/drivers/mfd/tps65911-comparator.c, branch v6.15

mfd: Switch back to struct platform_driver::remove()

2024-11-01T15:56:58+00:00

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.

Convert all platform drivers below drivers/mfd to use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.

On the way do a few whitespace changes to make indention consistent.

Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20241025102943.250184-2-u.kleine-koenig@baylibre.com
Signed-off-by: Lee Jones

mfd: tps65911-comparator: Convert to platform remove callback returning void

2023-12-07T13:50:28+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20231123165627.492259-18-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones

mfd: tps65911-comparator: Use regmap accessors

2020-11-19T08:34:22+00:00

Use regmap accessors directly for register manipulation - removing
one layer of abstraction.

Signed-off-by: Michał Mirosław 
Signed-off-by: Lee Jones

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30T18:26:32+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation either version 2 of the license or at
  your option any later version

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

has been chosen to replace the boilerplate/reference in 3029 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de
Signed-off-by: Greg Kroah-Hartman

mfd: tps65911-comparator: Fix an off by one bug

2018-05-16T08:21:48+00:00

The COMP1 and COMP2 elements are in 0 and 1 respectively so this code is
accessing the wrong elements and one space beyond the end of the array.

The "id" variable is never COMP (0) so that code can be removed.

Fixes: 6851ad3ab346 ("TPS65911: Comparator: Add comparator driver")
Reported-by: Dan Carpenter 
Signed-off-by: Lee Jones

mfd: tps65911-comparator: Fix a build error

2018-05-16T08:21:48+00:00

In 2012, we changed the tps65910 API and fixed most drivers but forgot
to update this one.

Fixes: 3f7e82759c69 ("mfd: Commonize tps65910 regmap access through header")
Signed-off-by: Dan Carpenter 
Signed-off-by: Lee Jones

mfd: drop owner assignment from platform_drivers

2014-10-20T14:20:53+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

mfd: remove use of __devexit

2012-11-28T20:22:27+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Cc: Srinidhi Kasagar 
Cc: Peter Tyser 
Cc: Daniel Walker 
Cc: Bryan Huntsman 
Acked-by: David Brown 
Acked-by: Linus Walleij 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

mfd: remove use of __devinit

2012-11-28T20:20:19+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Srinidhi Kasagar 
Cc: Peter Tyser 
Cc: Daniel Walker 
Cc: Bryan Huntsman 
Acked-by: David Brown 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

mfd: remove use of __devexit_p

2012-11-28T20:16:42+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Srinidhi Kasagar 
Cc: Peter Tyser 
Cc: Daniel Walker 
Cc: Bryan Huntsman 
Acked-by: David Brown 
Acked-by: Linus Walleij 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman