linux-toradex.git/drivers/mfd, branch v3.12.25

mfd: sm501: dbg_regs attribute must be read-only

2014-07-02T10:05:43+00:00

commit 8a8320c2e78d1b619a8fa8eb5ae946b8691de604 upstream.

Fix:

sm501 sm501: SM501 At b3e00000: Version 050100a0, 8 Mb, IRQ 100
Attribute dbg_regs: write permission without 'store'
------------[ cut here ]------------
WARNING: at drivers/base/core.c:620

dbg_regs does not have a write function and must therefore be marked
as read-only.

Signed-off-by: Guenter Roeck 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: kempld-core: Fix potential hang-up during boot

2014-05-15T07:54:58+00:00

commit 204747c970c0d568721c76ab8a57dde0e5dcf0d5 upstream.

On PXT and COMe-cPC2 boards it is observed that the hardware
mutex is acquired but not being released during initialization.
This can result in a hang-up during boot if the driver is built
into the kernel.

Releasing the mutex twice if it was acquired fixes the problem.
Subsequent request/release cycles work as expected, so the fix is
only needed during initialization.

Reviewed-by: Michael Brunner 
Tested-by: Michael Brunner 
Signed-off-by: Guenter Roeck 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: tps65910: Fix possible invalid pointer dereference on regmap_add_irq_chip fail

2014-05-15T07:54:57+00:00

commit 483e2dfdbc94751430e41db9973985f5b054d322 upstream.

Fixes: 4aab3fadad32 ("mfd: tps65910: Move interrupt implementation code to mfd file")

tps65910_irq_init() sets 'tps65910->chip_irq' before calling
regmap_add_irq_chip(). If the regmap_add_irq_chip() call fails in
memory allocation of regmap_irq_chip_data members then:

1. The 'tps65910->chip_irq' will still hold some value
2. 'tps65910->irq_data' will be pointing to already freed memory
   (because regmap_add_irq_chip() will free it on error)

This results in invalid memory access during driver remove because the
tps65910_irq_exit() tests whether 'tps65910->chip_irq' is not zero.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: max8997: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-05-15T07:54:57+00:00

commit 97dc4ed3fa377ec91bb60ba98b70d645c2099384 upstream.

During probe the driver allocates dummy I2C devices for RTC, haptic and
MUIC with i2c_new_dummy() but it does not check the return value of this
calls.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by i2c_unregister_device().

If i2c_new_dummy() fails for RTC, haptic or MUIC devices, fail also the
probe for main MFD driver.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: max8998: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-05-15T07:54:56+00:00

commit ed26f87b9f71693a1d1ee85f5e6209601505080f upstream.

During probe the driver allocates dummy I2C device for RTC with i2c_new_dummy() but it does not check the return value of this call.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by i2c_unregister_device().

If i2c_new_dummy() fails for RTC device, fail also the probe for
main MFD driver.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: max8925: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-05-15T07:54:56+00:00

commit 96cf3dedc491d2f1f66cc26217f2b06b0c7b6797 upstream.

During probe the driver allocates dummy I2C devices for RTC and ADC
with i2c_new_dummy() but it does not check the return value of this
calls.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by i2c_unregister_device().

If i2c_new_dummy() fails for RTC or ADC devices, fail also the probe
for main MFD driver.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: max77693: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-05-15T07:54:55+00:00

commit ad09dd6a1f5d6244bd89314015af506ba7f9810a upstream.

During probe the driver allocates dummy I2C devices for MUIC and haptic
with i2c_new_dummy() but it does not check the return value of this
calls.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by devm_regmap_init_i2c() and i2c_unregister_device().

If i2c_new_dummy() fails for MUIC or haptic devices, fail also the probe
for main MFD driver.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: max77686: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-05-15T07:54:55+00:00

commit b9e183a1d495cd65412abe0f9df19b151716bfe7 upstream.

During probe the driver allocates dummy I2C device for RTC with
i2c_new_dummy() but it does not check the return value of this call.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by i2c_unregister_device().

If i2c_new_dummy() fails for RTC device, fail also the probe for main
MFD driver.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: 88pm800: Fix I2C device resource leak if probe fails

2014-05-15T07:54:54+00:00

commit 141050cf3d84fc303df58796d68dc1376b0e8f67 upstream.

During probe the driver allocates two dummy I2C devices for subchips in
function pm800_pages_init(). Additionally this function allocates
regmaps for these subchips. If any of these steps fail then these dummy
I2C devices are not freed and resources leak.

On pm800_pages_init() fail the driver must call pm800_pages_exit() to
unregister dummy I2C devices.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: 88pm860x: Fix I2C device resource leak on regmap init fail

2014-05-15T07:54:53+00:00

commit a7ab1c8b261305af583ce26bb4a14f555fdaa73e upstream.

During probe the driver allocates dummy I2C device for companion chip
and then allocates a regmap for it. If regmap_init_i2c() fails then the
I2C driver (allocated with i2c_new_dummy()) is not freed and this
resource leaks.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby