linux-toradex.git/drivers/mfd, branch v3.12.42

mfd: kempld-core: Fix callback return value check

2015-04-21T14:30:02+00:00

commit c8648508ebfc597058d2cd00b6c539110264a167 upstream.

On success, callback function returns 0. So invert the if condition
check so that we can break out of loop.

Signed-off-by: Ameya Palande <2ameya@gmail.com>
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: viperboard: Fix platform-device id collision

2015-01-09T10:28:28+00:00

commit b6684228726cc25551a43f5c0bd9c5f977f10f48 upstream.

Allow more than one viperboard to be connected by registering with
PLATFORM_DEVID_AUTO instead of PLATFORM_DEVID_NONE.

The subdevices are currently registered with PLATFORM_DEVID_NONE, which
will cause a name collision on the platform bus when a second viperboard
is plugged in:

viperboard 1-2.4:1.0: version 0.00 found at bus 001 address 004
------------[ cut here ]------------
WARNING: CPU: 0 PID: 181 at /home/johan/work/omicron/src/linux/fs/sysfs/dir.c:31 sysfs_warn_dup+0x74/0x84()
sysfs: cannot create duplicate filename '/bus/platform/devices/viperboard-gpio'
Modules linked in: i2c_viperboard viperboard netconsole [last unloaded: viperboard]
CPU: 0 PID: 181 Comm: bash Tainted: G        W      3.17.0-rc6 #1
[] (unwind_backtrace) from [] (show_stack+0x20/0x24)
[] (show_stack) from [] (dump_stack+0x24/0x28)
[] (dump_stack) from [] (warn_slowpath_common+0x80/0x98)
[] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x40/0x48)
[] (warn_slowpath_fmt) from [] (sysfs_warn_dup+0x74/0x84)
[] (sysfs_warn_dup) from [] (sysfs_do_create_link_sd.isra.2+0xcc/0xd0)
[] (sysfs_do_create_link_sd.isra.2) from [] (sysfs_create_link+0x3c/0x48)
[] (sysfs_create_link) from [] (bus_add_device+0x12c/0x1e0)
[] (bus_add_device) from [] (device_add+0x410/0x584)
[] (device_add) from [] (platform_device_add+0xd8/0x26c)
[] (platform_device_add) from [] (mfd_add_device+0x240/0x344)
[] (mfd_add_device) from [] (mfd_add_devices+0xb8/0x110)
[] (mfd_add_devices) from [] (vprbrd_probe+0x160/0x1b0 [viperboard])
[] (vprbrd_probe [viperboard]) from [] (usb_probe_interface+0x1bc/0x2a8)
[] (usb_probe_interface) from [] (driver_probe_device+0x14c/0x3ac)
[] (driver_probe_device) from [] (__driver_attach+0xa4/0xa8)
[] (__driver_attach) from [] (bus_for_each_dev+0x70/0xa4)
[] (bus_for_each_dev) from [] (driver_attach+0x2c/0x30)
[] (driver_attach) from [] (usb_store_new_id+0x170/0x1ac)
[] (usb_store_new_id) from [] (new_id_store+0x34/0x3c)
[] (new_id_store) from [] (drv_attr_store+0x30/0x3c)
[] (drv_attr_store) from [] (sysfs_kf_write+0x5c/0x60)
[] (sysfs_kf_write) from [] (kernfs_fop_write+0xd4/0x194)
[] (kernfs_fop_write) from [] (vfs_write+0xb4/0x1c0)
[] (vfs_write) from [] (SyS_write+0x4c/0xa0)
[] (SyS_write) from [] (ret_fast_syscall+0x0/0x48)
---[ end trace 98e8603c22d65817 ]---
viperboard 1-2.4:1.0: Failed to add mfd devices to core.
viperboard: probe of 1-2.4:1.0 failed with error -17

Signed-off-by: Johan Hovold 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: stmpe: Fix STMPE24xx GPMR LSB

2015-01-09T10:28:27+00:00

commit 871c3cf4ea7d5baf58e0a40bce7431ca5525aa2a upstream.

The least significat byte of the GPIO value read register
on the STMPE24xx series is on addres 0xA4 not 0xA5. Correct
against datasheet and tested on the STMPE2401 hardware.

Signed-off-by: Linus Walleij 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: tc6393xb: Fail ohci suspend if full state restore is required

2015-01-07T15:24:07+00:00

commit 1a5fb99de4850cba710d91becfa2c65653048589 upstream.

Some boards with TC6393XB chip require full state restore during system
resume thanks to chip's VCC being cut off during suspend (Sharp SL-6000
tosa is one of them). Failing to do so would result in ohci Oops on
resume due to internal memory contentes being changed. Fail ohci suspend
on tc6393xb is full state restore is required.

Recommended workaround is to unbind tmio-ohci driver before suspend and
rebind it after resume.

Signed-off-by: Dmitry Eremin-Solenikov 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: rtsx_pcr: Fix MSI enable error handling

2014-11-13T18:02:18+00:00

commit 5152970538a5e16c03bbcb9f1c780489a795ed40 upstream.

pci_enable_msi() can return failure with both positive and negative
integers -- it returns 0 for success -- but is only tested here for
"if (ret < 0)".  This causes us to try to use MSI on the RTS5249 SD
reader in the Dell XPS 11 when enabling MSI failed, causing:

[    1.737110] rtsx_pci: probe of 0000:05:00.0 failed with error -110

Reported-by: D. Jared Dominguez 
Tested-by: D. Jared Dominguez 
Signed-off-by: Chris Ball 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: omap-usb-host: Fix improper mask use.

2014-09-17T14:55:03+00:00

commit 46de8ff8e80a6546aa3d2fdf58c6776666301a0c upstream.

single-ulpi-bypass is a flag used for older OMAP3 silicon.

The flag when set, can excite code that improperly uses the
OMAP_UHH_HOSTCONFIG_UPLI_BYPASS define to clear the corresponding bit.
Instead it clears all of the other bits disabling all of the ports in
the process.

Signed-off-by: Michael Welling 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: sm501: dbg_regs attribute must be read-only

2014-07-02T10:05:43+00:00

commit 8a8320c2e78d1b619a8fa8eb5ae946b8691de604 upstream.

Fix:

sm501 sm501: SM501 At b3e00000: Version 050100a0, 8 Mb, IRQ 100
Attribute dbg_regs: write permission without 'store'
------------[ cut here ]------------
WARNING: at drivers/base/core.c:620

dbg_regs does not have a write function and must therefore be marked
as read-only.

Signed-off-by: Guenter Roeck 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: kempld-core: Fix potential hang-up during boot

2014-05-15T07:54:58+00:00

commit 204747c970c0d568721c76ab8a57dde0e5dcf0d5 upstream.

On PXT and COMe-cPC2 boards it is observed that the hardware
mutex is acquired but not being released during initialization.
This can result in a hang-up during boot if the driver is built
into the kernel.

Releasing the mutex twice if it was acquired fixes the problem.
Subsequent request/release cycles work as expected, so the fix is
only needed during initialization.

Reviewed-by: Michael Brunner 
Tested-by: Michael Brunner 
Signed-off-by: Guenter Roeck 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: tps65910: Fix possible invalid pointer dereference on regmap_add_irq_chip fail

2014-05-15T07:54:57+00:00

commit 483e2dfdbc94751430e41db9973985f5b054d322 upstream.

Fixes: 4aab3fadad32 ("mfd: tps65910: Move interrupt implementation code to mfd file")

tps65910_irq_init() sets 'tps65910->chip_irq' before calling
regmap_add_irq_chip(). If the regmap_add_irq_chip() call fails in
memory allocation of regmap_irq_chip_data members then:

1. The 'tps65910->chip_irq' will still hold some value
2. 'tps65910->irq_data' will be pointing to already freed memory
   (because regmap_add_irq_chip() will free it on error)

This results in invalid memory access during driver remove because the
tps65910_irq_exit() tests whether 'tps65910->chip_irq' is not zero.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby

mfd: max8997: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-05-15T07:54:57+00:00

commit 97dc4ed3fa377ec91bb60ba98b70d645c2099384 upstream.

During probe the driver allocates dummy I2C devices for RTC, haptic and
MUIC with i2c_new_dummy() but it does not check the return value of this
calls.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by i2c_unregister_device().

If i2c_new_dummy() fails for RTC, haptic or MUIC devices, fail also the
probe for main MFD driver.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Jiri Slaby