linux-toradex.git/drivers/misc/kgdbts.c, branch PD13.0.0alpha

kgdbts: only use new asm-generic/ptrace.h api when needed

2011-06-01T07:35:01+00:00

The new instruction_pointer_set helper is defined for people who have
converted to asm-generic/ptrace.h, so don't use it generally unless
the arch needs it (in which case it has been converted).  This should
fix building of kgdb tests for arches not yet converted.

Signed-off-by: Mike Frysinger 
Acked-by: Stephen Rothwell 
Cc: Jason Wessel 
Cc: Andrew Morton 
Signed-off-by: Linus Torvalds

kgdbts: unify/generalize gdb breakpoint adjustment

2011-05-27T00:12:36+00:00

The Blackfin arch, like the x86 arch, needs to adjust the PC manually
after a breakpoint is hit as normally this is handled by the remote gdb.
However, rather than starting another arch ifdef mess, create a common
GDB_ADJUSTS_BREAK_OFFSET define for any arch to opt-in via their kgdb.h.

Signed-off-by: Mike Frysinger 
Cc: Oleg Nesterov 
Cc: Jason Wessel 
Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: "H. Peter Anvin" 
Acked-by: Paul Mundt 
Acked-by: Dongdong Deng 
Cc: Sergei Shtylyov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

kgdboc,kgdbts: strlen() doesn't count the terminator

2011-03-25T21:37:30+00:00

This is an off by one because strlen() doesn't count the null
terminator.  We strcpy() these strings into an array of size
MAX_CONFIG_LEN.

Signed-off-by: Dan Carpenter 
Signed-off-by: Jason Wessel

kgdbts: prevent re-entry to kgdbts before it unregisters

2010-10-29T18:14:41+00:00

The "kgdb_connected" variable of debug_core just indicates whether or
not kgdbts is connected to the debug_core.  It does not completely
prevent a script from trying invoke kgdbts again and possibly crashing
the system (see Call Trace below).

The configured variable in kgtbts can be used instead of
kgdb_connected instead of kgdb_connected. The cleanup_kgdbts() can
also be removed because there is no possible way to build kgdbts as a
kernel module that you could unload with rmmod.

Call Trace:
-----------------------------------------------------------------
root:/$ echo kgdbts=V1S1000 > /sys/module/kgdbts/parameters/kgdbts
kgdb: Unregistered I/O driver kgdbts, debugger disabled.
------------[ cut here ]------------
WARNING: at kernel/debug/debug_core.c:1002
kgdb_unregister_io_module+0xec/0x100()
Hardware name: Moon Creek platform
Modules linked in:
Pid: 664, comm: sh Not tainted 2.6.34.1-WR4.0.0.0_standard #58
Call Trace:
 [] warn_slowpath_common+0x6d/0xa0
 [] ? kgdb_unregister_io_module+0xec/0x100
 [] ? kgdb_unregister_io_module+0xec/0x100
 [] ? param_attr_store+0x0/0x20
 [] warn_slowpath_null+0x15/0x20
 [] kgdb_unregister_io_module+0xec/0x100
 [] cleanup_kgdbts+0x1a/0x20
 [] param_set_kgdbts_var+0x6d/0xb0
 [] ? param_set_kgdbts_var+0x0/0xb0
 [] param_attr_store+0x17/0x20
 [] module_attr_store+0x2c/0x40
 [] sysfs_write_file+0x94/0xf0
 [] vfs_write+0x96/0x130
 [] ? sysfs_write_file+0x0/0xf0
 [] sys_write+0x46/0xd0
 [] system_call_done+0x0/0x4
---[ end trace 4eb028c6ee43154c ]---
kgdb: Unregistered I/O driver kgdbts, debugger disabled.
-----------------------------------------------------------------

[jason.wessel@windriver.com: remove cleanup_kgdbts() ]
Signed-off-by: Dongdong Deng 
Signed-off-by: Jason Wessel

kgdbts,sh: Add in breakpoint pc offset for superh

2010-04-02T19:58:17+00:00

The kgdb test suite mimics the behavior of gdb.  For the sh
architecture the pc must be decremented by 2 for software breakpoint.

Signed-off-by: Jason Wessel 
Acked-by: Paul Mundt

kgdb: Replace strstr() by strchr() for single-character needles

2009-12-11T14:43:15+00:00

Some versions of gcc replace calls to strstr() with single-character
"needle" string parameters by calls to strchr() behind our back.
This causes linking errors if strchr() is defined as an inline function
in  (e.g. on m68k, which BTW doesn't have kgdb support).

Prevent this by explicitly calling strchr() instead.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Jason Wessel

kgdbts: Read buffer overflow

2009-12-11T14:43:15+00:00

Prevent write to put_buf[BUFMAX] in kgdb test suite.

If put_buf_cnt was BUFMAX - 1 at the earlier test,
`\0' is written to put_buf[BUFMAX].

Signed-off-by: Roel Kluin 
Signed-off-by: Jason Wessel

kgdbts: Use HW breakpoints with CONFIG_DEBUG_RODATA

2008-05-28T17:49:57+00:00

Whenever CONFIG_DEBUG_RODATA is set in the kernel config many kernel
text sections become read-only, and the use of software breakpoints in
the kgdb tests will cause the kernel to fail to complete the start up.

Until such time that there is an official API for modifying read-only
text sections hardware breakpoints must be used to run the do_fork or
sys_open tests or the tests get skipped.

Also fix the duplicated include reported by:
Huang Weiyi 

Signed-off-by: Jason Wessel

kgdb: use common ascii helpers and put_unaligned_be32 helper

2008-05-28T17:49:56+00:00

Signed-off-by: Harvey Harrison 
Signed-off-by: Andrew Morton 
Signed-off-by: Jason Wessel