linux-toradex.git/drivers/misc/mic, branch v4.4.93

misc: mic/scif: fix wrap around tests

2016-05-04T21:48:51+00:00

commit 7b64dbf849abdd7e769820e25120758f956a7f13 upstream.

Signed integer overflow is undefined.  Also I added a check for
"(offset < 0)" in scif_unregister() because that makes it match the
other conditions and because I didn't want to subtract a negative.

Fixes: ba612aa8b487 ('misc: mic: SCIF memory registration and unregistration')
Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

misc: mic/scif: fix error code in scif_create_remote_lookup()

2015-10-18T04:49:48+00:00

We should be returning -ENOMEM here instead of success.

Fixes: ba612aa8b487 ('misc: mic: SCIF memory registration and unregistration')
Signed-off-by: Dan Carpenter 
Reviewed-by: Sudeep Dutt 
Signed-off-by: Greg Kroah-Hartman

misc: mic/scif: re-take a lock on error path

2015-10-18T04:49:48+00:00

The caller expects that we take this lock again before returning
otherwise it you get double unlocks and races.

Fixes: ba612aa8b487 ('misc: mic: SCIF memory registration and unregistration')
Signed-off-by: Dan Carpenter 
Reviewed-by: Sudeep Dutt 
Signed-off-by: Greg Kroah-Hartman

misc: mic: fix memory leak

2015-10-18T04:42:29+00:00

In scif_node_connect() we were returning if the initialization of p2p_ji
fails. But at that time p2p_ij has already been initialized and
resources allocated for it. And since p2p_ij is not added to the list
till now so we will have a leak.
Lets deinitialize and release the resources connected to p2p_ij.

Signed-off-by: Sudip Mukherjee 
Reviewed-by: Sudeep Dutt 
Signed-off-by: Greg Kroah-Hartman

misc: mic: replace kfree with put_device

2015-10-18T04:42:29+00:00

Handle a failed device_register(), replace kfree() with put_device(),
which will call cosm/mbus/scif_release_dev().

Signed-off-by: Geliang Tang 
Signed-off-by: Greg Kroah-Hartman

misc: mic: Fix randconfig build error

2015-10-18T04:42:29+00:00

Fixes randconfig build error reported at
http://www.spinics.net/lists/kernel/msg2092346.html

Reported-by: Jim Davis 
Reviewed-by: Dasaratharaman Chandramouli 
Signed-off-by: Ashutosh Dixit 
Signed-off-by: Greg Kroah-Hartman

misc: mic: Fix SCIF build failure with IOMMU_SUPPORT disabled

2015-10-05T03:37:28+00:00

SCIF depends on IOVA which requires IOMMU_SUPPORT to be enabled.
The long term fix is to move IOVA from drivers/iommu to lib/
but this current patch should fix the reported issue.

Reported-by: Fengguang Wu 
Reviewed-by: Ashutosh Dixit 
Signed-off-by: Sudeep Dutt 
Signed-off-by: Greg Kroah-Hartman

misc: mic: SCIF RMA nodeqp and minor miscellaneous changes

2015-10-04T11:54:54+00:00

This patch adds the SCIF kernel node QP control messages required to
enable SCIF RMAs. Examples of such node QP control messages include
registration, unregistration, remote memory allocation requests,
remote memory unmap and SCIF remote fence requests.

The patch also updates the SCIF driver with minor changes required to
enable SCIF RMAs by adding the new files to the build, initializing
RMA specific information during SCIF endpoint creation, reserving SCIF
DMA channels, initializing SCIF RMA specific global data structures,
adding the IOCTL hooks required for SCIF RMAs and updating RMA
specific debugfs hooks.

Reviewed-by: Ashutosh Dixit 
Reviewed-by: Nikhil Rao 
Signed-off-by: Sudeep Dutt 
Signed-off-by: Greg Kroah-Hartman

misc: mic: SCIF fence

2015-10-04T11:54:54+00:00

This patch implements the fence APIs required to synchronize
DMAs. SCIF provides an interface to return a "mark" for all DMAs
programmed at the instant the API was called. Users can then "wait" on
the mark provided previously by blocking inside the kernel. Upon
receipt of a DMA completion interrupt the waiting thread is woken
up. There is also an interface to signal DMA completion by polling for
a location to be updated via a "signal" cookie to avoid the interrupt
overhead in the mark/wait interface. SCIF allows programming fences on
both the local and the remote node for both the mark/wait or the fence
signal APIs.

Reviewed-by: Ashutosh Dixit 
Reviewed-by: Nikhil Rao 
Signed-off-by: Jacek Lawrynowicz 
Signed-off-by: Sudeep Dutt 
Signed-off-by: Greg Kroah-Hartman

misc: mic: SCIF DMA and CPU copy interface

2015-10-04T11:54:54+00:00

SCIF allows users to read from or write to registered remote memory
via CPU copies or DMA. The API verifies that both local and remote
windows are valid before initiating the CPU or DMA transfers. SCIF has
optimized algorithms for handling byte aligned as well as cache line
aligned DMA engines. A registration cache is maintained to avoid the
overhead of pinning pages repeatedly if buffers are reused. The
registration cache is invalidated upon receipt of MMU notifier
callbacks.  SCIF windows are destroyed and the pages are unpinned only
once all prior DMAs initiated using that window are drained. Users can
request synchronous DMA operations as well as tail byte ordering if
required. CPU copies are always performed synchronously.

Reviewed-by: Ashutosh Dixit 
Reviewed-by: Nikhil Rao 
Signed-off-by: Sudeep Dutt 
Signed-off-by: Greg Kroah-Hartman