linux-toradex.git/drivers/misc/panel.c, branch v4.9.64 Linux kernel for Apalis and Colibri modules misc: panel: properly restore atomic counter on error path 2017-11-18T10:22:25+00:00 Willy Tarreau w@1wt.eu 2017-09-07T09:56:40+00:00 e81b96cab11f57506ade92656a76db8bbe7b6673 commit 93dc1774d2a4c7a298d5cdf78cc8acdcb7b1428d upstream. Commit f4757af ("staging: panel: Fix single-open policy race condition") introduced in 3.19-rc1 attempted to fix a race condition on the open, but failed to properly do it and used to exit without restoring the semaphore. This results in -EBUSY being returned after the first open error until the module is reloaded or the system restarted (ie: consecutive to a dual open resulting in -EBUSY or to a permission error). Fixes: f4757af85 # 3.19-rc1 Cc: Mariusz Gorski <marius.gorski@gmail.com> Signed-off-by: Willy Tarreau <w@1wt.eu> [wt: driver is in misc/panel in 4.9] Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
commit 93dc1774d2a4c7a298d5cdf78cc8acdcb7b1428d upstream.

Commit f4757af ("staging: panel: Fix single-open policy race condition")
introduced in 3.19-rc1 attempted to fix a race condition on the open, but
failed to properly do it and used to exit without restoring the semaphore.

This results in -EBUSY being returned after the first open error until
the module is reloaded or the system restarted (ie: consecutive to a
dual open resulting in -EBUSY or to a permission error).

Fixes: f4757af85 # 3.19-rc1
Cc: Mariusz Gorski <marius.gorski@gmail.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
[wt: driver is in misc/panel in 4.9]
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
misc: panel, convert struct to bitmap 2016-02-12T03:24:23+00:00 Daniel Chromik daniel.chromik@seznam.cz 2016-02-11T12:29:23+00:00 bea7433bac02b1fcee71494b3939e9feed2790cf There is an anonymous struct which is actually used as a bitmap. So convert the struct to a bitmap and change code accordingly where needed. This also allows for a cleanup of set_data_bits and set_ctrl_bits as they can use a common helper now. The helper can also be converted to a for loop instead of doing bit OR. And given it is a for loop now, bit masking (using BIT_MSK) is moved from the callers there too. Signed-off-by: Daniel Chromik <daniel.chromik@seznam.cz> Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Acked-by: Willy Tarreau <willy@haproxy.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
There is an anonymous struct which is actually used as a bitmap. So
convert the struct to a bitmap and change code accordingly where
needed.

This also allows for a cleanup of set_data_bits and set_ctrl_bits as
they can use a common helper now. The helper can also be converted to
a for loop instead of doing bit OR. And given it is a for loop now,
bit masking (using BIT_MSK) is moved from the callers there too.

Signed-off-by: Daniel Chromik <daniel.chromik@seznam.cz>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Acked-by: Willy Tarreau <willy@haproxy.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
misc: Move panel driver out of staging 2016-02-03T22:14:22+00:00 Ksenija Stanojevic ksenija.stanojevic@gmail.com 2016-02-03T11:31:49+00:00 305b37bd01c220a7a6285911d43c9884270257be Move panel driver from drivers/staging/panel to drivers/misc. Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Move panel driver from drivers/staging/panel to drivers/misc.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>