linux-toradex.git/drivers/misc/sgi-gru, branch v4.5

misc: sgi-gru: fix return of error

2015-10-04T11:55:59+00:00

If kzalloc() fails then gms is NULL and we are returning NULL, but the
functions which called this function gru_register_mmu_notifier() are not
expecting NULL as the return. They are expecting either a valid pointer
or the error code in ERR_PTR.

Signed-off-by: Sudip Mukherjee 
Acked-by: Dimitri Sivanich 
Signed-off-by: Greg Kroah-Hartman

misc: sgi-gru: gruhandles.c: Remove unused function

2015-10-04T11:55:59+00:00

Remove the function tfh_restart() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist 
Acked-by: Dimitri Sivanich 
Signed-off-by: Sudip Mukherjee 
Signed-off-by: Greg Kroah-Hartman

misc: sgi-gru: use time_before()

2015-10-04T11:55:59+00:00

To be future-proof and for better readability the time comparisons are
modified to use time_before() instead of plain, error-prone math.

Signed-off-by: Manuel Schölling 
Acked-by: Dimitri Sivanich 
Signed-off-by: Sudip Mukherjee 
Signed-off-by: Greg Kroah-Hartman

drivers/misc/sgi-gru: fix possible NULL dereference

2015-09-21T02:33:29+00:00

If mmu_find_ops() returns NULL then we are allocating memory for gms
using kzalloc. But kzalloc can return NULL and we were dereferencing gms
in gru_dbg().

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Greg Kroah-Hartman

drivers/misc/sgi-gru: remove unused variable

2015-09-21T02:27:59+00:00

dw was only assigned some value and was never reused.

Signed-off-by: Sudip Mukherjee 
Acked-by: Dimitri Sivanich 
Signed-off-by: Greg Kroah-Hartman

drivers/misc/sgi-gru: fix dereference of ERR_PTR

2015-09-21T02:27:59+00:00

gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should
not dereference it if it has returned error. And incase it has returned
error then wait for some time and try again.

Signed-off-by: Sudip Mukherjee 
Acked-by: Dimitri Sivanich 
Signed-off-by: Greg Kroah-Hartman

drivers/misc/sgi-gru: remove always false condition

2015-09-21T02:27:59+00:00

The member gid in struct gru_dump_chiplet_state_req is unsigned int. So
it can never be less than 0.

Signed-off-by: Sudip Mukherjee 
Acked-by: Dimitri Sivanich 
Signed-off-by: Greg Kroah-Hartman

drivers/misc/sgi-gru: make functions static

2015-09-21T02:27:59+00:00

The functions gru_get_cb_exception_detail_str() and gru_abort() were
only called locally from that file. We can make them static.

Signed-off-by: Sudip Mukherjee 
Acked-by: Dimitri Sivanich 
Signed-off-by: Greg Kroah-Hartman

drivers/misc/sgi-gru: add return on error

2015-09-21T02:27:58+00:00

If the buffer is too small then return the error and in the process
remove the variables which became unused.

Signed-off-by: Sudip Mukherjee 
Acked-by: Dimitri Sivanich 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'x86-uv-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into next

2014-06-03T22:48:23+00:00

Pull x86/UV changes from Ingo Molnar:
 "Continued updates for SGI UV 3 hardware support"

* 'x86-uv-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  x86/UV: Fix conditional in gru_exit()
  x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3